Message ID | 20200218100432.32433-4-frieder.schrempf@kontron.de |
---|---|
State | Accepted |
Headers | show |
Series | mtd: spinand: Fix reading and writing of bad block markers | expand |
On Tue, 2020-02-18 at 10:05:35 UTC, Schrempf Frieder wrote: > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > Currently when marking a block, we use spinand_erase_op() to erase > the block before writing the marker to the OOB area. Doing so without > waiting for the operation to finish can lead to the marking failing > silently and no bad block marker being written to the flash. > > In fact we don't need to do an erase at all before writing the BBM. > The ECC is disabled for raw accesses to the OOB data and we don't > need to work around any issues with chips reporting ECC errors as it > is known to be the case for raw NAND. > > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") > Cc: stable@vger.kernel.org > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index a94287884453..8dda51bbdd11 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -613,7 +613,6 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) }; int ret; - /* Erase block before marking it bad. */ ret = spinand_select_target(spinand, pos->target); if (ret) return ret; @@ -622,8 +621,6 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) if (ret) return ret; - spinand_erase_op(spinand, pos); - return spinand_write_page(spinand, &req); }