| Message ID | 20200117212225.18004-1-miquel.raynal@bootlin.com |
|---|---|
| State | Rejected |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver | expand |
Hi Miquel, sorry for responding so late. Le ven., janv. 17, 2020 at 22:22, Miquel Raynal <miquel.raynal@bootlin.com> a écrit : > This driver has no arch-specific instructions so we should be able to > compile it with any compiler. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Looks good to me. Reviewed-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/mtd/nand/raw/ingenic/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig > b/drivers/mtd/nand/raw/ingenic/Kconfig > index e30feb56b650..485abfa3f80b 100644 > --- a/drivers/mtd/nand/raw/ingenic/Kconfig > +++ b/drivers/mtd/nand/raw/ingenic/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > config MTD_NAND_JZ4780 > tristate "JZ4780 NAND controller" > - depends on JZ4780_NEMC > + depends on JZ4780_NEMC || COMPILE_TEST > help > Enables support for NAND Flash connected to the NEMC on JZ4780 SoC > based boards, using the BCH controller for hardware error > correction. > -- > 2.20.1 >
Hi Paul, Paul Cercueil <paul@crapouillou.net> wrote on Thu, 13 Feb 2020 12:59:44 -0300: > Hi Miquel, sorry for responding so late. > > > Le ven., janv. 17, 2020 at 22:22, Miquel Raynal <miquel.raynal@bootlin.com> a écrit : > > This driver has no arch-specific instructions so we should be able to > > compile it with any compiler. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > Looks good to me. > Reviewed-by: Paul Cercueil <paul@crapouillou.net> Actually I had errors reported by robots so I dropped it for now. You can see the errors that I bumped you in another thread, see: Subject: Fw: [miquelraynal:ecc-engine 1/60] ingenic_nand_drv.c:undefined reference to `jz4780_nemc_assert' Date: Tue, 21 Jan 2020 16:31:57 +0100 If you find some time to fix this, that would be very appreciated and helpful! Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig b/drivers/mtd/nand/raw/ingenic/Kconfig index e30feb56b650..485abfa3f80b 100644 --- a/drivers/mtd/nand/raw/ingenic/Kconfig +++ b/drivers/mtd/nand/raw/ingenic/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config MTD_NAND_JZ4780 tristate "JZ4780 NAND controller" - depends on JZ4780_NEMC + depends on JZ4780_NEMC || COMPILE_TEST help Enables support for NAND Flash connected to the NEMC on JZ4780 SoC based boards, using the BCH controller for hardware error correction.
This driver has no arch-specific instructions so we should be able to compile it with any compiler. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/raw/ingenic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)