diff mbox series

[1/2] mtd: nand: Kconfig: correct the MTD_NAND_ECC_SW_BCH select

Message ID 20190410195852.4066-1-anders.roxell@linaro.org
State Accepted
Delegated to: Miquel Raynal
Headers show
Series [1/2] mtd: nand: Kconfig: correct the MTD_NAND_ECC_SW_BCH select | expand

Commit Message

Anders Roxell April 10, 2019, 7:58 p.m. UTC
Config fragments should not have the prefix 'CONFIG_'.

Rework to remove the prefix 'CONFIG_' from 'CONFIG_MTD_NAND_ECC_SW_BCH'.

Fixes: 51ef1d0b2095 ("mtd: nand: Clarify Kconfig entry for software BCH ECC algorithm")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 drivers/mtd/devices/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Miquel Raynal April 16, 2019, 9:53 p.m. UTC | #1
Hi Anders,

Anders Roxell <anders.roxell@linaro.org> wrote on Wed, 10 Apr 2019
21:58:51 +0200:

> Config fragments should not have the prefix 'CONFIG_'.
> 
> Rework to remove the prefix 'CONFIG_' from 'CONFIG_MTD_NAND_ECC_SW_BCH'.
> 
> Fixes: 51ef1d0b2095 ("mtd: nand: Clarify Kconfig entry for software BCH ECC algorithm")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---

Thanks for both patches, do you mind if I squash these with the faulty
commits which are still in nand/next?

Thanks,
Miquèl
Anders Roxell April 18, 2019, 4:39 a.m. UTC | #2
On Tue, 16 Apr 2019 at 23:53, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Anders,
>
> Anders Roxell <anders.roxell@linaro.org> wrote on Wed, 10 Apr 2019
> 21:58:51 +0200:
>
> > Config fragments should not have the prefix 'CONFIG_'.
> >
> > Rework to remove the prefix 'CONFIG_' from 'CONFIG_MTD_NAND_ECC_SW_BCH'.
> >
> > Fixes: 51ef1d0b2095 ("mtd: nand: Clarify Kconfig entry for software BCH ECC algorithm")
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
>
> Thanks for both patches, do you mind if I squash these with the faulty
> commits which are still in nand/next?

That is fine by me.

Cheers,
Anders
Miquel Raynal April 18, 2019, 4:24 p.m. UTC | #3
Hi Anders,

Anders Roxell <anders.roxell@linaro.org> wrote on Thu, 18 Apr 2019
06:39:06 +0200:

> On Tue, 16 Apr 2019 at 23:53, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Anders,
> >
> > Anders Roxell <anders.roxell@linaro.org> wrote on Wed, 10 Apr 2019
> > 21:58:51 +0200:
> >  
> > > Config fragments should not have the prefix 'CONFIG_'.
> > >
> > > Rework to remove the prefix 'CONFIG_' from 'CONFIG_MTD_NAND_ECC_SW_BCH'.
> > >
> > > Fixes: 51ef1d0b2095 ("mtd: nand: Clarify Kconfig entry for software BCH ECC algorithm")
> > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > > ---  
> >
> > Thanks for both patches, do you mind if I squash these with the faulty
> > commits which are still in nand/next?  
> 
> That is fine by me.
> 
> Cheers,
> Anders


Thanks, I squashed this one and applied the second one.

Thanks,
Miquèl
diff mbox series

Patch

diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
index 7fcdaf6c279d..f9258d666846 100644
--- a/drivers/mtd/devices/Kconfig
+++ b/drivers/mtd/devices/Kconfig
@@ -207,7 +207,7 @@  comment "Disk-On-Chip Device Drivers"
 config MTD_DOCG3
 	tristate "M-Systems Disk-On-Chip G3"
 	select BCH
-	select BCH_CONST_PARAMS if !CONFIG_MTD_NAND_ECC_SW_BCH
+	select BCH_CONST_PARAMS if !MTD_NAND_ECC_SW_BCH
 	select BITREVERSE
 	help
 	  This provides an MTD device driver for the M-Systems DiskOnChip