From patchwork Mon Apr 1 04:49:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 1072306 X-Patchwork-Delegate: tudor.ambarus@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jIDwV8Ij"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qzHJfH+g"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44Xfz20gChz9sR0 for ; Mon, 1 Apr 2019 15:50:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EH3RY00KzwKLei2N6+qedq4ukcOAK1rSrsBW/4dSSzw=; b=jIDwV8IjHx9yCK Pu1dodnPKADKLTeuyoR1SIfe2q37La/kXdmqMIrzsZ2fVmFExEpq4dkvZPlQPiUiOeaC8YVGtM+rZ at5SM7+jxjwAc854FX5c0xMdRiisMLWLIiXy/k/G4FkdMY0zTz8207EuazZbyh/PC5DvhAAtctXxj 87F/lO2z98PYNIfY6ULl7AaEzM5Uan8uMW/Mc0XvFHATlKf+TbmsDqcmwnTDJPU2QeVJM6qO0I2Yr 17yM2Lz4hc3NgYEB1lMiVRvd03WUvKXfa0pA87qyM0oHoqp3gLcr5vqR0k4CKFGYFoF81FYKh3zt1 lgQlDy7I7waLJcw2CGOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAotU-0003zD-0V; Mon, 01 Apr 2019 04:50:00 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAotL-0003qt-OM for linux-mtd@lists.infradead.org; Mon, 01 Apr 2019 04:49:53 +0000 Received: by mail-pf1-x444.google.com with SMTP id 9so3890718pfj.13 for ; Sun, 31 Mar 2019 21:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PFXB52oKOKtWpAtHBWrZrl223idOSLqoOifI3aKzID0=; b=qzHJfH+gXoL+e3XbbyUDNtYpk4IUcqV6A7nMsP1VO9cEbancdc9BfuNgW0k7iGoUA8 fwQV4lrerur+amO7XbG/y7pG8+afQnY3we2UlsYVfhvfPNFQUdalU1bDj7B5dcMOP1UV mVIsQV7kCWqzBG9i1IpzA3VkK4CiGeQiWb+xHuPDxJFR+qDQowEWWPEfO7nJ6nrwnMIi TeY6o96IkcOIs8ScaKXXuyRrdcqw0tMKH+52bRvfwg4cq7ScqE2gH97+/yeyqBd2Cmfv nCq/IFkgdChjfDZKVUypMdlRmyvxn5kRFO4Y66YuCpXNp/rA46UCbdwHBugqBivASu9W YJxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PFXB52oKOKtWpAtHBWrZrl223idOSLqoOifI3aKzID0=; b=QEb5a2wvuzJaX/KDVnWQtDtxw+7xpDZV42VKl9H5CMtQ23ExuyNwmwoTQsMlrC/kqp g6dFuUQPB9tGnwhtbePd4PhHY/sDGLkIfgk7u+qnm7+7STH/CMJNV5lcduW1E1XI6PYF 0Z8J5sZ9fccg5YqCe8zsheRbzbyMoaQU6EsVcgAXR8vadV/2+XgliI0pDdRrXe6IcMUI PYdKXKIlX+da7i4wHLvFaJ7BqyfwvKHLooNTJevlXKzsKkprPvFjtnzLfKO5uS2AgrBR iQkGJmCGMj1agmZKAYohjqtdyx3+vOHTr9l0YKct9NMTFQ23G9DfSvu+Ghmwv3hrXs/z QjhQ== X-Gm-Message-State: APjAAAUiUAYFW0XA+/64vQDyKx6GBpdfTxvPB+K8bJZRB2UW4/RY9FMQ 2Ad1v2s1MMV1YnfvA0lY5Rkcdy/F X-Google-Smtp-Source: APXvYqxA6JlUi0W041FN16C641ZvmSjGPW8+EAd+/bdmJ+gnOhuKIAxGTRBVkdIehKj9nBq90d2Ulg== X-Received: by 2002:a63:550d:: with SMTP id j13mr13455225pgb.18.1554094190765; Sun, 31 Mar 2019 21:49:50 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i31sm16256097pgi.36.2019.03.31.21.49.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 31 Mar 2019 21:49:49 -0700 (PDT) From: Andrey Smirnov To: linux-mtd@lists.infradead.org Subject: [PATCH 2/3] mtd: devices: m25p80: Drop extra length clamping in m25p80_write() Date: Sun, 31 Mar 2019 21:49:37 -0700 Message-Id: <20190401044938.31237-2-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190401044938.31237-1-andrew.smirnov@gmail.com> References: <20190401044938.31237-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190331_214951_788927_102B249F X-CRM114-Status: GOOD ( 11.77 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andrew.smirnov[at]gmail.com) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Andrey Smirnov , linux-kernel@vger.kernel.org, Boris Brezillon , Brian Norris , Chris Healy Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org All of the needed length clamping should already be taken care of by spi_mem_adjust_op_size(). No check like this is done in read path, so this extra check in write doesn't appear to be necessary. Drop it. Signed-off-by: Andrey Smirnov Cc: Brian Norris Cc: Boris Brezillon Cc: Marek Vasut Cc: Chris Healy Cc: linux-mtd@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/mtd/devices/m25p80.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 114f8ccea85b..a54cad9bb6e3 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -103,7 +103,6 @@ static ssize_t m25p80_write(struct spi_nor *nor, loff_t to, size_t len, ret = spi_mem_adjust_op_size(flash->spimem, &op); if (ret) return ret; - op.data.nbytes = len < op.data.nbytes ? len : op.data.nbytes; ret = spi_mem_exec_op(flash->spimem, &op); if (ret)