| Message ID | 20181217215015.32392-1-richard@nod.at |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | mtdram: Expose module parameters | expand |
From: Boris Brezillon <boris.brezillon@bootlin.com> On Mon, 2018-12-17 at 21:50:15 UTC, Richard Weinberger wrote: > Since we can set module parameters also when a driver is built in, > it makes no sense to protect module parameter with #ifdef MODULE. > Now the mtdram sizes can also set when the module is not a loadable > module. > > Signed-off-by: Richard Weinberger <richard@nod.at> Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks. Boris
diff --git a/drivers/mtd/devices/mtdram.c b/drivers/mtd/devices/mtdram.c index 222cc347ce5d..3669d67cacb8 100644 --- a/drivers/mtd/devices/mtdram.c +++ b/drivers/mtd/devices/mtdram.c @@ -25,14 +25,12 @@ static unsigned long writebuf_size = 64; #define MTDRAM_TOTAL_SIZE (total_size * 1024) #define MTDRAM_ERASE_SIZE (erase_size * 1024) -#ifdef MODULE module_param(total_size, ulong, 0); MODULE_PARM_DESC(total_size, "Total device size in KiB"); module_param(erase_size, ulong, 0); MODULE_PARM_DESC(erase_size, "Device erase block size in KiB"); module_param(writebuf_size, ulong, 0); MODULE_PARM_DESC(writebuf_size, "Device write buf size in Bytes (Default: 64)"); -#endif // We could store these in the mtd structure, but we only support 1 device.. static struct mtd_info *mtd_info;
Since we can set module parameters also when a driver is built in, it makes no sense to protect module parameter with #ifdef MODULE. Now the mtdram sizes can also set when the module is not a loadable module. Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/mtd/devices/mtdram.c | 2 -- 1 file changed, 2 deletions(-)