From patchwork Thu Nov 29 18:15:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander A Sverdlin X-Patchwork-Id: 1005585 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nokia.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UQezx1UT"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=nokia.onmicrosoft.com header.i=@nokia.onmicrosoft.com header.b="l+G+UGj6"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 435Qgb34blz9s5c for ; Fri, 30 Nov 2018 05:15:55 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=b59vIAFIkrhW1SQsFjZMLA6M6h4xf0ytlGgIMfDKJP8=; b=UQezx1UTJYDnMh byQAWUh34m1jt79gsR2H9dJa4boORurbm0BzjZGd4C43pyB0Oa3AKN27CU1q47lKhu/fzM3E7DSZf xb6yry98bPdmFSlXmImEvObKoVS5ikkV9OblexW0LzyEEWPDeD/vcB9QsptkocnXgWCy4HDpO4zYT SZX07vHbduCa+SSERX8H6YlXDZkPg2AS/ghlYoUpdRIfdcW9miB31MpVGw/F8q13wYU+SDNxJpn8P IEq9CAbZseRZIUgHxaTXt0OB0LYnrsD1JMzkpJXQWDbVyln1kQnSLhcoUpEEoFCVqWSVQmDjVlKVS oxZ1hWq1GYzpMx2kJmKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSQqs-0004Yd-Qv; Thu, 29 Nov 2018 18:15:50 +0000 Received: from mail-eopbgr80125.outbound.protection.outlook.com ([40.107.8.125] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSQqp-0004YA-EH for linux-mtd@lists.infradead.org; Thu, 29 Nov 2018 18:15:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hN//o3mj4NJ0TtqwnoyEvGxcxco64euOAyRCElowmBo=; b=l+G+UGj6rQfSDzy4pr3etrP6odh93Ts9BabqYylOi7a75R4f20fGhSoXc0iDiIfVzL37mBHrzBxHNsZP+aBqLm0GD1Ud+eJ/2Ac0K+GuXdknsDcSwm2v3RYlTEh5DkbDPPrv8kruR4WGSXWnHCbI+lEqrq1iLrtLZLEsgTHz/DI= Received: from AM5PR0701MB2724.eurprd07.prod.outlook.com (10.173.93.138) by AM5PR0701MB2291.eurprd07.prod.outlook.com (10.169.152.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.8; Thu, 29 Nov 2018 18:15:34 +0000 Received: from AM5PR0701MB2724.eurprd07.prod.outlook.com ([fe80::e5b4:4484:2e68:997e]) by AM5PR0701MB2724.eurprd07.prod.outlook.com ([fe80::e5b4:4484:2e68:997e%3]) with mapi id 15.20.1404.010; Thu, 29 Nov 2018 18:15:34 +0000 From: "Sverdlin, Alexander (Nokia - DE/Ulm)" To: "linux-mtd@lists.infradead.org" Subject: [PATCH] mtd: spi-nor: Provide default address width and latency for map selection Thread-Topic: [PATCH] mtd: spi-nor: Provide default address width and latency for map selection Thread-Index: AQHUiA+FlLtDXdv9xEuErkPcD5m8gw== Date: Thu, 29 Nov 2018 18:15:34 +0000 Message-ID: <20181129181519.15681-1-alexander.sverdlin@nokia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [131.228.2.0] x-mailer: git-send-email 2.19.2 x-clientproxiedby: HE1P195CA0020.EURP195.PROD.OUTLOOK.COM (2603:10a6:3:fd::30) To AM5PR0701MB2724.eurprd07.prod.outlook.com (2603:10a6:203:76::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=alexander.sverdlin@nokia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM5PR0701MB2291; 6:qJSjIJZFcEKJOs2pyrvC4u0KGy67wKgl7BIw6sNpyoH4iYNxxQrZt9x2RnAPnQACjJTfcdP9cl/K8r0/YmD5QvLuioCeeneWXe0Kq9JOSgPDWHLPxpjS0+R2j777NUwV87ooADJLIoYTJfpQ4zSaCMaRpSyJpci5iHRPx7DvQcEicQnZpl40+fg2AP3bpubKW+R/vsSeyxp2siRrw4iKzIjvRIMxyIpoWghBG5XmQdhi7CXAUAfYUD/mYOScMDcn7ZFGdbpW55Jio4uaS0aaNxDGMze6kAzKuAbq7ixhXS3DHmfurHryzt4KL8vXnQZIImNTolMBFw4kx3xa3tXmSGez7XAPJaaPwF2hAL4FoNqFm0nWN4DOmHNnaiwAhb3v8dgXxTt7PV1cpYWtIqQBEVw6fj01C6bEyA2ZWrsiZz/FXiAvdakxUPLSd54BH39nf4Cb6K0mUvndAoseJpXe3Q==; 5:1LMOK6+5wMvd21mCsm5rXP+9fbT7kvkNsT/LuX69MOosXCG3+Cq7vh7+8MUxTvYqWI2YZ8Vx02Xn9QtCvRaIUSGBOhS6F4NtemjajO7+qmvscWHAjzSCDmHieuVkv7OnThgGw4237wpJbBnNA/y/ddnzL9BNmYr5n23dKZN3LFE=; 7:ti9St+HpxPtd4xzGm5KN88iQV3iKAVZvNVOstPMFSDqbYaB6lEVTLaHBV++M2wkKZMAJ+rkQR6erSCW3Hi0OtRa26t5KVcTgepv3Lo7TJTYWypcKwFNIGIiPVp2lRA4iHofbMEbNkvBG1bficH0WZA== x-ms-office365-filtering-correlation-id: 88501564-3a42-465b-7413-08d65626a745 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM5PR0701MB2291; x-ms-traffictypediagnostic: AM5PR0701MB2291: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231453)(999002)(11241501185)(806100)(944501410)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:AM5PR0701MB2291; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0701MB2291; x-forefront-prvs: 0871917CDA x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(136003)(366004)(346002)(396003)(199004)(189003)(86362001)(102836004)(97736004)(4326008)(6486002)(486006)(54906003)(386003)(6506007)(1076002)(71190400001)(5640700003)(105586002)(71200400001)(106356001)(2351001)(25786009)(36756003)(305945005)(7736002)(6436002)(39060400002)(2906002)(2616005)(476003)(99286004)(5660300001)(52116002)(14454004)(8936002)(66066001)(6512007)(316002)(256004)(6916009)(81156014)(53936002)(2501003)(81166006)(478600001)(8676002)(50226002)(6116002)(68736007)(3846002)(186003)(26005)(7756004); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR0701MB2291; H:AM5PR0701MB2724.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nokia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: W/DvFD+KOuzRKSRQMldBAamEWc5kJq6i+/9l1nOYELTbFCj+URRWiGzUdIje08bEZuZNRDNjUfoOOyGxCuDYPmy4jCfvMXnTAu8VvRMPNUW4UkYmZTUmqM+vHV9P5h0xJzN1OpBt8cqwgTV8S3VEq71atz8+7FXm3NFNg8C7xC20DfVQ55jaYioM3Dw/iOXZdsnk2ZSxdI3yqmW1mHHoMCF415O+Pah+vEA6vF7IQbLkUeCvC95HhVWs5zu687zyPiOLBPWqleJHBM3GIricLCyDXCmowwZ2xRy3HzCuPyjw7AMjkKsNTdqwvXoCb8mb05GB7DnjgIJa2Bp5yIKQ/0oF+va7mGHjaAk4igh1jco= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88501564-3a42-465b-7413-08d65626a745 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2018 18:15:34.3502 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0701MB2291 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181129_101547_484859_426150D5 X-CRM114-Status: GOOD ( 13.20 ) X-Spam-Score: -1.5 (-) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-1.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [40.107.8.125 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.5 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Richard Weinberger , Tudor Ambarus , Marek Vasut , "Sverdlin, Alexander \(Nokia - DE/Ulm\)" , Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org JESD216 allows "variable address length" and "variable latency" in Configuration Detection Command Descriptors, in other words "as-is". And they are still unset during Sector Map Parameter Table parsing, which led to "map_id" determined erroneously as 0 for, e.g. S25FS128S. Fixes: b038e8e3b ("mtd: spi-nor: parse SFDP Sector Map Parameter Table") Signed-off-by: Alexander Sverdlin --- drivers/mtd/spi-nor/spi-nor.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 828d03e..5557c89 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -2893,6 +2893,16 @@ static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32 *smpt) nor->read_opcode = SMPT_CMD_OPCODE(smpt[i]); addr = smpt[i + 1]; + /* + * JESD216 allows to omit particular address length or latency + * specification in the header and at this point they are still + * unset, so we need some heuristics. One example is S25FS128S. + */ + if (!nor->addr_width) + nor->addr_width = 3; + if (!nor->read_dummy) + nor->read_dummy = 8; + err = spi_nor_read_raw(nor, addr, 1, &data_byte); if (err) goto out;