Message ID | 20181106150810.9569-11-boris.brezillon@bootlin.com |
---|---|
State | Changes Requested |
Delegated to: | Miquel Raynal |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pww8OOLJ"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="e3GsqRTc"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42qCd74DSjz9sBN for <incoming@patchwork.ozlabs.org>; Wed, 7 Nov 2018 02:09:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=F4K9BzvBgBLPT2Jig/u+6gKfueqNEcU3FXNy/7hUOyo=; b=Pww8OOLJ2lfBiT7RXmVrmnALgI OBDMJmmBCHfyPttHLdrBkIE5t3THzTNkofGXM0nKL2iOpnRxhJroExdceEkuOmmx/fjgZKZv+yoBf 58cqF1+9qXp8RhdC38yJO0WuYHEYhJSTA5QZu3ARZdBU6MhBsbR+R/Nm+lErD4dUGR+eXys2nUS9/ a+GUcmJKykoogaDU9qP+21q1yf6v3pp8tQCOTn2t0pSD0HvxtKoVYyN7zxtoGZ3G2gzLEGMmQ9a6s sN5+Gf1qEjLyRdEVID4g05UllB+ZHpIdCh6w43ftDbB4fJVlYMpv+otFe9gdAfuoOer7NZRKG04C/ pMhsLXJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK2yn-0002v2-W0; Tue, 06 Nov 2018 15:09:22 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK2yJ-0002M8-9y for linux-mtd@bombadil.infradead.org; Tue, 06 Nov 2018 15:08:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lHxRqwsMNWCj6ITnFZyVUzDaOyObj5DIqlh8gqj+lxE=; b=e3GsqRTc7aOgynkVZsYCXzutm bXXTiUmBkXfKr9Qf0ML1l/YqlEuNfZfvDc1tlD3l/Pluv+VsCyyNXNVA/3g6cT1/jx0OqUUTnksVJ qDgq2G61m4i4UFn0am7NGSKeiHm5KbXUDhpY9PP31jVPUA6Fvj3eOBFlKZfoFO1BGzyoIeXR3iGLk fwUGsxeEy+z9BgAcU7WpKzK0mD39Dfu+V2jpbM12DNH/Lm1gI+g114nL7i2B/Ye9ExIdYxliBP7lE lZGMpNjlyA7Q6yvSaOQNWXPpOYxpcns1QlMrAd/f9G216MM8ZsPcep6PZlb4wHo+89PW5NfwOtTp0 FxF/aX3sw==; Received: from mail.bootlin.com ([62.4.15.54]) by casper.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gK2yF-00075v-V2 for linux-mtd@lists.infradead.org; Tue, 06 Nov 2018 15:08:49 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 4B7B0207CD; Tue, 6 Nov 2018 16:08:42 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost.localdomain (aaubervilliers-681-1-93-44.w90-88.abo.wanadoo.fr [90.88.34.44]) by mail.bootlin.com (Postfix) with ESMTPSA id 16AE020889; Tue, 6 Nov 2018 16:08:15 +0100 (CET) From: Boris Brezillon <boris.brezillon@bootlin.com> To: Boris Brezillon <boris.brezillon@bootlin.com>, Richard Weinberger <richard@nod.at>, Miquel Raynal <miquel.raynal@bootlin.com>, linux-mtd@lists.infradead.org Subject: [PATCH v2 10/22] mtd: rawnand: ams-delta: Check mtd_device_register() return code Date: Tue, 6 Nov 2018 16:07:58 +0100 Message-Id: <20181106150810.9569-11-boris.brezillon@bootlin.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181106150810.9569-1-boris.brezillon@bootlin.com> References: <20181106150810.9569-1-boris.brezillon@bootlin.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Cc: Maxim Levitsky <maximlevitsky@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Tudor Ambarus <tudor.ambarus@microchip.com>, Janusz Krzysztofik <jmkrzyszt@gmail.com>, Stefan Agner <stefan@agner.ch>, Masahiro Yamada <yamada.masahiro@socionext.com>, Harvey Hunt <harveyhuntnexus@gmail.com>, Marc Gonzalez <marc.w.gonzalez@free.fr>, Han Xu <han.xu@nxp.com>, Xiaolei Li <xiaolei.li@mediatek.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
mtd: rawnand: 3rd batch of cleanup
|
expand
|
diff --git a/drivers/mtd/nand/raw/ams-delta.c b/drivers/mtd/nand/raw/ams-delta.c index 2f49be4077df..ccdd114495bc 100644 --- a/drivers/mtd/nand/raw/ams-delta.c +++ b/drivers/mtd/nand/raw/ams-delta.c @@ -281,10 +281,16 @@ static int ams_delta_init(struct platform_device *pdev) goto err_unmap; /* Register the partitions */ - mtd_device_register(mtd, partition_info, ARRAY_SIZE(partition_info)); + err = mtd_device_register(mtd, partition_info, + ARRAY_SIZE(partition_info)); + if (err) + goto err_nand_cleanup; return 0; +err_nand_cleanup: + nand_cleanup(this); + err_unmap: iounmap(io_base);
mtd_device_register() can fail, and when it does we should propagate the error and cleanup what has been done before. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- Changes in v2: - None --- drivers/mtd/nand/raw/ams-delta.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)