From patchwork Thu Jul 26 14:05:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris Brezillon X-Patchwork-Id: 949704 X-Patchwork-Delegate: david.oberhollenzer@sigma-star.at Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mlCsop2r"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41bv5W3Gx8z9ryl for ; Fri, 27 Jul 2018 00:06:07 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=SvhS/a2/EEqcb4KoAT5G/OhfORlDuwq01llBP7dIT/o=; b=mlC sop2rq7OPMWydFmQnL8iWK5XX8nEtoc0ZMavwtoUMoA9lAycffmh6wjpW0f98B+GPMO0j7IxNFzqh rxgPQJ8ti3EvgIOxIX7qVvfUlxUgXnkZPWK+sYRJNPCre1olW3QY2nbauJVuwoevbv45fr5t/g8RZ mR3fmwnot4k+JsHRPM+n/e+6/5RjpvSV7d+hv8FWVT4Sv5m8G4+I2GE270d3uZodvNVvqRd6HBn0K GA+Hfq2N9JfXrc49p0b+7XBLJpA1VS1uGwYb7kbkUfnfwOO8cAuHoPEF/+pipwv1cwHTYp0tmJmW7 8eplHWTugPhhA9Dgfakkf24ax/3a2bg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1figtx-0000oG-Ab; Thu, 26 Jul 2018 14:05:57 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1figtq-0000mm-Dy for linux-mtd@lists.infradead.org; Thu, 26 Jul 2018 14:05:55 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 9BF4420720; Thu, 26 Jul 2018 16:05:38 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost.localdomain (AAubervilliers-681-1-78-122.w90-88.abo.wanadoo.fr [90.88.20.122]) by mail.bootlin.com (Postfix) with ESMTPSA id 5F2A320618; Thu, 26 Jul 2018 16:05:38 +0200 (CEST) From: Boris Brezillon To: David Oberhollenzer Subject: [PATCH mtd-utils] ubi-utils: ubimkvol: Initialize req to zero to make sure no flags are set by default Date: Thu, 26 Jul 2018 16:05:29 +0200 Message-Id: <20180726140529.6261-1-boris.brezillon@bootlin.com> X-Mailer: git-send-email 2.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180726_070550_607537_CEF766EE X-CRM114-Status: GOOD ( 15.28 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [62.4.15.54 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Quentin Schulz , Marek Vasut , Richard Weinberger , Boris Brezillon , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The program expects req.flags to be zero-initialized, but it's not the case. Let's explicitly initialize req to zero at declaration time. Fixes: 7b4a65a27d26 ("ubi-utils: ubimkvol: add support for skipping CRC check of a static volume when opening") Signed-off-by: Boris Brezillon Reviewed-by: Quentin Schulz --- ubi-utils/ubimkvol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ubi-utils/ubimkvol.c b/ubi-utils/ubimkvol.c index 195006133216..b709b43a8318 100644 --- a/ubi-utils/ubimkvol.c +++ b/ubi-utils/ubimkvol.c @@ -221,7 +221,7 @@ int main(int argc, char * const argv[]) libubi_t libubi; struct ubi_dev_info dev_info; struct ubi_vol_info vol_info; - struct ubi_mkvol_request req; + struct ubi_mkvol_request req = { }; err = parse_opt(argc, argv); if (err)