| Message ID | 20180726140529.6261-1-boris.brezillon@bootlin.com |
|---|---|
| State | Accepted |
| Delegated to: | David Oberhollenzer |
| Headers | show |
| Series | [mtd-utils] ubi-utils: ubimkvol: Initialize req to zero to make sure no flags are set by default | expand |
Hi Boris, On Thu, Jul 26, 2018 at 04:05:29PM +0200, Boris Brezillon wrote: > The program expects req.flags to be zero-initialized, but it's not > the case. Let's explicitly initialize req to zero at declaration time. > > Fixes: 7b4a65a27d26 ("ubi-utils: ubimkvol: add support for skipping CRC check of a static volume when opening") > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com> > --- > ubi-utils/ubimkvol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ubi-utils/ubimkvol.c b/ubi-utils/ubimkvol.c > index 195006133216..b709b43a8318 100644 > --- a/ubi-utils/ubimkvol.c > +++ b/ubi-utils/ubimkvol.c > @@ -221,7 +221,7 @@ int main(int argc, char * const argv[]) > libubi_t libubi; > struct ubi_dev_info dev_info; > struct ubi_vol_info vol_info; > - struct ubi_mkvol_request req; > + struct ubi_mkvol_request req = { }; > > err = parse_opt(argc, argv); > if (err) > -- > 2.14.1 >
Applied to mtd-utils.git master. Thanks, David
diff --git a/ubi-utils/ubimkvol.c b/ubi-utils/ubimkvol.c index 195006133216..b709b43a8318 100644 --- a/ubi-utils/ubimkvol.c +++ b/ubi-utils/ubimkvol.c @@ -221,7 +221,7 @@ int main(int argc, char * const argv[]) libubi_t libubi; struct ubi_dev_info dev_info; struct ubi_vol_info vol_info; - struct ubi_mkvol_request req; + struct ubi_mkvol_request req = { }; err = parse_opt(argc, argv); if (err)
The program expects req.flags to be zero-initialized, but it's not the case. Let's explicitly initialize req to zero at declaration time. Fixes: 7b4a65a27d26 ("ubi-utils: ubimkvol: add support for skipping CRC check of a static volume when opening") Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- ubi-utils/ubimkvol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)