| Message ID | 20180622070425.26573-1-geert@linux-m68k.org |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | [v2] mtd: dataflash: Use ULL suffix for 64-bit constants | expand |
On Fri, 22 Jun 2018 09:04:25 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > With gcc 4.1.2 when compiling for 32-bit: > > drivers/mtd/devices/mtd_dataflash.c:736: warning: integer constant is too large for ‘long’ type > drivers/mtd/devices/mtd_dataflash.c:737: warning: integer constant is too large for ‘long’ type > > Add the missing "ULL" suffixes to fix this. > > Fixes: 67e4145ebf2c161d ("mtd: dataflash: Add flash_info for AT45DB641E") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Andrey Smirnov <andrew.smirnov@gmail.com> Applied. Thanks, Boris > --- > v2: > - Add Acked-by. > --- > drivers/mtd/devices/mtd_dataflash.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c > index 3a6f450d1093c4c5..53febe8a68c3cdfa 100644 > --- a/drivers/mtd/devices/mtd_dataflash.c > +++ b/drivers/mtd/devices/mtd_dataflash.c > @@ -733,8 +733,8 @@ static struct flash_info dataflash_data[] = { > { "AT45DB642x", 0x1f2800, 8192, 1056, 11, SUP_POW2PS}, > { "at45db642d", 0x1f2800, 8192, 1024, 10, SUP_POW2PS | IS_POW2PS}, > > - { "AT45DB641E", 0x1f28000100, 32768, 264, 9, SUP_EXTID | SUP_POW2PS}, > - { "at45db641e", 0x1f28000100, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS}, > + { "AT45DB641E", 0x1f28000100ULL, 32768, 264, 9, SUP_EXTID | SUP_POW2PS}, > + { "at45db641e", 0x1f28000100ULL, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS}, > }; > > static struct flash_info *jedec_lookup(struct spi_device *spi,
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c index 3a6f450d1093c4c5..53febe8a68c3cdfa 100644 --- a/drivers/mtd/devices/mtd_dataflash.c +++ b/drivers/mtd/devices/mtd_dataflash.c @@ -733,8 +733,8 @@ static struct flash_info dataflash_data[] = { { "AT45DB642x", 0x1f2800, 8192, 1056, 11, SUP_POW2PS}, { "at45db642d", 0x1f2800, 8192, 1024, 10, SUP_POW2PS | IS_POW2PS}, - { "AT45DB641E", 0x1f28000100, 32768, 264, 9, SUP_EXTID | SUP_POW2PS}, - { "at45db641e", 0x1f28000100, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS}, + { "AT45DB641E", 0x1f28000100ULL, 32768, 264, 9, SUP_EXTID | SUP_POW2PS}, + { "at45db641e", 0x1f28000100ULL, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS}, }; static struct flash_info *jedec_lookup(struct spi_device *spi,
With gcc 4.1.2 when compiling for 32-bit: drivers/mtd/devices/mtd_dataflash.c:736: warning: integer constant is too large for ‘long’ type drivers/mtd/devices/mtd_dataflash.c:737: warning: integer constant is too large for ‘long’ type Add the missing "ULL" suffixes to fix this. Fixes: 67e4145ebf2c161d ("mtd: dataflash: Add flash_info for AT45DB641E") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- v2: - Add Acked-by. --- drivers/mtd/devices/mtd_dataflash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)