From patchwork Wed May 30 09:32:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: IKEGAMI Tokunori X-Patchwork-Id: 922657 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=allied-telesis.co.jp Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rBGYSPGH"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40wlmD4gP3z9s08 for ; Wed, 30 May 2018 19:34:20 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=def70zv81hyXXo7tpaCCcLLvLh/z5qTvir1d3T5DKSk=; b=rBGYSPGHJ1b/PjY0N0ZnoGXLnm ZvbmcLIRtSeTGDig6p7Z1gfrx4pRJV8kWX4IoaMMAiEe2lxI/JsE28vy6f6nROSa99iSz+r3NP/F4 Jp4iIIPjxwXhFlKAusmpNnYnTIUUOUPap6CLopP5z6areO1pRQj+eEUBLP+ysTNNbXJH1QCCypYg/ shWdPq284WDFeg11vVDaooRoWPMQUGeWcTk/3sxagi6ulHHs9N4vmESLu3YmSVyGyZpEA1P4ZLMlg AvmT7mFLYz6S7nAYXt9cNeJY4NarKsM0uid7/6ZvCeRxV5otpBj02JhgS9W7YjCjjCNT8usAyAwQC QBtE8uMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNxUk-0007tb-4t; Wed, 30 May 2018 09:34:14 +0000 Received: from mail1.bemta8.messagelabs.com ([216.82.243.204]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNxTp-0007Mp-7R for linux-mtd@lists.infradead.org; Wed, 30 May 2018 09:33:26 +0000 Received: from [216.82.242.36] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-12.bemta-8.messagelabs.com id CA/54-22251-2DF6E0B5; Wed, 30 May 2018 09:33:06 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRWlGSWpSXmKPExsUyLfyHiO6lfL5 og63rmS12Ny1jd2D02LykPoAxijUzLym/IoE14/a+qoJr/BW7J8Q2MC7h7WLk4hASmMso0T5l JQuE84tR4umr18xdjJwcbAKmEtNfLWQEsUUEDCVWTm0BK2IWWM4ssWnDeiaQhLBAhMSFe+3sI DaLgKrElalb2UBsXgEHiYfdDWC2hIC8xOE3TawgNqeAo8T1xh4WEFsIqKavZRKUrSnxvOc7I0 R9sMTio1+YJjDyLmBkWMWoXpxaVJZapGukl1SUmZ5RkpuYmaNraGChl5taXJyYnpqTmFSsl5y fu4kRGAoMQLCD8ecfp0OMkhxMSqK8zJl80UJ8SfkplRmJxRnxRaU5qcWHGGU4OJQkeJvygHKC RanpqRVpmTnAoIRJS3DwKInw/sgFSvMWFyTmFmemQ6ROMSpKifNOAekTAElklObBtcEi4RKjr JQwLyPQIUI8BalFuZklqPKvGMU5GJWEebtApvBk5pXATX8FtJgJaPGTidwgi0sSEVJSDYx+Ww LZM5e9rxMSrTKfvPru+28H+DXcZ29we7jk6vLuZfYch7ZlulSZGPFeP/FP3Hqd1O1TT24eaVP pWrnikXlK11pe5QctHm9PdSyyXGR0XLZ1RrDiM+Vj31ZfVi75IXlpF/O85yWPHbhXv74VFNyU o/nuCN9aESuuZ/fkZ/vESz/Y9SluYdlaJZbijERDLeai4kQAm3iLCH8CAAA= X-Env-Sender: ikegami@allied-telesis.co.jp X-Msg-Ref: server-8.tower-94.messagelabs.com!1527672784!188958263!1 X-Originating-IP: [150.87.248.20] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.9.15; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13810 invoked from network); 30 May 2018 09:33:05 -0000 Received: from abricot-inet.allied-telesis.co.jp (HELO TKY-DS01.at.lc) (150.87.248.20) by server-8.tower-94.messagelabs.com with SMTP; 30 May 2018 09:33:05 -0000 Received: from swim-manx.rd.allied-telesis.co.jp ([150.87.21.50]) by TKY-DS01.at.lc with Microsoft SMTPSVC(8.0.9200.16384); Wed, 30 May 2018 18:33:04 +0900 Received: from ikegami-pc.rd.allied-telesis.co.jp by swim-manx.rd.allied-telesis.co.jp (AlliedTelesis SMTPRS 1.3 pl 1 ++E6B86F8C687C6288D9B5559052954DC9) with ESMTP id ; Wed, 30 May 2018 18:33:03 +0900 From: Tokunori Ikegami To: Boris Brezillon Subject: [PATCH v8 1/5] mtd: cfi_cmdset_0002: Change write buffer to check correct value Date: Wed, 30 May 2018 18:32:26 +0900 Message-Id: <20180530093230.3240-2-ikegami@allied-telesis.co.jp> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180530093230.3240-1-ikegami@allied-telesis.co.jp> References: <20180530093230.3240-1-ikegami@allied-telesis.co.jp> X-OriginalArrivalTime: 30 May 2018 09:33:04.0326 (UTC) FILETIME=[35AC0660:01D3F7F9] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180530_023317_363304_163C2992 X-CRM114-Status: GOOD ( 19.80 ) X-Spam-Score: -1.7 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [216.82.243.204 listed in list.dnswl.org] -1.7 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [216.82.243.204 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Tokunori Ikegami , Richard Weinberger , stable@vger.kernel.org, Marek Vasut , Chris Packham , linux-mtd@lists.infradead.org, Cyrille Pitchen , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org For the word write it is checked if the chip has the correct value. But it is not checked for the write buffer as only checked if ready. To make sure for the write buffer change to check the value. It is enough as this patch is only checking the last written word. Since it is described by data sheets to check the operation status. Signed-off-by: Tokunori Ikegami Reviewed-by: Joakim Tjernlund Cc: Chris Packham Cc: Brian Norris Cc: David Woodhouse Cc: Boris Brezillon Cc: Marek Vasut Cc: Richard Weinberger Cc: Cyrille Pitchen Cc: linux-mtd@lists.infradead.org Cc: stable@vger.kernel.org --- Changes since v7: - None. Changes since v6: - Change Cc: Joakim Tjernlund tag as Reviewed-by: tag. - Add Cc: stable tag. Changes since v5: - None since the v4 change is just combined as same series by v6. Changes since v3: - Removed to check if chip ready. Changes since v2: - Just updated the patch to add v3 version into subject and desribe a changelog. Changes since v1: - Just changed to add Brian as Cc and the patch is sent to Boris-san as To Changes since v0: - Changed Split the part to change write buffer from the v1 patch drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index e397b80e40cc..1d6be8c63d39 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, if (time_after(jiffies, timeo) && !chip_ready(map, adr)) break; - if (chip_ready(map, adr)) { + if (chip_good(map, adr, datum)) { xip_enable(map, chip, adr); goto op_done; }