From patchwork Fri Apr 20 08:19:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Lefebvre X-Patchwork-Id: 901791 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=essensium.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WX5cxFvX"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="X/c5s/6e"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=essensium-com.20150623.gappssmtp.com header.i=@essensium-com.20150623.gappssmtp.com header.b="a2/5+fFl"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40S8gK4GQ0z9s7M for ; Fri, 20 Apr 2018 18:49:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=dCvIHVlM5sd2TcPAztJGaYclUrBuw08MMi75eG3h2x8=; b=WX5cxFvXV+9wvM+ZvjiJcmkTWE mHSWFL0EARQVBE8JrF4bIUmntlRG4ZijRFQ3grPoUb7V3h8vxPrPqrmxoPU2Rbdp0sgLpW6oTuMQx 6Z3ghs0iwQLJGYbUrNkPbtc/Mi0z85jRcSipBO4ok7xtXPkmzUA6kWB53JtTRZK2QWZc+nXpiKM/n K+5ak8TnGNQZT6v/AYCPaxzAx5NOmuXJilBRd3ic7+vAL4pOC7tFScCGTNKT15TKn/SDTjv4VL6kX Yvofa/5eZHI0r1tAKr9YN3v3NwKKnZphUoyChJhUDNoNCLhu+KJp70AcKS/k+hk//O9jDDpl/3FMF ufDrrdpA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f9Rjk-0006PW-7m; Fri, 20 Apr 2018 08:49:44 +0000 Received: from casper.infradead.org ([85.118.1.10]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f9Rau-00082X-Bf for linux-mtd@bombadil.infradead.org; Fri, 20 Apr 2018 08:40:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eFKva//O8Uus0IEfBmSoX0Ac9A2neDyVi6GxfUFIrPQ=; b=X/c5s/6e47cNNZyPtH9SrOguL OFQREscm+qTe61Lfkjqpotw2w+UssKRm8jfXnFD4Yt/VN+zLM0F6kEj6ncMZ/lYdiUxipaU+JWStw cvOkIOLChEruYVir/muqyQoo5ZoWyylJ/3sdNItAQosSio/np+2pxICxJ95XKB9ywW2G+2UE8MhdE jpU3s5Bv8o5OF0HtLywa1ev5hZG+HZQ6KsVa6iH45+f+gP5lgLiT3HAvFW5TUB5x+g90BMD1rUEAx xbdHy9O30LN9IPuJyv+CZAR3TWDAtFFkXX2LX8geMK0Ah9T8evh8WFKUdbB5LtmYFRYz0wvuDY2b+ 8PC35W+wQ==; Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f9RN2-0001G9-7a for linux-mtd@lists.infradead.org; Fri, 20 Apr 2018 08:26:18 +0000 Received: by mail-wr0-x242.google.com with SMTP id q3-v6so10625372wrj.6 for ; Fri, 20 Apr 2018 01:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=essensium-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eFKva//O8Uus0IEfBmSoX0Ac9A2neDyVi6GxfUFIrPQ=; b=a2/5+fFlITL21MGgwPgDL6pf8CIcwPF671z16YlpbmWj6wudPyK0bD2k2hs5BPYe9N hLHbTZQqunYzShjWYC/N0wEzGNt5A2eYQ3pNPPWn9xBJUpskw/fFn2ibq5ifjEhu5/zm OoVAgsV140R14UC7HYNMRBh3WvYlleb24ojEYHFbEVO1CKvcwX+5hv66E5+kisODOv9E +qCJx9GVNjV8kCWlzenVaFyhBDOjrS8MB4yumBD+0UzJVHKiA4i2FhX0e+hFJB7O95z7 DD7d0oOIYXlEZb1cThBuKu11NXbyjyqUyUqUHNfWACrAoX35BX0mgMghY5RgEfTT85K5 +9cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eFKva//O8Uus0IEfBmSoX0Ac9A2neDyVi6GxfUFIrPQ=; b=q47+2GEAVxf2NiKJ3aGNoMy9x2S6u1izVjrFl8ibRkTl1gKs4XUx7gkEnK+1XA4np7 NVP2QQV3ByTIpGJZ2XfNLXjX6mZXMqwZWq2IQRo9G1PYXYgWDSwf8m0fkJoAV/d14rU9 pPq5adDcxsWblN2kKUZiG52Ei2gnLqvaN01OZ6fum/eKZyHyQivBbEIeBilMYDyuXZ8O sXGeJzfVkh4woUp/OgHUE8fNSYp4GfY5NKX4wnYHk5kzgZTUh8CCeg+GMkYAN5xDvEN7 VkzjqAG5vsm6hK+WFZa2usaqrJk33CJGKd9BcwmTVOfNIElvEpAzOzw0W+QHhU/OztH+ 5aRw== X-Gm-Message-State: ALQs6tD8FeIQzj743SkmxM3QoFHHTbbhmB6C039DtUrfbJGQLB7DsYyn 3475bbkCx0xIm2olQdp0FR4/EAdt X-Google-Smtp-Source: AIpwx4+pMoTzfkaBMibvjp7QlXgHyFYKKFMNddRxeXdWjvsAY7/PLk8W+dN5bNcvCNJdKwnPImJyRQ== X-Received: by 2002:adf:8ac5:: with SMTP id z5-v6mr6893551wrz.22.1524212764206; Fri, 20 Apr 2018 01:26:04 -0700 (PDT) Received: from Darth.local.ess-mail.com (178-118-196-9.access.telenet.be. [178.118.196.9]) by smtp.gmail.com with ESMTPSA id e64sm1834235wmg.22.2018.04.20.01.26.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Apr 2018 01:26:03 -0700 (PDT) From: Sam Lefebvre To: linux-mtd@lists.infradead.org Subject: [PATCH 07/18] mtd: rawnand: gpmi: return generated errors in gpmi_ecc_read_oob() Date: Fri, 20 Apr 2018 10:19:35 +0200 Message-Id: <20180420081946.16088-8-sam.lefebvre@essensium.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180420081946.16088-1-sam.lefebvre@essensium.com> References: <20180420081946.16088-1-sam.lefebvre@essensium.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180420_092616_303131_494F364B X-CRM114-Status: GOOD ( 14.49 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:400c:c0c:0:0:0:242 listed in] [list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Han Xu , Sam Lefebvre MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Errors can be generated by nand_read_page_op(). It's important to check the error flags and pass them upwards. Signed-off-by: Sam Lefebvre --- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c index 7ba00b8ab288..3da4c07ce2d9 100644 --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c @@ -1334,13 +1334,18 @@ static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip, int page) { struct gpmi_nand_data *this = nand_get_controller_data(chip); + int ret; dev_dbg(this->dev, "page number is %d\n", page); /* clear the OOB buffer */ memset(chip->oob_poi, ~0, mtd->oobsize); /* Read out the conventional OOB. */ - nand_read_page_op(chip, page, mtd->writesize, NULL, 0); + ret = nand_read_page_op(chip, page, mtd->writesize, NULL, 0); + + if (ret) + return ret; + chip->read_buf(mtd, chip->oob_poi, mtd->oobsize); /* @@ -1350,11 +1355,11 @@ static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip, */ if (GPMI_IS_MX23(this)) { /* Read the block mark into the first byte of the OOB buffer. */ - nand_read_page_op(chip, page, 0, NULL, 0); + ret = nand_read_page_op(chip, page, 0, NULL, 0); chip->oob_poi[0] = chip->read_byte(mtd); } - return 0; + return ret; } static int