| Message ID | 20180303223946.18636-1-stefan@agner.ch |
|---|---|
| State | Accepted |
| Delegated to: | David Oberhollenzer |
| Headers | show |
| Series | [mtd-utils] mtd: tests: check erase block count in page test | expand |
+David who maintains mtd-utils. On Sat, 3 Mar 2018 23:39:46 +0100 Stefan Agner <stefan@agner.ch> wrote: > When there is only a single erase block, the cross erase test > does not report sensible errors. Warn in case there is only > a single erase block instead of executing the test. > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > tests/mtd-tests/nandpagetest.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tests/mtd-tests/nandpagetest.c b/tests/mtd-tests/nandpagetest.c > index c6812df..115cedb 100644 > --- a/tests/mtd-tests/nandpagetest.c > +++ b/tests/mtd-tests/nandpagetest.c > @@ -551,8 +551,12 @@ int main(int argc, char **argv) > } > printf("verified %u eraseblocks\n", i); > > - if (crosstest()) > - goto out; > + if (ebcnt > 1) { > + if (crosstest()) > + goto out; > + } else { > + printf("skipping erasecrosstest, 2 erase blocks needed\n"); > + } > > if (erasecrosstest()) > goto out;
Applied to mtd-utils.git Thanks, David
On Sat, 3 Mar 2018 23:39:46 +0100 Stefan Agner <stefan@agner.ch> wrote: > When there is only a single erase block, the cross erase test > does not report sensible errors. Warn in case there is only > a single erase block instead of executing the test. Applied. Thanks, Boris > > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > tests/mtd-tests/nandpagetest.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tests/mtd-tests/nandpagetest.c b/tests/mtd-tests/nandpagetest.c > index c6812df..115cedb 100644 > --- a/tests/mtd-tests/nandpagetest.c > +++ b/tests/mtd-tests/nandpagetest.c > @@ -551,8 +551,12 @@ int main(int argc, char **argv) > } > printf("verified %u eraseblocks\n", i); > > - if (crosstest()) > - goto out; > + if (ebcnt > 1) { > + if (crosstest()) > + goto out; > + } else { > + printf("skipping erasecrosstest, 2 erase blocks needed\n"); > + } > > if (erasecrosstest()) > goto out;
diff --git a/tests/mtd-tests/nandpagetest.c b/tests/mtd-tests/nandpagetest.c index c6812df..115cedb 100644 --- a/tests/mtd-tests/nandpagetest.c +++ b/tests/mtd-tests/nandpagetest.c @@ -551,8 +551,12 @@ int main(int argc, char **argv) } printf("verified %u eraseblocks\n", i); - if (crosstest()) - goto out; + if (ebcnt > 1) { + if (crosstest()) + goto out; + } else { + printf("skipping erasecrosstest, 2 erase blocks needed\n"); + } if (erasecrosstest()) goto out;
When there is only a single erase block, the cross erase test does not report sensible errors. Warn in case there is only a single erase block instead of executing the test. Signed-off-by: Stefan Agner <stefan@agner.ch> --- tests/mtd-tests/nandpagetest.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)