diff mbox series

[1/2] mtd: nand: mxc: lower ECC failed message priority to debug level

Message ID 20171016095155.29174-2-s.hauer@pengutronix.de
State Accepted
Delegated to: Boris Brezillon
Headers show
Series [1/2] mtd: nand: mxc: lower ECC failed message priority to debug level | expand

Commit Message

Sascha Hauer Oct. 16, 2017, 9:51 a.m. UTC 
Having bad ECC is a normal case for NAND, do not spam log with the
message. Users like UBI will print a message anyway which is more
useful since it contains the PEB number that has bad ECC.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mtd/nand/mxc_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Oct. 16, 2017, 10:44 a.m. UTC | #1 
Hi Sascha,

On Mon, Oct 16, 2017 at 7:51 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Having bad ECC is a normal case for NAND, do not spam log with the
> message. Users like UBI will print a message anyway which is more
> useful since it contains the PEB number that has bad ECC.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Yes, I also get this spammed log on a mx25pdk:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
diff mbox series

Patch

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 53e5e0337c3e..bec9ec5bbb8c 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -634,7 +634,7 @@  static int mxc_nand_correct_data_v2_v3(struct mtd_info *mtd, u_char *dat,
 	do {
 		err = ecc_stat & ecc_bit_mask;
 		if (err > err_limit) {
-			printk(KERN_WARNING "UnCorrectable RS-ECC Error\n");
+			dev_dbg(host->dev, "UnCorrectable RS-ECC Error\n");
 			return -EBADMSG;
 		} else {
 			ret += err;