From patchwork Tue Aug 8 19:05:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 799406 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DNQMYc6L"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="HueyTkOL"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xRkQG099zz9s7g for ; Wed, 9 Aug 2017 05:06:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Y5KydeuLwMyjin7VtLLWuZn5PYaANE+kYmfe1stPW1Y=; b=DNQ MYc6LGud34AQ1iV9r/0WCKhKleZOuwblB3s/xQ4FNi1QcGVvVVxWQ2C3IJEzM9/k8ZrjjCcYI1bat pezwIYNAI+dldxoNXFxFA7Yp3EXD/kdun6yvuhC/CupZu0yVvWp8CY12R9tNAYD2rUkGQyg+75ojt P98/eXra0gu6jCcDHO6Lq+d7JuRreBMJq2yvH21RD7BaXRnk+RheX4AxEFxvCswHBCdl2m9f9YkQw x7x7xk5gnr+HYMz3DINT1PzFDycqWO5eKUgceJZHtcecB8ovGVitPnPyGmkNF1zaK2UmjVgoj1cF0 YXp618+G9snT6Mbm5QNbrrR4C6OKWPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1df9pP-00053A-J3; Tue, 08 Aug 2017 19:06:07 +0000 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1df9p4-0004mc-Og for linux-mtd@lists.infradead.org; Tue, 08 Aug 2017 19:05:49 +0000 Received: by mail-lf0-x22d.google.com with SMTP id y15so18799534lfd.5 for ; Tue, 08 Aug 2017 12:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=nr2pVVNPgOcnklOSN5rnyA+YeJEP/f249+UeUXDVwy0=; b=HueyTkOLevVPEVf2dbO0Bi5v6pX7e0poNNZXZfpcaI46R4o6PimAs83i3IQRhP0qFS A4pzeHkJT8by/uV4xk24vRUsO6kvx6svtOWBEDo+MX7VVLpa3gszm/l0dhdEaxqo7Qu8 PBXyGOvyi/KUfhN1slvfdLdyGglUpsPV8dLdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nr2pVVNPgOcnklOSN5rnyA+YeJEP/f249+UeUXDVwy0=; b=WDhQxlEqGzkOHJXw9gHeZkvfI0PfzugkfeMaE7nuP6HzL22vfTqUFpQZbOekRuiNTV gs/8DHHyYGcUULGA53jaGJPcv/yz0cL3LkOFuNNSJv7GDU8rtqpNO52R5LfjCwhAJsRH xhhLp48wt/jPIB+u0sTa3MUzd1q/pYpg8lmXPjbexPUqxsV78gVg2IcsOWuXPXWFxI0p Eo+GVsNhF9T1iMh6c/WqPq0GJX1y5gzeIFaDFg/oGhjaI6F+xL934Ox0D2hkhnjupRZo /LhTSQCa6uigHJfgL7n/J8YbyflZiXu3gVTCIuxIi7bkqWAOdjwi60BIJlj2yn1n7C1j Umsg== X-Gm-Message-State: AHYfb5iYNd9pE9yfIKtjKLSNFTyYz1erzg7gbg25c2xW5Ph1MslGX0T4 m2xXXoOuUU7+0mam X-Received: by 10.25.181.74 with SMTP id e71mr1846516lff.100.1502219123705; Tue, 08 Aug 2017 12:05:23 -0700 (PDT) Received: from fabina.bredbandsbolaget.se (c-4b7671d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.118.75]) by smtp.gmail.com with ESMTPSA id y25sm323650lja.49.2017.08.08.12.05.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 12:05:21 -0700 (PDT) From: Linus Walleij To: David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen , linux-mtd@lists.infradead.org Subject: [PATCH] mtd: physmap_of: Retire Gemini pad control Date: Tue, 8 Aug 2017 21:05:10 +0200 Message-Id: <20170808190510.11496-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.9.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170808_120547_015708_E8B035F8 X-CRM114-Status: GOOD ( 11.17 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:4010:c07:0:0:0:22d listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org I wrote a proper pin control driver for the Gemini. Retire this SoC-specific pad control and rely on the pin controller to manage this. Signed-off-by: Linus Walleij Reviewed-by: Marek Vasut --- drivers/mtd/maps/physmap_of_gemini.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/mtd/maps/physmap_of_gemini.c b/drivers/mtd/maps/physmap_of_gemini.c index 05b286b5289f..4ed1a6bb4d3c 100644 --- a/drivers/mtd/maps/physmap_of_gemini.c +++ b/drivers/mtd/maps/physmap_of_gemini.c @@ -43,13 +43,6 @@ #define FLASH_PARALLEL_HIGH_PIN_CNT (1 << 20) /* else low pin cnt */ -/* Miscellaneous Control Register */ -#define GLOBAL_MISC_CTRL 0x30 -#define FLASH_PADS_MASK 0x07 -#define NAND_PADS_DISABLE BIT(2) -#define PFLASH_PADS_DISABLE BIT(1) -#define SFLASH_PADS_DISABLE BIT(0) - static const struct of_device_id syscon_match[] = { { .compatible = "cortina,gemini-syscon" }, { }, @@ -102,15 +95,6 @@ int of_flash_probe_gemini(struct platform_device *pdev, map->bankwidth * 8); } - /* Activate parallel (NOR flash) mode */ - ret = regmap_update_bits(rmap, GLOBAL_MISC_CTRL, - FLASH_PADS_MASK, - SFLASH_PADS_DISABLE | NAND_PADS_DISABLE); - if (ret) { - dev_err(dev, "unable to set up physmap pads\n"); - return -ENODEV; - } - dev_info(&pdev->dev, "initialized Gemini-specific physmap control\n"); return 0;