| Message ID | 20170330215332.32699-2-zajec5@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On 03/30/2017 11:53 PM, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > Support for this property has been introduced in 2010 with commit > 9d5da3a9b849 ("mtd: extend physmap_of to let the device tree specify the > parition probe") but it was never documented. Fix this by adding a > proper description and example. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > Documentation/devicetree/bindings/mtd/common.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/common.txt b/Documentation/devicetree/bindings/mtd/common.txt > index fc068b923d7a..1ada70e718b2 100644 > --- a/Documentation/devicetree/bindings/mtd/common.txt > +++ b/Documentation/devicetree/bindings/mtd/common.txt > @@ -6,10 +6,17 @@ Optional properties: > controller based name) in order to ease flash device identification > and/or describe what they are used for. > > +- linux,part-probe: if present, this property should contain a list of strings > + with partition probes to be used for the flash device. A role of partition > + probe (parser) is to read/construct partition table and register found > + partitions. Getting partition table may be platform or device specific so > + various devices may use various Linux drivers for this purpose. Why don't you just have partition not within partition node ? Then you won't need this nonsense ... > Example: > > flash@0 { > label = "System-firmware"; > + linux,part-probe = "cmdlinepart", "ofpart"; > > /* flash type specific properties */ > }; >
On 03/31/2017 01:26 AM, Marek Vasut wrote: > On 03/30/2017 11:53 PM, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@milecki.pl> >> >> Support for this property has been introduced in 2010 with commit >> 9d5da3a9b849 ("mtd: extend physmap_of to let the device tree specify the >> parition probe") but it was never documented. Fix this by adding a >> proper description and example. >> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl> >> --- >> Documentation/devicetree/bindings/mtd/common.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/common.txt b/Documentation/devicetree/bindings/mtd/common.txt >> index fc068b923d7a..1ada70e718b2 100644 >> --- a/Documentation/devicetree/bindings/mtd/common.txt >> +++ b/Documentation/devicetree/bindings/mtd/common.txt >> @@ -6,10 +6,17 @@ Optional properties: >> controller based name) in order to ease flash device identification >> and/or describe what they are used for. >> >> +- linux,part-probe: if present, this property should contain a list of strings >> + with partition probes to be used for the flash device. A role of partition >> + probe (parser) is to read/construct partition table and register found >> + partitions. Getting partition table may be platform or device specific so >> + various devices may use various Linux drivers for this purpose. > > Why don't you just have partition not within partition node ? Then you > won't need this nonsense ... Can you stop this negative approach ("nonsense") for every single f* thing I submit? It doesn't help and makes people not want to work with upstream mtd. The only partitioner with support for partitions node is "fixed-partitions". Take a look at original linux,part-probe usage: arch/arm64/boot/dts/arm/juno-motherboard.dtsi It's used to specify "afs" partitioner. It's dynamic. You can't replace it with fixed partitions. So this property is needed to specify platform/device specific partitioner that should be used with some standard flash driver (like physmap_of or m25p80). I was hoping following part of documentation makes is clear: > Getting partition table may be platform or device specific so > various devices may use various Linux drivers for this purpose.
diff --git a/Documentation/devicetree/bindings/mtd/common.txt b/Documentation/devicetree/bindings/mtd/common.txt index fc068b923d7a..1ada70e718b2 100644 --- a/Documentation/devicetree/bindings/mtd/common.txt +++ b/Documentation/devicetree/bindings/mtd/common.txt @@ -6,10 +6,17 @@ Optional properties: controller based name) in order to ease flash device identification and/or describe what they are used for. +- linux,part-probe: if present, this property should contain a list of strings + with partition probes to be used for the flash device. A role of partition + probe (parser) is to read/construct partition table and register found + partitions. Getting partition table may be platform or device specific so + various devices may use various Linux drivers for this purpose. + Example: flash@0 { label = "System-firmware"; + linux,part-probe = "cmdlinepart", "ofpart"; /* flash type specific properties */ };