| Message ID | 20170116210039.25267-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Superseded |
| Headers | show |
On 16 January 2017 at 22:00, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > The MR25 family doesn't support JEDEC, so they need explicit mentioning > in the list of supported spi IDs. This makes it possible to add these > using for example: > > compatible = "everspin,mr25h40"; > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Looks OK to me, thanks!
On 01/16/2017 10:00 PM, Uwe Kleine-König wrote: > The MR25 family doesn't support JEDEC, so they need explicit mentioning > in the list of supported spi IDs. This makes it possible to add these > using for example: > > compatible = "everspin,mr25h40"; > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Marek Vasut <marek.vasut@gmail.com> > --- > Changes since (implicit) v1: > - use Kib instead of kib > > drivers/mtd/devices/m25p80.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > index 9cf7fcd28034..aa50bd96de3a 100644 > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { > {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, > {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, > > + /* Everspin MRAMs */ > + { "mr25h256" }, /* 256 Kib, 40 MHz */ > + { "mr25h10" }, /* 1 Mib, 40 MHz */ > + { "mr25h40" }, /* 4 Mib, 40 MHz */ > + > { }, > }; > MODULE_DEVICE_TABLE(spi, m25p_ids); >
Hi, Le 16/01/2017 à 22:00, Uwe Kleine-König a écrit : > The MR25 family doesn't support JEDEC, so they need explicit mentioning > in the list of supported spi IDs. This makes it possible to add these > using for example: > > compatible = "everspin,mr25h40"; > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Changes since (implicit) v1: > - use Kib instead of kib > > drivers/mtd/devices/m25p80.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > index 9cf7fcd28034..aa50bd96de3a 100644 > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { > {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, > {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, > > + /* Everspin MRAMs */ > + { "mr25h256" }, /* 256 Kib, 40 MHz */ There is already a "mr25h256" entry in the m25p_ids[] array. It's a good idea to regroup everspin memories but it might be better to reuse the existing entry. The previous entry is between "at25df321a", ... and "mx25l4005a" so it doesn't appear in your patch. > + { "mr25h10" }, /* 1 Mib, 40 MHz */ > + { "mr25h40" }, /* 4 Mib, 40 MHz */ > + > { }, > }; > MODULE_DEVICE_TABLE(spi, m25p_ids); >
Le 17/01/2017 à 10:48, Cyrille Pitchen a écrit : > Hi, > > Le 16/01/2017 à 22:00, Uwe Kleine-König a écrit : >> The MR25 family doesn't support JEDEC, so they need explicit mentioning >> in the list of supported spi IDs. This makes it possible to add these >> using for example: >> >> compatible = "everspin,mr25h40"; >> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> --- >> Changes since (implicit) v1: >> - use Kib instead of kib >> >> drivers/mtd/devices/m25p80.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c >> index 9cf7fcd28034..aa50bd96de3a 100644 >> --- a/drivers/mtd/devices/m25p80.c >> +++ b/drivers/mtd/devices/m25p80.c >> @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { >> {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, >> {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, >> >> + /* Everspin MRAMs */ >> + { "mr25h256" }, /* 256 Kib, 40 MHz */ > > There is already a "mr25h256" entry in the m25p_ids[] array. > It's a good idea to regroup everspin memories but it might be better to > reuse the existing entry. > > The previous entry is between "at25df321a", ... and "mx25l4005a" so it > doesn't appear in your patch. > >> + { "mr25h10" }, /* 1 Mib, 40 MHz */ >> + { "mr25h40" }, /* 4 Mib, 40 MHz */ >> + Also if you add new entries, I think you should update the "Supported chip names" section in Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt: "mr25h256" is already there. Best regards, Cyrille >> { }, >> }; >> MODULE_DEVICE_TABLE(spi, m25p_ids); >> >
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 9cf7fcd28034..aa50bd96de3a 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, + /* Everspin MRAMs */ + { "mr25h256" }, /* 256 Kib, 40 MHz */ + { "mr25h10" }, /* 1 Mib, 40 MHz */ + { "mr25h40" }, /* 4 Mib, 40 MHz */ + { }, }; MODULE_DEVICE_TABLE(spi, m25p_ids);
The MR25 family doesn't support JEDEC, so they need explicit mentioning in the list of supported spi IDs. This makes it possible to add these using for example: compatible = "everspin,mr25h40"; Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Changes since (implicit) v1: - use Kib instead of kib drivers/mtd/devices/m25p80.c | 5 +++++ 1 file changed, 5 insertions(+)