| Message ID | 20170116133503.13887-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Superseded |
| Headers | show |
On 16 January 2017 at 14:35, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > The MR25 family doesn't support JEDEC, so they need explicit mentioning > in the list of supported spi IDs. This makes it possible to add these > using for example: > > compatible = "everspin,mr25h40"; > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Hello, > > independent of the decision if -nonjedec is ok for m25p, this is needed > to make Everspin's MRAMs work. > > Best regards > Uwe > > drivers/mtd/devices/m25p80.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > --- a/drivers/mtd/devices/m25p80.c > +++ b/drivers/mtd/devices/m25p80.c > @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { > {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, > {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, > > + /* Everspin MRAMs without JEDEC support */ > + { "mr25h256" }, /* 256 kib, 40 MHz */ A trivial thing: I think it should be Kib https://en.wikipedia.org/wiki/Binary_prefix
On 01/16/2017 02:55 PM, Rafał Miłecki wrote: > On 16 January 2017 at 14:35, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: >> The MR25 family doesn't support JEDEC, so they need explicit mentioning >> in the list of supported spi IDs. This makes it possible to add these >> using for example: >> >> compatible = "everspin,mr25h40"; >> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> --- >> Hello, >> >> independent of the decision if -nonjedec is ok for m25p, this is needed >> to make Everspin's MRAMs work. >> >> Best regards >> Uwe >> >> drivers/mtd/devices/m25p80.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c >> --- a/drivers/mtd/devices/m25p80.c >> +++ b/drivers/mtd/devices/m25p80.c >> @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { >> {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, >> {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, >> >> + /* Everspin MRAMs without JEDEC support */ >> + { "mr25h256" }, /* 256 kib, 40 MHz */ > > A trivial thing: I think it should be Kib > https://en.wikipedia.org/wiki/Binary_prefix > Except for that, it looks good IMO.
On Mon, Jan 16, 2017 at 02:55:01PM +0100, Rafał Miłecki wrote: > On 16 January 2017 at 14:35, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > The MR25 family doesn't support JEDEC, so they need explicit mentioning > > in the list of supported spi IDs. This makes it possible to add these > > using for example: > > > > compatible = "everspin,mr25h40"; > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > Hello, > > > > independent of the decision if -nonjedec is ok for m25p, this is needed > > to make Everspin's MRAMs work. > > > > Best regards > > Uwe > > > > drivers/mtd/devices/m25p80.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c > > --- a/drivers/mtd/devices/m25p80.c > > +++ b/drivers/mtd/devices/m25p80.c > > @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { > > {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, > > {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, > > > > + /* Everspin MRAMs without JEDEC support */ > > + { "mr25h256" }, /* 256 kib, 40 MHz */ > > A trivial thing: I think it should be Kib > https://en.wikipedia.org/wiki/Binary_prefix Oh, really? 10^3 = k and 2^10 = Ki, stange. Should I resend for that? Best regards Uwe
On 16 January 2017 at 20:41, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Mon, Jan 16, 2017 at 02:55:01PM +0100, Rafał Miłecki wrote: >> On 16 January 2017 at 14:35, Uwe Kleine-König >> <u.kleine-koenig@pengutronix.de> wrote: >> > The MR25 family doesn't support JEDEC, so they need explicit mentioning >> > in the list of supported spi IDs. This makes it possible to add these >> > using for example: >> > >> > compatible = "everspin,mr25h40"; >> > >> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> > --- >> > Hello, >> > >> > independent of the decision if -nonjedec is ok for m25p, this is needed >> > to make Everspin's MRAMs work. >> > >> > Best regards >> > Uwe >> > >> > drivers/mtd/devices/m25p80.c | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c >> > --- a/drivers/mtd/devices/m25p80.c >> > +++ b/drivers/mtd/devices/m25p80.c >> > @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { >> > {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, >> > {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, >> > >> > + /* Everspin MRAMs without JEDEC support */ >> > + { "mr25h256" }, /* 256 kib, 40 MHz */ >> >> A trivial thing: I think it should be Kib >> https://en.wikipedia.org/wiki/Binary_prefix > > Oh, really? 10^3 = k and 2^10 = Ki, stange. Should I resend for that? I don't think I understand you now. This is 262'144b device. You most likely want to divide it by 1024 and use Kib then, right? So it should be just 256 Kib instead of 256 kib.
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = { {"m25p40-nonjedec"}, {"m25p80-nonjedec"}, {"m25p16-nonjedec"}, {"m25p32-nonjedec"}, {"m25p64-nonjedec"}, {"m25p128-nonjedec"}, + /* Everspin MRAMs without JEDEC support */ + { "mr25h256" }, /* 256 kib, 40 MHz */ + { "mr25h10" }, /* 1 Mib, 40 MHz */ + { "mr25h40" }, /* 4 Mib, 40 MHz */ + { }, }; MODULE_DEVICE_TABLE(spi, m25p_ids);
The MR25 family doesn't support JEDEC, so they need explicit mentioning in the list of supported spi IDs. This makes it possible to add these using for example: compatible = "everspin,mr25h40"; Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, independent of the decision if -nonjedec is ok for m25p, this is needed to make Everspin's MRAMs work. Best regards Uwe drivers/mtd/devices/m25p80.c | 5 +++++ 1 file changed, 5 insertions(+)