diff mbox

mtd: spi-nor: add Macronix mx25u25635f to list of known devices.

Message ID 20161118101203.18992-1-ash.benz@bk.ru
State Superseded
Headers show

Commit Message

Ash Benz Nov. 18, 2016, 10:12 a.m. UTC
Signed-off-by: Ash Benz <ash.benz@bk.ru>
---
 drivers/mtd/spi-nor/spi-nor.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rafał Miłecki Nov. 18, 2016, 11:03 a.m. UTC | #1
On 18 November 2016 at 11:12, Ash Benz <ash.benz@bk.ru> wrote:
> Signed-off-by: Ash Benz <ash.benz@bk.ru>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d0fc165..171adb3 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -872,6 +872,7 @@ static const struct flash_info spi_nor_ids[] = {
>         { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>         { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>         { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
> +       { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
>         { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>         { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
>         { "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },

Please keep this list sorted.

Are you sure this chip doesn't support 4 k sections? Datasheets says:
"Equal Sectors with 4K byte each, or Equal Blocks with 32K byte each
or Equal Blocks with 64K byte each "
Ash Benz Nov. 18, 2016, 11:54 p.m. UTC | #2
Hi Rafał,

I sent a v2 with 4k sect.
Regarding sort, the list is already unsorted, it seems models that are 
very similar are put next to each other.

Regards,
A. Benz

On 11/18/16 19:03, Rafał Miłecki wrote:
> On 18 November 2016 at 11:12, Ash Benz <ash.benz@bk.ru> wrote:
>> Signed-off-by: Ash Benz <ash.benz@bk.ru>
>> ---
>>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index d0fc165..171adb3 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -872,6 +872,7 @@ static const struct flash_info spi_nor_ids[] = {
>>         { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>>         { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>>         { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
>> +       { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
>>         { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
>>         { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
>>         { "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },
>
> Please keep this list sorted.
>
> Are you sure this chip doesn't support 4 k sections? Datasheets says:
> "Equal Sectors with 4K byte each, or Equal Blocks with 32K byte each
> or Equal Blocks with 64K byte each "
>
diff mbox

Patch

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d0fc165..171adb3 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -872,6 +872,7 @@  static const struct flash_info spi_nor_ids[] = {
 	{ "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
 	{ "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
 	{ "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, 0) },
+	{ "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, 0) },
 	{ "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) },
 	{ "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_QUAD_READ) },
 	{ "mx66l1g55g",  INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },