diff mbox

[0704/1285] Replace numeric parameter like 0444 with macro

Message ID 20160802113818.28989-1-baolex.ni@intel.com
State Rejected
Headers show

Commit Message

Baole Ni Aug. 2, 2016, 11:38 a.m. UTC 
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/mtd/nand/pxa3xx_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index 436dd6d..a5896b8 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -283,7 +283,7 @@  struct pxa3xx_nand_info {
 };
 
 static bool use_dma = 1;
-module_param(use_dma, bool, 0444);
+module_param(use_dma, bool, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(use_dma, "enable DMA for data transferring to/from NAND HW");
 
 struct pxa3xx_nand_timing {