From patchwork Fri Feb 12 18:27:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 582269 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id ED33E140BB1 for ; Sat, 13 Feb 2016 05:30:23 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=REze1b28; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aUIS7-00057v-RU; Fri, 12 Feb 2016 18:28:23 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aUIS4-0004vv-Fr for linux-mtd@lists.infradead.org; Fri, 12 Feb 2016 18:28:22 +0000 Received: by mail-pf0-x242.google.com with SMTP id 71so4297542pfv.1 for ; Fri, 12 Feb 2016 10:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=TrbELid7LCVG/oIDXa4HH4jLsxFjhAmJomYcZOHpiX0=; b=REze1b28qpGWY5oB7I0mk6F2+b5Cdq8sl5jGFKfZUaSm6nAmPPwtYUE8GSD1sN7NYq laN4mXSvyAlRjrJZErSGsOXQ6Q+PznR6PElF1I3ZdtmCdsIRTeznAYm3ygp8FlDxXwiM fI94Hg3NKS1sIETmKi5Bd/mctANUJQSwbbyrboYn70DnralJM52kK4DsGdd+vqaWMwjh XGulBPsC6U8csyCq+T8tCbrxVAJlqS44ehurtSveAhHBC9pcnhOKAl8byi38OKz915lb wwl9kJgiBB9F26cKrdjJBJ01x2Ex03UzAUkkLPNgenBS6nrUfEz3Id5Rlfu6bH8uL1SJ ghpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=TrbELid7LCVG/oIDXa4HH4jLsxFjhAmJomYcZOHpiX0=; b=XeSSqyeQ/5BwyW/z5d1zc5FWLvbxiKD9cHjbiTQNPjotc8PgkQo6iL9r19VJlpZwLg srknfkGIxE5nGMYl+on1D9RQ4I1SfCAmyYoPX7rKgiNjqYG969GE7eorD/OlLZwmW3XZ fQ+9DyNW84ZgRfKr6bObx7xHtkOSziu5IiJBnuf6couXHkzcQe/YTfRRxdY7bjLz73fV bdTSKImTlsEGWhuomAriSPPTRrhKEDxBeDMQqJh4XpRdXydAHjYlQEPzLXKmNaFK96GO jMRfp+rbKpTe4OiEHmh+PQQapLvp7CTnnF9zZvxuHtTNfabgMkuf1A2CmON2jgUpYVXq m1mA== X-Gm-Message-State: AG10YORhiDROZw8C7VKmGzEUFJuTgwo1VI7KQqctzAqfvsWeOvwrVW3wbaH51qE2v8jJ+w== X-Received: by 10.98.66.81 with SMTP id p78mr4244923pfa.43.1455301679762; Fri, 12 Feb 2016 10:27:59 -0800 (PST) Received: from google.com ([2620:0:1000:1301:7c71:7f64:5e00:7fed]) by smtp.gmail.com with ESMTPSA id lq10sm21031715pab.36.2016.02.12.10.27.58 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 12 Feb 2016 10:27:59 -0800 (PST) Date: Fri, 12 Feb 2016 10:27:57 -0800 From: Brian Norris To: Romain Izard Subject: Re: [PATCH v4 1/5] mtd: atmel_nand: Support variable RB_EDGE interrupts Message-ID: <20160212182757.GO19540@google.com> References: <1455098187-9442-1-git-send-email-romain.izard.pro@gmail.com> <1455098187-9442-2-git-send-email-romain.izard.pro@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1455098187-9442-2-git-send-email-romain.izard.pro@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160212_102820_744523_DF281B72 X-CRM114-Status: GOOD ( 13.37 ) X-Spam-Score: 1.2 (+) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c00:0:0:0:242 listed in] [list.dnswl.org] 3.9 FSL_HELO_FAKE No description available. -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Boris Brezillon , Josh Wu , Nicolas Ferre , Yang Wenyou , linux-mtd@lists.infradead.org, Rob Herring Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Wed, Feb 10, 2016 at 10:56:23AM +0100, Romain Izard wrote: > The NFC controller used to accelerate the NAND transfers on SAMA5 chips > can use either RB_EDGE0 or RB_EDGE3 as its ready/busy interrupt bit. > > Use the controller's compatible string to select the correct bit. > > For the binding: > Acked-by: Rob Herring > > Reviewed-by: Wenyou Yang > Tested-by: Wenyou Yang > Reviewed-by: Boris Brezillon > Signed-off-by: Romain Izard > --- > v4: collect tested-by and reviewed-by tags > v3: constify atmel_nand_nfc_caps structures > v2: use of_device_get_match_data > rename struct atmel_nand_nfc_priv as atmel_nand_nfc_caps > rename member rb_edge as rb_mask > do not create defines for unused status bits > > .../devicetree/bindings/mtd/atmel-nand.txt | 2 +- > drivers/mtd/nand/atmel_nand.c | 35 +++++++++++++++++----- > drivers/mtd/nand/atmel_nand_nfc.h | 3 +- > 3 files changed, 30 insertions(+), 10 deletions(-) Applied patches 1-4, with the following style diff: diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index aaad1b98dd0d..20cbaabb2959 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -2395,7 +2395,7 @@ static int atmel_nand_nfc_probe(struct platform_device *pdev) nfc->caps = (const struct atmel_nand_nfc_caps *) of_device_get_match_data(&pdev->dev); - if (NULL == nfc->caps) + if (!nfc->caps) return -ENODEV; nfc_writel(nfc->hsmc_regs, IDR, 0xffffffff);