From patchwork Thu Jul 26 02:29:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dong Aisheng X-Patchwork-Id: 173319 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from merlin.infradead.org (unknown [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0ED8D2C0094 for ; Thu, 26 Jul 2012 12:44:32 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SuE29-0006XF-C1; Thu, 26 Jul 2012 02:42:37 +0000 Received: from tx2ehsobe002.messaging.microsoft.com ([65.55.88.12] helo=tx2outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SuE1R-0006Wh-UG; Thu, 26 Jul 2012 02:41:54 +0000 Received: from mail31-tx2-R.bigfish.com (10.9.14.244) by TX2EHSOBE011.bigfish.com (10.9.40.31) with Microsoft SMTP Server id 14.1.225.23; Thu, 26 Jul 2012 02:41:50 +0000 Received: from mail31-tx2 (localhost [127.0.0.1]) by mail31-tx2-R.bigfish.com (Postfix) with ESMTP id C56BFAC01F4; Thu, 26 Jul 2012 02:41:50 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: 0 X-BigFish: VS0(zz98dI9371I1432Izz1202h1082kzz8275bhz2dh2a8h668h839h944hd25hf0ah107ah) Received: from mail31-tx2 (localhost.localdomain [127.0.0.1]) by mail31-tx2 (MessageSwitch) id 1343270507981227_743; Thu, 26 Jul 2012 02:41:47 +0000 (UTC) Received: from TX2EHSMHS043.bigfish.com (unknown [10.9.14.238]) by mail31-tx2.bigfish.com (Postfix) with ESMTP id E4CCF74004C; Thu, 26 Jul 2012 02:41:47 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by TX2EHSMHS043.bigfish.com (10.9.99.143) with Microsoft SMTP Server (TLS) id 14.1.225.23; Thu, 26 Jul 2012 02:41:45 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-002.039d.mgd.msft.net (10.84.1.15) with Microsoft SMTP Server (TLS) id 14.2.298.5; Wed, 25 Jul 2012 21:41:45 -0500 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id q6Q2ffgA020043; Wed, 25 Jul 2012 19:41:42 -0700 Date: Thu, 26 Jul 2012 10:29:30 +0800 From: Dong Aisheng To: Huang Shijie Subject: Re: [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA Message-ID: <20120726022930.GB3396@shlinux2.ap.freescale.net> References: <1343215100-24005-1-git-send-email-festevam@gmail.com> <1343215100-24005-3-git-send-email-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: freescale.com X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [65.55.88.12 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Fabio Estevam , Artem.Bityutskiy@linux.intel.com, b32955@freescale.com, linux-mtd@lists.infradead.org, kernel@pengutronix.de, shawn.guo@linaro.org, Fabio Estevam , dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Thu, Jul 26, 2012 at 10:24:41AM +0800, Huang Shijie wrote: > On Wed, Jul 25, 2012 at 11:23 PM, Fabio Estevam wrote: > > On Wed, Jul 25, 2012 at 12:05 PM, Huang Shijie wrote: > > > >> Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q. > >> this patch makes the kernel built-in the mxs-dma, even the gpmi-nand > >> is not enabled. > > > > Well, as the driver currently stands: yes, it is needed. > > > > Without CONFIG_MXS_DMA, the GPMI driver cannot even be built. > But you have added "depend on MXS_DMA". So If you do not select the > mxs-dma, you can not see the > gpmi-nand. > that's why i think this patch is not needed. > How about using 'select MXS_DMA'? still compiled even GPMI_NAND is not selected. Regards Dong Aisheng diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 31bb7e5..e7c3dcf 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -481,6 +481,7 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) + select MXS_DMA help Then we do not need this patch and does not have the issue that MXS_DMA is