From patchwork Sat Mar 20 08:55:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulius Zaleckas X-Patchwork-Id: 48205 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 30305B7D03 for ; Sat, 20 Mar 2010 19:58:15 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NsuT6-0005RH-14; Sat, 20 Mar 2010 08:55:40 +0000 Received: from mail-fx0-f214.google.com ([209.85.220.214]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NsuSf-0005Qs-UE; Sat, 20 Mar 2010 08:55:18 +0000 Received: by fxm6 with SMTP id 6so253227fxm.2 for ; Sat, 20 Mar 2010 01:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:subject:to:cc:date :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=OUwtMj0++4qyz5Cmut6+sRUXr0LU0zRWHsU7dEPdR+k=; b=Ik+hV/xwf07VyLpTfKx4UYqyiSxSEZQY+h0g0MjduzfTFgCAZTMAgGNU4fYP0CHbcr U5U/e8PwlRlol1gnta7cUh7oPHHqMgfUb0Lvz3979E2lOxDwju7oPwfxKaT9XJ7IhZM4 eIO8M6rb24zcih/+YIFjkhxGw3SyzoBFB5QK0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:subject:to:cc:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; b=bF3fxImjYZoutE+9+owNwgAH/o5qPqS2w++vWA9BnzXEzdDnWM0Z9OrQOxylnL4gHW O0OCxLXsaOSgjiIcGbx71umJTfqfUfeRrmWVVxWKHSf2Dbl1PynPP28gx0IFupYiA1DC eJAJofl04sYsNzvGLp0TIT6+TlTvsos227FeA= Received: by 10.87.63.33 with SMTP id q33mr9601136fgk.24.1269075311267; Sat, 20 Mar 2010 01:55:11 -0700 (PDT) Received: from [127.0.0.1] ([89.249.92.238]) by mx.google.com with ESMTPS id e11sm61832fga.16.2010.03.20.01.55.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 20 Mar 2010 01:55:10 -0700 (PDT) From: Paulius Zaleckas Subject: [PATCH] MTD: Fix Orion NAND driver compilation with ARM OABI To: dwmw2@infradead.org Date: Sat, 20 Mar 2010 10:55:07 +0200 Message-ID: <20100320085507.4038.96426.stgit@pauliusz> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20100320_045514_121122_31A09E28 X-CRM114-Status: GOOD ( 14.87 ) X-Spam-Score: 2.4 (++) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (2.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 DNS_FROM_OPENWHOIS RBL: Envelope sender listed in bl.open-whois.org. Cc: nico@fluxnic.net, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, u.kleine-koenig@pengutronix.de, simon.kagstrom@netinsight.net, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We must tell GCC to use even register for variable passed to ldrd instruction. Without this patch GCC 4.2.1 puts this variable to r2/r3 on EABI and r3/r4 on OABI, so force it to r2/r3. This does not change anything when EABI and OABI compilation works OK. Without this patch and with OABI I get: CC drivers/mtd/nand/orion_nand.o /tmp/ccMkwOCs.s: Assembler messages: /tmp/ccMkwOCs.s:63: Error: first destination register must be even -- `ldrd r3,[ip]' make[5]: *** [drivers/mtd/nand/orion_nand.o] Error 1 Signed-off-by: Paulius Zaleckas --- drivers/mtd/nand/orion_nand.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c index f59c074..cb5175e 100644 --- a/drivers/mtd/nand/orion_nand.c +++ b/drivers/mtd/nand/orion_nand.c @@ -60,7 +60,12 @@ static void orion_nand_read_buf(struct mtd_info *mtd, uint8_t *buf, int len) } buf64 = (uint64_t *)buf; while (i < len/8) { - uint64_t x; + /* + * force x variable to r2/r3 registers since ldrd instruction + * requires first register to be even. + */ + register uint64_t x asm ("r2"); + asm volatile ("ldrd\t%0, [%1]" : "=&r" (x) : "r" (io_base)); buf64[i++] = x; }