From patchwork Wed Dec 17 10:19:24 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 14450 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EF578DDE19 for ; Wed, 17 Dec 2008 21:20:55 +1100 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1LCtV4-0001rn-HT; Wed, 17 Dec 2008 10:19:30 +0000 Received: from www.tglx.de ([62.245.132.106]) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1LCtV2-0001pB-9J for linux-mtd@lists.infradead.org; Wed, 17 Dec 2008 10:19:28 +0000 Received: from www.tglx.de (www.tglx.de [127.0.0.1]) by www.tglx.de (8.13.8/8.13.8/TGLX-2007100201) with ESMTP id mBHAJO6j005482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 17 Dec 2008 11:19:24 +0100 Received: (from bigeasy@localhost) by www.tglx.de (8.13.8/8.13.8/Submit) id mBHAJOve005481 for linux-mtd@lists.infradead.org; Wed, 17 Dec 2008 11:19:24 +0100 Date: Wed, 17 Dec 2008 11:19:24 +0100 From: Sebastian Andrzej Siewior To: linux-mtd@lists.infradead.org Subject: [RFC] remove -W from build process Message-ID: <20081217101924.GB4999@www.tglx.de> Mime-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.4.2.2i X-Key-Id: 97C4700B X-Key-Fingerprint: 09E2 D1F3 9A3A FF13 C3D3 961C 0688 1C1E 97C4 700B X-Virus-Scanned: ClamAV 0.93.2/8770/Wed Dec 17 01:38:25 2008 on www.tglx.de X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED, AWL autolearn=ham version=3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on www.tglx.de X-Spam-Score: 0.0 (/) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org I didn't really figured what exactly goes wrong but if I compile with CFLAGS unset then the compile process goes like this: | gcc -O2 -Werror -Wall -Iinclude -Isrc -I../../include src/ubiupdatevol.c -c -o ubiupdatevol.o Once I set the enviroment CFLAGS to "-g -O2" I also get "-Wall -Wall -Wwrite-strings -W": | gcc -g -O2 -Wall -Wall -Wwrite-strings -W -Werror -Wall -Iinclude -Isrc -I../../include src/ubiupdatevol.c -c -o ubiupdatevol.o |cc1: warnings being treated as errors |src/ubiupdatevol.c: In function 'truncate_volume': |src/ubiupdatevol.c:179: error: comparison between signed and unsigned |src/ubiupdatevol.c:183: error: comparison between signed and unsigned .... and it aborts. I tried to cleanup the signed and unsigned thing but it is a long a way. So I guess it may be the best to just disable -Wextra for now. Signed-off-by: Sebastian Andrzej Siewior --- Would it be possible to use autotools for a clean build environment? ubi-utils/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ubi-utils/Makefile b/ubi-utils/Makefile index 63058e1..67e9f6a 100644 --- a/ubi-utils/Makefile +++ b/ubi-utils/Makefile @@ -10,7 +10,7 @@ INCLUDEDIR=/usr/include CC := $(CROSS)gcc CFLAGS ?= -O2 -g -Werror -CFLAGS += -Wall -Wwrite-strings -W +CFLAGS += -Wall -Wwrite-strings CPPFLAGS += -I./inc -I./src -I$(KERNELHDR) \ -std=gnu99 -DPACKAGE_VERSION=\"1.0\"