From patchwork Fri Nov 14 21:39:53 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 8828 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7D04DDDDF9 for ; Sat, 15 Nov 2008 08:41:54 +1100 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1L16OV-0001Kb-Te; Fri, 14 Nov 2008 21:39:59 +0000 Received: from smtp1.linux-foundation.org ([140.211.169.13]) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1L16OT-0001Bu-Gd; Fri, 14 Nov 2008 21:39:58 +0000 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id mAELdsDf025780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 14 Nov 2008 13:39:55 -0800 Received: from akpm.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id mAELdshx001402; Fri, 14 Nov 2008 13:39:54 -0800 Date: Fri, 14 Nov 2008 13:39:53 -0800 From: Andrew Morton To: Mike Frysinger Subject: Re: [PATCH] mtd: unify mtd partition/device registration Message-Id: <20081114133953.bb65b2ad.akpm@linux-foundation.org> In-Reply-To: <1226533133-7405-1-git-send-email-vapier@gentoo.org> References: <1226533133-7405-1-git-send-email-vapier@gentoo.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 X-Spam-Status: No, hits=-4.509 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED, PATCH_SUBJECT_OSDL, SUBJECT_FUZZY_TION X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 X-Spam-Score: 0.4 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.4 SUBJECT_FUZZY_TION Attempt to obfuscate words in Subject: Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Wed, 12 Nov 2008 18:38:53 -0500 Mike Frysinger wrote: > +int parse_mtd(struct mtd_info *mtd, const char **probe_types, > + struct mtd_partition *parts, int nr_parts) > +{ > +#ifdef CONFIG_MTD_PARTITIONS > + const char *default_part_probe_types[] = { > + "cmdlinepart", > + "RedBoot", > + NULL > + }; > + int ret; > + > + if (!probe_types) > + probe_types = default_part_probe_types; > + > + ret = parse_mtd_partitions(mtd, probe_types, &parts, 0); > + if (ret > 0) { > + ret = add_mtd_partitions(mtd, parts, ret); > + kfree(parts); > + return ret; > + } else if (nr_parts) > + return add_mtd_partitions(mtd, parts, nr_parts); > +#endif > + > + return add_mtd_device(mtd); > +} look: From: Andrew Morton text data bss dec hex filename before: 2488 88 132 2708 a94 drivers/mtd/mtdcore.o after: 2456 100 132 2688 a80 drivers/mtd/mtdcore.o Cc: Atsushi Nemoto Cc: David Woodhouse Cc: Mike Frysinger Signed-off-by: Andrew Morton --- drivers/mtd/mtdcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/mtd/mtdcore.c~mtd-unify-mtd-partition-device-registration-fix drivers/mtd/mtdcore.c --- a/drivers/mtd/mtdcore.c~mtd-unify-mtd-partition-device-registration-fix +++ a/drivers/mtd/mtdcore.c @@ -306,7 +306,7 @@ int parse_mtd(struct mtd_info *mtd, cons struct mtd_partition *parts, int nr_parts) { #ifdef CONFIG_MTD_PARTITIONS - const char *default_part_probe_types[] = { + static const char *default_part_probe_types[] = { "cmdlinepart", "RedBoot", NULL