| Message ID | 1613979342-23572-1-git-send-email-mdalam@codeaurora.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | mtd: rawnand: qcom: Rename parameter name in macro | expand |
Hello, Md Sadre Alam <mdalam@codeaurora.org> wrote on Mon, 22 Feb 2021 13:05:42 +0530: > This change will rename parameter name in macro > nandc_set_read_loc().renamed parameter names are > cw_offset, read_size, is_last_read_loc. > Sinc in QPIC V2 on-wards there is separate location > register to read last code word, so to just differnciate > b/w is_last_read_loc from last_cw this change needed. " Rename the parameters of the nandc_set_read_loc() macro to avoid the confusion between is_last_read_loc which <explain what it is> and <last_cw> which <explain what it is as well>. > > Signed-off-by: Md Sadre Alam <mdalam@codeaurora.org> > --- > drivers/mtd/nand/raw/qcom_nandc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c > index 4189a7f..bfefb4e 100644 > --- a/drivers/mtd/nand/raw/qcom_nandc.c > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > @@ -181,11 +181,11 @@ > #define ECC_BCH_4BIT BIT(2) > #define ECC_BCH_8BIT BIT(3) > > -#define nandc_set_read_loc(nandc, reg, offset, size, is_last) \ > +#define nandc_set_read_loc(nandc, reg, cw_offset, read_size, is_last_read_loc) \ > nandc_set_reg(nandc, NAND_READ_LOCATION_##reg, \ > - ((offset) << READ_LOCATION_OFFSET) | \ > - ((size) << READ_LOCATION_SIZE) | \ > - ((is_last) << READ_LOCATION_LAST)) > + ((cw_offset) << READ_LOCATION_OFFSET) | \ > + ((read_size) << READ_LOCATION_SIZE) | \ > + ((is_last_read_loc) << READ_LOCATION_LAST)) > > /* > * Returns the actual register address for all NAND_DEV_ registers Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 4189a7f..bfefb4e 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -181,11 +181,11 @@ #define ECC_BCH_4BIT BIT(2) #define ECC_BCH_8BIT BIT(3) -#define nandc_set_read_loc(nandc, reg, offset, size, is_last) \ +#define nandc_set_read_loc(nandc, reg, cw_offset, read_size, is_last_read_loc) \ nandc_set_reg(nandc, NAND_READ_LOCATION_##reg, \ - ((offset) << READ_LOCATION_OFFSET) | \ - ((size) << READ_LOCATION_SIZE) | \ - ((is_last) << READ_LOCATION_LAST)) + ((cw_offset) << READ_LOCATION_OFFSET) | \ + ((read_size) << READ_LOCATION_SIZE) | \ + ((is_last_read_loc) << READ_LOCATION_LAST)) /* * Returns the actual register address for all NAND_DEV_ registers
This change will rename parameter name in macro nandc_set_read_loc().renamed parameter names are cw_offset, read_size, is_last_read_loc. Sinc in QPIC V2 on-wards there is separate location register to read last code word, so to just differnciate b/w is_last_read_loc from last_cw this change needed. Signed-off-by: Md Sadre Alam <mdalam@codeaurora.org> --- drivers/mtd/nand/raw/qcom_nandc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)