diff mbox series

[v3] mtd: spi-nor: Add support for s25fs128s1

Message ID 1587546809-3797-1-git-send-email-yangyicong@hisilicon.com
State Accepted
Delegated to: Ambarus Tudor
Headers show
Series [v3] mtd: spi-nor: Add support for s25fs128s1 | expand

Commit Message

Yicong Yang April 22, 2020, 9:13 a.m. UTC
Add support for Cypress s25fs128s1 flash. Previously the flash is
decoded as s25fl129p1 by mistake.

Add it in the flash info list to correctly decode. The flash also
needs a fixup for s25fs-s family. Further capability of the flash will
be parsed from bfpt.

The flash has been tested under SPI/DUAL/QUAD mode on hisi-sfc-v3xx
controller, all the write/read/erase works well.

Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
---
Change since v2:
- correct the flash name as s25fs128s1
- add test information in commit
- add fixup hooks for s25fs-s family. The patch is based on
  Sergei's patch for providing the fixup functions.
Link: https://lore.kernel.org/linux-mtd/191f8894-8392-0d85-62f2-49cfa0285144@cogentembedded.com/

Change since v1:
- rebase the patch on v5.7 rc1

 drivers/mtd/spi-nor/spansion.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Tudor Ambarus May 28, 2020, 8:10 a.m. UTC | #1
On Wednesday, April 22, 2020 12:13:29 PM EEST Yicong Yang wrote:
> Add support for Cypress s25fs128s1 flash. Previously the flash is
> decoded as s25fl129p1 by mistake.
> 
> Add it in the flash info list to correctly decode. The flash also
> needs a fixup for s25fs-s family. Further capability of the flash will
> be parsed from bfpt.
> 
> The flash has been tested under SPI/DUAL/QUAD mode on hisi-sfc-v3xx
> controller, all the write/read/erase works well.
> 
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>

Fixed compilation error, fixed alignment and applied.
diff mbox series

Patch

diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
index eac1c22..8e733c7 100644
--- a/drivers/mtd/spi-nor/spansion.c
+++ b/drivers/mtd/spi-nor/spansion.c
@@ -50,6 +50,9 @@  static const struct flash_info spansion_parts[] = {
 	{ "s25fl512s",  INFO6(0x010220, 0x4d0080, 256 * 1024, 256,
 			      SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			      SPI_NOR_HAS_LOCK | USE_CLSR) },
+	{ "s25fs128s1",  INFO6(0x012018, 0x4d0181, 64 * 1024, 256,
+			SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR),
+	  .fixups = &s25fs_s_fixups, },
 	{ "s25fs512s",  INFO6(0x010220, 0x4d0081, 256 * 1024, 256,
 			      SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR)
 	  .fixups = &s25fs_s_fixups, },