diff mbox series

[v5,2/2] dt-bindings: mtd: Document Macronix NAND device bindings

Message ID 1581922600-25461-3-git-send-email-masonccyang@mxic.com.tw
State Accepted
Headers show
Series mtd: rawnand: Add support for Macronix NAND randomizer | expand

Commit Message

Mason Yang Feb. 17, 2020, 6:56 a.m. UTC
Document the bindings used by the Macronix NAND device.

Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/mtd/nand-macronix.txt      | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/nand-macronix.txt

Comments

Miquel Raynal March 10, 2020, 6:31 p.m. UTC | #1
On Mon, 2020-02-17 at 06:56:40 UTC, Mason Yang wrote:
> Document the bindings used by the Macronix NAND device.
> 
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel
Miquel Raynal March 11, 2020, 7:45 a.m. UTC | #2
Hi Mason,

Mason Yang <masonccyang@mxic.com.tw> wrote on Mon, 17 Feb 2020 14:56:40
+0800:

> Document the bindings used by the Macronix NAND device.
> 
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/mtd/nand-macronix.txt      | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/nand-macronix.txt
> 
> diff --git a/Documentation/devicetree/bindings/mtd/nand-macronix.txt b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
> new file mode 100644
> index 0000000..1d7a895
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
> @@ -0,0 +1,28 @@
> +Macronix NANDs Device Tree Bindings
> +-----------------------------------
> +
> +Macronix NANDs support randomizer operation for user data scrambled,
> +which can be enabled with a SET_FEATURE. The penalty of randomizer are
> +subpage accesses prohibited and more time period is needed in program
> +operation, i.e., tPROG 300us to 340us(randomizer enabled).
> +Randomizer enabled is a one time persistent and non reversible operatoin.
> +
> +For more high-reliability concern, if subpage write not available with
> +hardware ECC and filesystem and then to enable randomizer is recommended
> +by default.
> +
> +By adding a new specific property in children nodes to enable
> +randomizer function.

I also reworded slightly this text when applying.


Thanks,
Miquèl
Mason Yang March 12, 2020, 1:55 a.m. UTC | #3
Hi Miquel,
 
> Mason Yang <masonccyang@mxic.com.tw> wrote on Mon, 17 Feb 2020 14:56:40
> +0800:
> 
> > Document the bindings used by the Macronix NAND device.
> > 
> > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../devicetree/bindings/mtd/nand-macronix.txt      | 28 
++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >  create mode 100644 
Documentation/devicetree/bindings/mtd/nand-macronix.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/nand-macronix.txt 
b/
> Documentation/devicetree/bindings/mtd/nand-macronix.txt
> > new file mode 100644
> > index 0000000..1d7a895
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
> > @@ -0,0 +1,28 @@
> > +Macronix NANDs Device Tree Bindings
> > +-----------------------------------
> > +
> > +Macronix NANDs support randomizer operation for user data scrambled,
> > +which can be enabled with a SET_FEATURE. The penalty of randomizer 
are
> > +subpage accesses prohibited and more time period is needed in program
> > +operation, i.e., tPROG 300us to 340us(randomizer enabled).
> > +Randomizer enabled is a one time persistent and non reversible 
operatoin.
> > +
> > +For more high-reliability concern, if subpage write not available 
with
> > +hardware ECC and filesystem and then to enable randomizer is 
recommended
> > +by default.
> > +
> > +By adding a new specific property in children nodes to enable
> > +randomizer function.
> 
> I also reworded slightly this text when applying.

ok,sure.

> 
> 
> Thanks,
> Miquèl

thanks for your time & review.
Mason

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information 
and/or personal data, which is protected by applicable laws. Please be 
reminded that duplication, disclosure, distribution, or use of this e-mail 
(and/or its attachments) or any part thereof is prohibited. If you receive 
this e-mail in error, please notify us immediately and delete this mail as 
well as its attachment(s) from your system. In addition, please be 
informed that collection, processing, and/or use of personal data is 
prohibited unless expressly permitted by personal data protection laws. 
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mtd/nand-macronix.txt b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
new file mode 100644
index 0000000..1d7a895
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/nand-macronix.txt
@@ -0,0 +1,28 @@ 
+Macronix NANDs Device Tree Bindings
+-----------------------------------
+
+Macronix NANDs support randomizer operation for user data scrambled,
+which can be enabled with a SET_FEATURE. The penalty of randomizer are
+subpage accesses prohibited and more time period is needed in program
+operation, i.e., tPROG 300us to 340us(randomizer enabled).
+Randomizer enabled is a one time persistent and non reversible operatoin.
+
+For more high-reliability concern, if subpage write not available with
+hardware ECC and filesystem and then to enable randomizer is recommended
+by default.
+
+By adding a new specific property in children nodes to enable
+randomizer function.
+
+Required NAND chip properties in children mode:
+- randomizer enable: should be "mxic,enable-randomizer-otp"
+
+Example:
+
+	nand: nand-controller@unit-address {
+
+		nand@0 {
+			reg = <0>;
+			mxic,enable-randomizer-otp;
+		};
+	};