From patchwork Wed Mar 14 15:35:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arushi Singhal X-Patchwork-Id: 885844 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZNcSywBH"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pDCS8bvo"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 401bSp4jHfz9sTy for ; Thu, 15 Mar 2018 02:37:30 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3Racxmnu1Yt3mBt93+xoBTUrTBAKvQ25kdQrluYSQCU=; b=ZNcSywBHVf3DVfWYvdI2+OHjSJ kZQuOOCb7lzDCfQRY2bLHWWtdaSDLelgeCpZDMVUX43h7mUUf2qhx9Ltf+G8mR0pNnOfc5krKk7Bp BcVYX1n2Iebb/Otk/sK78OWNzk2DKLLkqAE9foiodAIyftNi7cx7vIBj88bmIFdD88IhSfNa954Gs qV6poawAYOlh+UsqziXLxjWdYHTycOL5Ig9T8/Y+F35gu5ve7jY2YttI6scsML3dKjLvrpQGXaM7X KwmhdYa3P6IgwQgstuZjcCF/5Yg4S018y3Oh4vpNkHr8L3dC3wShgHd+MjKv7nu9JsznkIK2/F2tg gmHgkHrg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1ew8Sw-0004yq-Cz; Wed, 14 Mar 2018 15:37:22 +0000 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ew8SP-0004VL-0M for linux-mtd@lists.infradead.org; Wed, 14 Mar 2018 15:36:53 +0000 Received: by mail-pg0-x244.google.com with SMTP id x2so1504114pgo.9 for ; Wed, 14 Mar 2018 08:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=T6jbM9RI1Eab6+efwAAEH5DuQOB7uqi7dukIdJ+QpII=; b=pDCS8bvodFE3dnjj73AyLgAdELyHWuhMpxritgASYlg2377sXQl4GAh+tHsIPNH3v5 gUtZcso7QQBuyT5MhSfqErj4wcZkuxW4tOFhJCuPtUHOuHYmsImF94nihVA051E4bI/I JzRFKIXGwAqP7dcfZmX1zipGOKsHmUSTtBOOox6aEj4jEh0/f+oF6tCD/MWKmD2/Q87w K8ZHKj+OleByXrGrLQTuzOqxmxPmfTEjEA7EAT66e76EkjKBmhHKZuvmVES1Ya6hMK/8 QoqytSQjRVpN5o+8omtb4gYaW+zKtZU7zw+0Z9bWTfatY5JGdtuAjT+sfi7dI4iSijDh Q1bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=T6jbM9RI1Eab6+efwAAEH5DuQOB7uqi7dukIdJ+QpII=; b=evkpnXMRSNf+39pBm0nYSJVJEUpKRaxg6RJhxRDdfbMzs1aL6WqwQhN6zNDUvK/3Tv uIr7biq31sToYmoR9yaXJ5Oo0Yn/ruw3wfn0VZZ/1+Vrof4Nm5PAJJeQRz/q0aDMJTsz 9cwQX5xBez+STKnsR3DBaikUlJrHdvZwVCpBwkxpiMZa1schsanLy2rJ0VETronLhcyw /XGoOMD6cyXqaX7bfrzIWf37VkQQ2Ushfjj+2GLn5VmqUIO7eOwl3OQ/opDtY2JFIPAf lGNzmMGfzuADw569kRKP5Ma6tkIViAN6dv1GfX6Y9YxgrDQZqmwGZYe+yRrMvAH3jIkx QcOQ== X-Gm-Message-State: AElRT7Fzc0u+PHj7ZQvehUSOXO1zp/UAszzBT7g99DELziHyGWtl4Fa5 igATMgxvq+03yBfi9swNktE= X-Google-Smtp-Source: AG47ELuWWGw5HlkgOHRPdp89PPVmVW/WsViQuB998wR3H0O87XWip8FRS4BF6zJfYjNb+Z70rOj0ng== X-Received: by 10.101.101.217 with SMTP id y25mr4000851pgv.165.1521041795599; Wed, 14 Mar 2018 08:36:35 -0700 (PDT) Received: from seema-Inspiron-15-3567.iiit.ac.in ([14.139.82.6]) by smtp.googlemail.com with ESMTPSA id k2sm4628535pgo.85.2018.03.14.08.36.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Mar 2018 08:36:34 -0700 (PDT) From: Arushi Singhal To: dwmw2@infradead.org Subject: [PATCH 3/3] mtd: Remove print after allocation failure Date: Wed, 14 Mar 2018 21:05:18 +0530 Message-Id: <1521041718-32492-3-git-send-email-arushisinghal19971997@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1521041718-32492-1-git-send-email-arushisinghal19971997@gmail.com> References: <1521041718-32492-1-git-send-email-arushisinghal19971997@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180314_083649_614624_2338B0E2 X-CRM114-Status: GOOD ( 11.63 ) X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (arushisinghal19971997[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (arushisinghal19971997[at]gmail.com) -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arushi Singhal , boris.brezillon@free-electrons.com, richard@nod.at, linux-kernel@vger.kernel.org, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, cyrille.pitchen@wedev4u.fr, computersforpeace@gmail.com MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The prints after [k|v][m|z|c]alloc() functions are not needed, because in case of failure, allocator will print their internal error prints anyway. Signed-off-by: Arushi Singhal --- drivers/mtd/inftlmount.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/mtd/inftlmount.c b/drivers/mtd/inftlmount.c index 8d6bb189..6b94646 100644 --- a/drivers/mtd/inftlmount.c +++ b/drivers/mtd/inftlmount.c @@ -562,12 +562,8 @@ int INFTL_mount(struct INFTLrecord *s) /* Temporary buffer to store ANAC numbers. */ ANACtable = kcalloc(s->nb_blocks, sizeof(u8), GFP_KERNEL); - if (!ANACtable) { - printk(KERN_WARNING "INFTL: allocation of ANACtable " - "failed (%zd bytes)\n", - s->nb_blocks * sizeof(u8)); + if (!ANACtable) return -ENOMEM; - } /* * First pass is to explore each physical unit, and construct the