From patchwork Fri Sep 1 08:00:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Meng X-Patchwork-Id: 808571 X-Patchwork-Delegate: cyrille.pitchen@atmel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DpaR9Rwl"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N5fpS3a+"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xkBVD2pQ4z9s81 for ; Fri, 1 Sep 2017 17:59:48 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=YGrC35fn53TgYSzdaDntXRv0dZNJ7klBN8vZ9pTb5Ag=; b=DpaR9RwlE2dmKcXnz+o66z5t75 yNvfGPC4Bp2okM5Vu1yEEJn27+1ed6Y54RPJ84z71WDIohdi0nSah/Fv8y1nYjQciME1iXjBZa5vH RU/4HXCkoKhGseiq1Z0ikm7AlF/aB88TkiMaB/4SExIJbcwWGtfmTnmC8IPMmsULge5QZO6oRrlHJ 1GCuEbJa0wk9ve9ppTmt5qRhCAa711xjCGToddyAV4dJAhnTQdB18RiAjl8Z98spAkjhxz7QAPTuY 5S6gA/LnK0I+gSg4U5OECf4dKrWPGE9IHre15Q/lxpLyrYihmUieIj1lUD57lCeYkRCwhRa/COv9U siTw2sog==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dngra-0003s1-0v; Fri, 01 Sep 2017 07:59:38 +0000 Received: from mail-io0-x241.google.com ([2607:f8b0:4001:c06::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dngou-0001Yv-NS for linux-mtd@lists.infradead.org; Fri, 01 Sep 2017 07:56:54 +0000 Received: by mail-io0-x241.google.com with SMTP id 2so2154579ion.3 for ; Fri, 01 Sep 2017 00:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=JK0FEnHe8+L8HPZfr5IHryw6hHRVZc+ZZqW0IzWacfs=; b=N5fpS3a+nqd6sndXXrZ1UzY6KchhfiYnNFBvx3ocbfGyMjQKw3zAhOv0RJGyK+g2h5 rwGexZHSz1qxryUON+IciIWGi0/YSMJVFO7lts1/NcEUri88fKQsDQ9OnzF+9R3nBdON Ej0BB3d8UjeucPwuCqboJse/ld6fY74CXf/8HysCs7RDTdoVA39AZRQvYCMeVdhRq05s a0eo4P+PDTXBmFDBuwNQhCo1SyFzL16INn04ItEvQKietCVQWT59khqDhUU7C8iamurP giniPnyHoetuUZh+4lk0OMTy/UaUuPdmgj172iTRAZfyO7hLRHwuVCcEhM4g7y9dTNAc rV3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=JK0FEnHe8+L8HPZfr5IHryw6hHRVZc+ZZqW0IzWacfs=; b=KPPcc5ywcnznZVr43UIpqbZP9vcCsgJAtXtfR1Iw/Ssel73GVPiEbwPxJDo5jv+egh vPf4ooNf5QsJ12qFfewxCYgWTy8x6auOO1l5s6Nf/orBEFgfQkCNv5ph8NU0BKYj0l37 jaSobrh1F8VTMsy8/vsIxXdHifhB2RttsiMBb5E/AN4C6aqjyfIaouIbTIfxUiACesTk OyBkwXYNUAAHc+QV8QXM9vAhA1uWAU50WE8b5L7DsOlNOOhGE9QjOGmITC4/i3T8yJTL tPqBDcHiH61E5eoXA+Th7d2v6ZEhphP3UQR2wvPRsbo7eERXKyCYEM10wzHgiAcfALF4 9//A== X-Gm-Message-State: AHPjjUiKOZc0ZR2mkVm+sciRWmbaBdG/TW9rHYhy+lvWJ4Ukr3Qv8HEh 5hFBpOJJPO2cIg== X-Google-Smtp-Source: ADKCNb7Dj+28fO8KoZ56F8kCaMy+Uub0SVUfemZe96x1wumE+eYJl8zx2kohvOdpddcjf4gj71xR7w== X-Received: by 10.36.66.148 with SMTP id i142mr654421itb.106.1504252594397; Fri, 01 Sep 2017 00:56:34 -0700 (PDT) Received: from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com. [147.11.156.139]) by smtp.gmail.com with ESMTPSA id d187sm853502iod.7.2017.09.01.00.56.32 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Sep 2017 00:56:33 -0700 (PDT) From: Bin Meng To: Mika Westerberg , Cyrille Pitchen , Marek Vasut , Boris Brezillon , Brian Norris , Richard Weinberger , David Woodhouse , linux-mtd , linux-kernel Subject: [PATCH 08/10] spi-nor: intel-spi: Remove the unnecessary HSFSTS register RW Date: Fri, 1 Sep 2017 01:00:39 -0700 Message-Id: <1504252841-2445-9-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1504252841-2445-1-git-send-email-bmeng.cn@gmail.com> References: <1504252841-2445-1-git-send-email-bmeng.cn@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170901_005652_828682_38021DAA X-CRM114-Status: GOOD ( 10.50 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:4001:c06:0:0:0:241 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (bmeng.cn[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Roese MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org There is no code that alters the HSFSTS register content in between in intel_spi_write(). Remove the unnecessary RW to save some cycles. Signed-off-by: Bin Meng --- drivers/mtd/spi-nor/intel-spi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c index 07146ab..91ceef7 100644 --- a/drivers/mtd/spi-nor/intel-spi.c +++ b/drivers/mtd/spi-nor/intel-spi.c @@ -611,7 +611,6 @@ static ssize_t intel_spi_write(struct spi_nor *nor, loff_t to, size_t len, val |= HSFSTS_CTL_AEL | HSFSTS_CTL_FCERR | HSFSTS_CTL_FDONE; val |= (block_size - 1) << HSFSTS_CTL_FDBC_SHIFT; val |= HSFSTS_CTL_FCYCLE_WRITE; - writel(val, ispi->base + HSFSTS_CTL); ret = intel_spi_write_block(ispi, write_buf, block_size); if (ret) { @@ -620,8 +619,8 @@ static ssize_t intel_spi_write(struct spi_nor *nor, loff_t to, size_t len, } /* Start the write now */ - val = readl(ispi->base + HSFSTS_CTL); - writel(val | HSFSTS_CTL_FGO, ispi->base + HSFSTS_CTL); + val |= HSFSTS_CTL_FGO; + writel(val, ispi->base + HSFSTS_CTL); ret = intel_spi_wait_hw_busy(ispi); if (ret) {