diff mbox

[v5,3/9] mfd: tmio: Add partition parsers platform data

Message ID 1502743720-28672-4-git-send-email-andrea.adami@gmail.com
State Accepted
Delegated to: Boris Brezillon
Headers show

Commit Message

Andrea Adami Aug. 14, 2017, 8:48 p.m. UTC
With the introduction of sharpslpart partition parser we can now read the
offsets from NAND: we specify the list of the parsers as platform data, with
cmdlinepart and ofpart parsers first allowing to override the part. table
written in NAND. This is done in the board files using this driver.

Thus, we need to extend tmio_nand_data to consider the partition parsers.

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 include/linux/mfd/tmio.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Lee Jones Aug. 15, 2017, 6:58 a.m. UTC | #1
On Mon, 14 Aug 2017, Andrea Adami wrote:

> With the introduction of sharpslpart partition parser we can now read the
> offsets from NAND: we specify the list of the parsers as platform data, with
> cmdlinepart and ofpart parsers first allowing to override the part. table
> written in NAND. This is done in the board files using this driver.
> 
> Thus, we need to extend tmio_nand_data to consider the partition parsers.
> 
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
>  include/linux/mfd/tmio.h | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Lee Jones <lee.jones@linaro.org>
Boris Brezillon Aug. 19, 2017, 7:26 a.m. UTC | #2
Hi Lee,

Le Tue, 15 Aug 2017 07:58:35 +0100,
Lee Jones <lee.jones@linaro.org> a écrit :

> On Mon, 14 Aug 2017, Andrea Adami wrote:
> 
> > With the introduction of sharpslpart partition parser we can now read the
> > offsets from NAND: we specify the list of the parsers as platform data, with
> > cmdlinepart and ofpart parsers first allowing to override the part. table
> > written in NAND. This is done in the board files using this driver.
> > 
> > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > 
> > Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > ---
> >  include/linux/mfd/tmio.h | 1 +
> >  1 file changed, 1 insertion(+)  
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>
> 

I'm about to apply patches 1 to 5 of this series to the nand/next
branch. Do you want me to create an immutable branch with this patch?

Regards,

Boris
Wolfram Sang Aug. 19, 2017, 8:23 a.m. UTC | #3
On Mon, Aug 14, 2017 at 10:48:34PM +0200, Andrea Adami wrote:
> With the introduction of sharpslpart partition parser we can now read the
> offsets from NAND: we specify the list of the parsers as platform data, with
> cmdlinepart and ofpart parsers first allowing to override the part. table
> written in NAND. This is done in the board files using this driver.
> 
> Thus, we need to extend tmio_nand_data to consider the partition parsers.
> 
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Boris Brezillon Aug. 19, 2017, 9:21 a.m. UTC | #4
Le Sat, 19 Aug 2017 09:26:03 +0200,
Boris Brezillon <boris.brezillon@free-electrons.com> a écrit :

> Hi Lee,
> 
> Le Tue, 15 Aug 2017 07:58:35 +0100,
> Lee Jones <lee.jones@linaro.org> a écrit :
> 
> > On Mon, 14 Aug 2017, Andrea Adami wrote:
> >   
> > > With the introduction of sharpslpart partition parser we can now read the
> > > offsets from NAND: we specify the list of the parsers as platform data, with
> > > cmdlinepart and ofpart parsers first allowing to override the part. table
> > > written in NAND. This is done in the board files using this driver.
> > > 
> > > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > > 
> > > Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > > ---
> > >  include/linux/mfd/tmio.h | 1 +
> > >  1 file changed, 1 insertion(+)    
> > 
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >   
> 
> I'm about to apply patches 1 to 5 of this series to the nand/next

I meant patches 2 to 5, patch 1 still requires a few adjustments.

> branch. Do you want me to create an immutable branch with this patch?
> 
> Regards,
> 
> Boris
Lee Jones Aug. 21, 2017, 7:27 a.m. UTC | #5
On Sat, 19 Aug 2017, Boris Brezillon wrote:

> Hi Lee,
> 
> Le Tue, 15 Aug 2017 07:58:35 +0100,
> Lee Jones <lee.jones@linaro.org> a écrit :
> 
> > On Mon, 14 Aug 2017, Andrea Adami wrote:
> > 
> > > With the introduction of sharpslpart partition parser we can now read the
> > > offsets from NAND: we specify the list of the parsers as platform data, with
> > > cmdlinepart and ofpart parsers first allowing to override the part. table
> > > written in NAND. This is done in the board files using this driver.
> > > 
> > > Thus, we need to extend tmio_nand_data to consider the partition parsers.
> > > 
> > > Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > > ---
> > >  include/linux/mfd/tmio.h | 1 +
> > >  1 file changed, 1 insertion(+)  
> > 
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> > 
> 
> I'm about to apply patches 1 to 5 of this series to the nand/next
> branch. Do you want me to create an immutable branch with this patch?

No, not for a single line change.  Git should figure that out.

Thanks for asking though.
diff mbox

Patch

diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
index 26e8f8c..357b6cfd 100644
--- a/include/linux/mfd/tmio.h
+++ b/include/linux/mfd/tmio.h
@@ -139,6 +139,7 @@  struct tmio_nand_data {
 	struct nand_bbt_descr	*badblock_pattern;
 	struct mtd_partition	*partition;
 	unsigned int		num_partitions;
+	const char *const	*part_parsers;
 };
 
 #define FBIO_TMIO_ACC_WRITE	0x7C639300