From patchwork Tue Aug 1 11:40:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 796196 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i6sH6S2B"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="a5DBsJ1g"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="F6CAvqv0"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xMF222bXRz9sR9 for ; Tue, 1 Aug 2017 21:48:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=JHMUlFVh1KZMMfHuGrSNMjmJaLSgAeEH2CEHc5oSCpM=; b=i6s H6S2B9r88C0B3KU5AQpYUoldlbOd1VvMu1viToi13lspToqsqQQ95644wO1aUrvnwG0KvyGWlkrg9 QavorF3ypTQgPZ76p+bzoFvsbm8DKZE8QW/Gi9jWY7OQDDTfb5HOM3nWWjJrHDckqchLh9kwjTCrY WOVlRebMnIgRt2uEd+ZVgXhBry/rh5mBw5DdsotBgGRNd2hu4MyF+ywti3Y6cRKAj7XVXNTNK3hQs tEYF9SEq1KlCxCDPWIA89c1+i5gDYT6/0r5vVFehSRcAenWOv6CIQi9jWFZf8JXSDM/YTiJzyd8Zt COjiaohNAsfMvc2tAVTlRLoZ+3wCQEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dcVea-0000qo-V5; Tue, 01 Aug 2017 11:48:00 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dcVeZ-0000nY-8X; Tue, 01 Aug 2017 11:47:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=irbhwkvUfclRSe73G5V4okWoKm0wLf+vSSbKSHjb0po=; b=a5DBsJ1g6c3QU9D121UpPnMeT 3+dN15WlWW13Te5qFYW88F0ghRTXe+A5w22QRPQbeKyAyFjSrMeCAEimZBfqXePZbiebSbLj4IuBN Bl+MhKzR/Qyqc7TN9xovbDKd82Z4Ef/966g81CUy3rNMThlKyFT4OO7LulOpFQB1INryyx0Fo/SAV f14hgb07jlrAZvJtWAlf9zxTo1hYPStqznuyr0j7LKtGdkb6t7+X5SE/q3icD+VTB9hTZQApHKnLQ I1243TraiZRebcHdswfvWO2HtdNzAUDzNidXhhVZf3DnM/JYy+t9pfv0IYGnLl1/GLtF3sW89sNRA hXfONbuYg==; Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dcVXc-00055A-QO; Tue, 01 Aug 2017 11:40:50 +0000 Received: by mail-pg0-x244.google.com with SMTP id 123so519496pga.5; Tue, 01 Aug 2017 04:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=irbhwkvUfclRSe73G5V4okWoKm0wLf+vSSbKSHjb0po=; b=F6CAvqv0XPuVAF4zpIwg9jbjcoKHHUlxt9WgdHd33Ul141G/hhEhARqLFtDoWmzO3Y eXeW4/eEhTUENEAhty1yAMRY20um2AsnOMvk2pi7tiWQmEPxPcM3cy+qAccdJ+tLnqdS 5UHecsPoZ/DAkGUdoygWruP7q6P7itpuD8FlCQWKiE6PjPLKjQtcY/4tNPE1Cb4uBBoE MakF1u65T7QraDKZcowd8FAO2/aOEYuVHkxbdSfdpZro73xIo5ebZ5B+0BJrmJBZd54+ qLQhjWjDceAmPhf3CevrHfGFSIqFQcK9fJcTe9lFdDvsTzHK6OmZzSz6bb4BZcVNbFPm fZOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=irbhwkvUfclRSe73G5V4okWoKm0wLf+vSSbKSHjb0po=; b=SvewxEkewGD84dntKNLjeUPIlHADBBjedLjqWMUZr72kw78Mhj3MV6kfdWF+pPgmdz 5sBZqX4UbJy3ygwenLQMqC9Ys8ZMQGKCWBGFG1jPX1ARomcG6OZRa3G+Uf8p9hh4w6Ro JIVO6UAfqGUoGwoJkkVawDYBGWqWWy71izFl/B/+CdVi1gdUNHsYukmu5JFCYzQo1hN7 N3lyTwFuMnoOcGzy+0qB+a93oYl+ipIvcg4ZSmWeqVHux0hTQ3RPY0aiOqeMs06RQmbj FpdmL3dLJS5mR3mOZLXEkILjHYGB8vuJfRS3W8EMOpMBiJLBNdIP4VdEszGym7bZu6Sh WxLw== X-Gm-Message-State: AIVw111F2ck33bSjPSYOhIa6eH/6fJaSsMH+deNYK9oYiXqKAl3P5ZFE W2SZC0VQo71Olw== X-Received: by 10.84.232.79 with SMTP id f15mr20950389pln.172.1501587627306; Tue, 01 Aug 2017 04:40:27 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id c7sm52620488pfa.174.2017.08.01.04.40.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Aug 2017 04:40:26 -0700 (PDT) From: Arvind Yadav To: boris.brezillon@free-electrons.com, richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, narmstrong@baylibre.com, vz@mleia.com Subject: [PATCH 5/6] mtd: nand: lpc32xx_mlc: Handle return value of clk_prepare_enable. Date: Tue, 1 Aug 2017 17:10:11 +0530 Message-Id: <1501587611-21289-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170801_124049_064670_CB57753B X-CRM114-Status: GOOD ( 11.65 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-2.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (arvind.yadav.cs[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/mtd/nand/lpc32xx_mlc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c index 846a66c..91ee3696 100644 --- a/drivers/mtd/nand/lpc32xx_mlc.c +++ b/drivers/mtd/nand/lpc32xx_mlc.c @@ -705,7 +705,9 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) res = -ENOENT; goto err_exit1; } - clk_prepare_enable(host->clk); + res = clk_prepare_enable(host->clk); + if (res) + goto err_exit1; nand_chip->cmd_ctrl = lpc32xx_nand_cmd_ctrl; nand_chip->dev_ready = lpc32xx_nand_device_ready; @@ -846,9 +848,12 @@ static int lpc32xx_nand_remove(struct platform_device *pdev) static int lpc32xx_nand_resume(struct platform_device *pdev) { struct lpc32xx_nand_host *host = platform_get_drvdata(pdev); + int ret; /* Re-enable NAND clock */ - clk_prepare_enable(host->clk); + ret = clk_prepare_enable(host->clk); + if (ret) + return ret; /* Fresh init of NAND controller */ lpc32xx_nand_setup(host);