From patchwork Tue Aug 1 11:38:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 796189 X-Patchwork-Delegate: boris.brezillon@free-electrons.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XrvelbDr"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bj6ZeNZ/"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xMDrH0T16z9tWN for ; Tue, 1 Aug 2017 21:39:43 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Uk5aIKVshxuU0a3MaEHOhrc4DMHL46Thj3m73/WQgSs=; b=Xrv elbDrLVtGvzZ3hsXxGlSbGiTpnTVITM1OHBoADkcEqn8/Nnlfm05KQwIi1dTxX8kWbfOwEo05icSF mqy0mS6bzXapbZbtMjNFMLYrydZTn5ieZT75m47Zw9HpAbaHfqSaRKD+oC+242RTX7Ikh/HTtsxCw RNyMF6MSi/t3bUvdHGTr/OkXHYITrApdXZh4ZELqTKrXeCmhuGMeoajMHsgQi40wnvEKttBIDb/vm op4JaJttXv/MHyohFdR5aIMta2tySibhxqRwTCoPA+UggFv5E4AaJ9aUXiZFz86SnSLH+fEemd86q e6R6EvkyZ7z+Sovarml3/DE9MROlWNA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dcVWV-0004cp-VB; Tue, 01 Aug 2017 11:39:39 +0000 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dcVVW-0003QR-FB; Tue, 01 Aug 2017 11:39:37 +0000 Received: by mail-pg0-x244.google.com with SMTP id y192so2305775pgd.1; Tue, 01 Aug 2017 04:38:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ZrcsSUBmsd+x4vjSKaRpZojMHOSCo9fn3gwpJBHpDOI=; b=bj6ZeNZ/qMBPKZ+nDh+JQFMZMLF046lKFaXIMyaPATgPtLaWbLOmQs7rREdLxWXzRY V/17Eo6NDA87iDciK6aKEhQcfoUcCHoELll7OuyTnkB7AbJRlRD7EUZ9bnboXH7DDwDO MsT3A7si00/hGT9oGcJ6K5k+Z3s9G3O6lu/CfQQUnNaBxx00aeW3PG3SrYa4VlCbOaWU p8qbqPkO2sZggl6NI3PTNvsiyJgn/OFP/oolaMICisCJEALlM0nd69FWiFg83Cqa3nH0 h68RCJjOt9MaLFBKeK8RQpwJpq3I8/mW8ia8Xkfm9Vf1SA0X75Kjk01m015oPS8RUyOv BAjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZrcsSUBmsd+x4vjSKaRpZojMHOSCo9fn3gwpJBHpDOI=; b=HtBpfcX/o/TuxWybVB46Nq7+pkTFCQyErYQ3F9NICLwpp39VSRRcaiKKYikWZGYcr5 bbgkr3NXDaOazK1ArG3xEDwv161wbsL7MODRq7HCZ20+NyJNTJsTNavNbc0Q4SDy+qkq H0ELFhW/4P5rL+bwPw8S36exuZFNbbMMnqJmc4fCBCwfOujXmOalX64Py6Zxj0byLE8x w9fa1ROBUmUQMuXzsKXtBr7OhRmkpwNypYEmXYW+bxRCvnmQWapZ4y4cVoC9Vu55gT/E L9bTkBcGjDc0b/eXica91nJlF9DOVP+yOZSnZhG4QhL3N2FdYQ5mm7xvE9p9GFkBe/mP ddwQ== X-Gm-Message-State: AIVw111MpVxc41pRdXuTi8rO/sHiBvCbH4IwdltokFArIeVcUDYgQWed 4TdXI2BFwqZhvw== X-Received: by 10.99.8.135 with SMTP id 129mr18869019pgi.273.1501587502651; Tue, 01 Aug 2017 04:38:22 -0700 (PDT) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id x126sm34416175pfb.179.2017.08.01.04.38.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Aug 2017 04:38:22 -0700 (PDT) From: Arvind Yadav To: boris.brezillon@free-electrons.com, richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, cyrille.pitchen@wedev4u.fr, narmstrong@baylibre.com, slemieux.tyco@gmail.com Subject: [PATCH 3/6] mtd: nand: lpc32xx_slc: Handle return value of clk_prepare_enable. Date: Tue, 1 Aug 2017 17:08:06 +0530 Message-Id: <1501587486-21184-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170801_043839_173052_7344E3D7 X-CRM114-Status: GOOD ( 10.82 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (arvind.yadav.cs[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/mtd/nand/lpc32xx_slc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c index a0669a3..80c2829 100644 --- a/drivers/mtd/nand/lpc32xx_slc.c +++ b/drivers/mtd/nand/lpc32xx_slc.c @@ -840,7 +840,9 @@ static int lpc32xx_nand_probe(struct platform_device *pdev) res = -ENOENT; goto err_exit1; } - clk_prepare_enable(host->clk); + res = clk_prepare_enable(host->clk); + if (res) + goto err_exit1; /* Set NAND IO addresses and command/ready functions */ chip->IO_ADDR_R = SLC_DATA(host->io_base); @@ -972,9 +974,12 @@ static int lpc32xx_nand_remove(struct platform_device *pdev) static int lpc32xx_nand_resume(struct platform_device *pdev) { struct lpc32xx_nand_host *host = platform_get_drvdata(pdev); + int ret; /* Re-enable NAND clock */ - clk_prepare_enable(host->clk); + ret = clk_prepare_enable(host->clk); + if (ret) + return ret; /* Fresh init of NAND controller */ lpc32xx_nand_setup(host);