| Message ID | 1500149266-32357-4-git-send-email-Julia.Lawall@lip6.fr |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
Le Sat, 15 Jul 2017 22:07:38 +0200, Julia Lawall <Julia.Lawall@lip6.fr> a écrit : > Drop static on a local variable, when the variable is initialized before > any possible use. Thus, the static has no benefit. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @bad exists@ > position p; > identifier x; > type T; > @@ > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > -static > T x@p; > ... when != x > when strict > ?x = e; > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > --- > These patches are all independent of each other. > > drivers/mtd/maps/physmap_of_versatile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/drivers/mtd/maps/physmap_of_versatile.c b/drivers/mtd/maps/physmap_of_versatile.c > --- a/drivers/mtd/maps/physmap_of_versatile.c > +++ b/drivers/mtd/maps/physmap_of_versatile.c > @@ -97,7 +97,7 @@ static const struct of_device_id ebi_mat > static int ap_flash_init(struct platform_device *pdev) > { > struct device_node *ebi; > - static void __iomem *ebi_base; > + void __iomem *ebi_base; > u32 val; > int ret; > >
Le Sat, 15 Jul 2017 22:07:38 +0200, Julia Lawall <Julia.Lawall@lip6.fr> a écrit : > Drop static on a local variable, when the variable is initialized before > any possible use. Thus, the static has no benefit. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @bad exists@ > position p; > identifier x; > type T; > @@ > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > -static > T x@p; > ... when != x > when strict > ?x = e; > // </smpl> > Applied to l2-mtd/master. Thanks, Boris > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > These patches are all independent of each other. > > drivers/mtd/maps/physmap_of_versatile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/drivers/mtd/maps/physmap_of_versatile.c b/drivers/mtd/maps/physmap_of_versatile.c > --- a/drivers/mtd/maps/physmap_of_versatile.c > +++ b/drivers/mtd/maps/physmap_of_versatile.c > @@ -97,7 +97,7 @@ static const struct of_device_id ebi_mat > static int ap_flash_init(struct platform_device *pdev) > { > struct device_node *ebi; > - static void __iomem *ebi_base; > + void __iomem *ebi_base; > u32 val; > int ret; > >
diff -u -p a/drivers/mtd/maps/physmap_of_versatile.c b/drivers/mtd/maps/physmap_of_versatile.c --- a/drivers/mtd/maps/physmap_of_versatile.c +++ b/drivers/mtd/maps/physmap_of_versatile.c @@ -97,7 +97,7 @@ static const struct of_device_id ebi_mat static int ap_flash_init(struct platform_device *pdev) { struct device_node *ebi; - static void __iomem *ebi_base; + void __iomem *ebi_base; u32 val; int ret;
Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- These patches are all independent of each other. drivers/mtd/maps/physmap_of_versatile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)