diff mbox

[v3,4/9] mtd: nand: sharpsl.c: take in account partition parser types

Message ID 1496270458-6479-5-git-send-email-andrea.adami@gmail.com
State Superseded
Headers show

Commit Message

Andrea Adami May 31, 2017, 10:40 p.m. UTC 
Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 drivers/mtd/nand/sharpsl.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Wolfram Sang June 1, 2017, 8:35 a.m. UTC | #1 
> +					data->types ? data->types : NULL,

This is equal to just 'data_types'.

> +					NULL,
> +					data->partitions ?
> +					data->partitions : NULL,
> +					data->nr_partitions ?
> +					data->nr_partitions : 0);

All the ternary operators are superfluous.
diff mbox

Patch

diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c
index 064ca17..1a76779 100644
--- a/drivers/mtd/nand/sharpsl.c
+++ b/drivers/mtd/nand/sharpsl.c
@@ -183,8 +183,13 @@  static int sharpsl_nand_probe(struct platform_device *pdev)
 	/* Register the partitions */
 	mtd->name = "sharpsl-nand";
 
-	err = mtd_device_parse_register(mtd, NULL, NULL,
-					data->partitions, data->nr_partitions);
+	err = mtd_device_parse_register(&sharpsl->mtd,
+					data->types ? data->types : NULL,
+					NULL,
+					data->partitions ?
+					data->partitions : NULL,
+					data->nr_partitions ?
+					data->nr_partitions : 0);
 	if (err)
 		goto err_add;