From patchwork Fri Jan 27 11:29:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shailendra Verma X-Patchwork-Id: 720639 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v8xR759FGz9tJD for ; Fri, 27 Jan 2017 22:30:11 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cX4jJ-0008IA-SC; Fri, 27 Jan 2017 11:30:09 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cX4iv-0008EG-5p for linux-mtd@lists.infradead.org; Fri, 27 Jan 2017 11:29:47 +0000 Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OKF02SNNRWYR420@mailout2.samsung.com> for linux-mtd@lists.infradead.org; Fri, 27 Jan 2017 20:29:22 +0900 (KST) Received: from epsmges1p4.samsung.com (unknown [182.195.42.56]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20170127112921epcas1p1764dafb008a80a3c98d51e46c33cf64d~dnXEyd9Of1427814278epcas1p1-; Fri, 27 Jan 2017 11:29:21 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id 5B.04.06769.11F2B885; Fri, 27 Jan 2017 20:29:21 +0900 (KST) Received: from epsmgmsp01.samsung.com (unknown [182.195.34.22]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20170127112921epcas1p45999b22222202e8d98b6aecfc3cbeb39~dnXEirzCt2254122541epcas1p4O; Fri, 27 Jan 2017 11:29:21 +0000 (GMT) X-AuditID: b6c32a38-f79e26d000001a71-da-588b2f11c6ff Received: from srin.p4 (Unknown_Domain [107.108.168.37]) by epsmgmsp01.samsung.com (EPCPMTA) with SMTP id 4B.6D.04803.E0F2B885; Fri, 27 Jan 2017 20:29:21 +0900 (KST) From: Shailendra Verma To: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Mtd: nand - Fix possible NULL derefrence. Date: Fri, 27 Jan 2017 16:59:13 +0530 Message-id: <1485516553-4438-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsWy7bCmnq6gfneEwYpGZYv7076xWxx4sZDF 4siFtcwW976fZ7aYuHIys8XlXXPYLHY3LWO3OLrnHrPFjimtLBaTd75htLg1byabxaJvr5gd eDwW/NrK4vFk00VGj52z7rJ7bF6h5bF5Sb3HzXmFHn1bVjF6fN4kF8ARxWWTkpqTWZZapG+X wJUx9/o89oL/nBVvrn5namBczdHFyMEhIWAiceADfxcjJ5ApJnHh3nq2LkYuDiGBHYwSP37e ZgZJCAl8ZpS4/zUfoshEYtfLTcwQRSsZJQ7unMYGkmATMJR43feXCSQhInCXWeLG6/1MIAlh ASuJ811bGUFsFgFViRvTr4JN5RVwl5j4ey4rxBUKEnMm2YD0Sgh8Z5NYteYrE0RcVmLTAWaI xS4S+94fYYSwhSVeHd/CDmFLSTR//MAK0XuMUeLx88VMEM5lRoktp5dBVdlLXLv1GsxmFuCT ePe1B2oxr0RHmxBEiYfEov3LGSHCjhK7tvpDPB8r0ba1h2UCo+QCRoZVjGKpBcW56anFhgUm esWJucWleel6yfm5mxjBEaxlsYNxzzmfQ4wCHIxKPLwR8l0RQqyJZcWVuYcYJTiYlUR4N+p2 RwjxpiRWVqUW5ccXleakFh9ilOZgURLnXdxoHSEkkJ5YkpqdmlqQWgSTZeLglGpgPP6pNG3L /nD+nW16SyOtYmY27latP/Nw24b++pP8qbdsjGv4l28wSIzgcDBKbtP2ebHZk1H4dcqSw3fZ 242YT85TCZCo4bXUmpBltmbdxQdd807eCr5xzvTHNAdPaUb5t2EqW3iC9iz/8cP+0oVZHzMF bzU4Wh6Y7KPmatVeYSydxvLsxottSizFGYmGWsxFxYkAZpojRtwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsWSnbNCVVdQvzvC4Ms2IYv7076xWxx4sZDF 4siFtcwW976fZ7aYuHIys8XlXXPYLHY3LWO3OLrnHrPFjimtLBaTd75htLg1byabxaJvr5gd eDwW/NrK4vFk00VGj52z7rJ7bF6h5bF5Sb3HzXmFHn1bVjF6fN4kF8AR5WaTkZqYklqkkJqX nJ+SmZduqxQa4qZroaSQl5ibaqsUoesbEqSkUJaYUwrkGRmgAQfnAPdgJX27BLeMudfnsRf8 56x4c/U7UwPjao4uRk4OCQETiV0vNzFD2GISF+6tZwOxhQSWM0q8P2MJYrMJGEq87vvL1MXI xSEi8JxZYsKfm4wgCWEBK4nzXVvBbBYBVYkb06+CDeIVcJeY+HsuaxcjB9BQBYk5k2wmMHIu YGRYxSiWWlCcm55bXGBgqFecmFtcmpeul5yfu4kRGLbbDiuJ7WBsW+F1iFGAg1GJhzeBvTtC iDWxrLgy9xCjBAezkgjvRl2gEG9KYmVValF+fFFpTmrxIUZToO0TmaVEk/OBMZVXEm9oYmph YWFiaWxsbGGiJM4bO/1ZuJBAemJJanZqakFqEUwfEwenVAPj/Lth1Wt71uY23w9erlzObLdH 5tfrvNsd+bePRN1jzVuee2dZhiPj3McKO7UXxv+8NNHw896VPJ85MtyV315U9p6YYXZbK0kx 8o+J5/ZtrpGup78Xau+58kLPpk/KUFJL8cHx5tyIpnfbdusZHtU9WaTxR16byVrX6Uflz+wb 2eqKj+v1GYSUWIozEg21mIuKEwFbbQpFcQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170127112921epcas1p45999b22222202e8d98b6aecfc3cbeb39 X-Msg-Generator: CA X-Sender-IP: 182.195.34.22 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170127112921epcas1p45999b22222202e8d98b6aecfc3cbeb39 X-RootMTR: 20170127112921epcas1p45999b22222202e8d98b6aecfc3cbeb39 References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170127_032945_379543_A47B3D98 X-CRM114-Status: UNSURE ( 8.86 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -10.1 (----------) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-10.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -3.2 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/mtd/nand/mxc_nand.c | 4 ++++ drivers/mtd/nand/vf610_nfc.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c index d7f724b..ca1b8ad 100644 --- a/drivers/mtd/nand/mxc_nand.c +++ b/drivers/mtd/nand/mxc_nand.c @@ -1596,6 +1596,10 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) if (!np) return 1; + if (!of_id) { + dev_err(host->dev, "Error: No device match found\n"); + return -ENODEV; + } host->devtype_data = of_id->data; return 0; diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c index 3ad514c..0e09c11 100644 --- a/drivers/mtd/nand/vf610_nfc.c +++ b/drivers/mtd/nand/vf610_nfc.c @@ -674,6 +674,10 @@ static int vf610_nfc_probe(struct platform_device *pdev) } of_id = of_match_device(vf610_nfc_dt_ids, &pdev->dev); + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } nfc->variant = (enum vf610_nfc_variant)of_id->data; for_each_available_child_of_node(nfc->dev->of_node, child) {