From patchwork Mon Dec 12 03:00:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 704904 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tcSLn18wkz9t15 for ; Mon, 12 Dec 2016 14:02:41 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="hsPzHQql"; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cGGrk-0000ft-LF; Mon, 12 Dec 2016 03:01:24 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cGGqy-0008GP-9b for linux-mtd@lists.infradead.org; Mon, 12 Dec 2016 03:00:37 +0000 Received: by mail-pf0-x242.google.com with SMTP id c4so3605662pfb.3 for ; Sun, 11 Dec 2016 19:00:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=6eDdszofMK7e09+w8ZPShhBG7UW27fV4gIRNJowrfO0=; b=hsPzHQqlag7lqj/bU4n679nB4duCAujYl0QUNPVt6g0yVzHY1BAXAXB9NBJvKoE7Oe wvcgQKJUeWNyaAbm85tP1wdPCIyGrXrFVUk4QG1GVh+Aqp1B4suz1Z/oI1siqeZlzj92 SUJrXAHFEF9TD4dWF2qp10CjfmgIptR8VVnA0ri8PFFPsuLiWb+yPGuvv9ds3awDFLg0 NLOXVRVGpmGIF9Hvx+jNFONPW+ArNvD8USI8RnjNSx5inRtDCcgZazX2C1Ot7rIpmPjU 297kiqXc6NAigCgsGdAzPZPfZxKWdsOn+FsTkZgxY0Hjj4kTHHmL9iryIQhaB/Y9By5d IZBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6eDdszofMK7e09+w8ZPShhBG7UW27fV4gIRNJowrfO0=; b=UupM8J/DQs0Rg6Ap6XDYdu+T2NRCeytUVh3uTmzVHA7n8JK1GgzMCKNiM2qYGN268R 7i1/1NcM6Kmd51cIenCjcqSQtq/qGZe7ClcwYjbiuw1SEU7jkZHSM0DV69Tz2bDZPmzP bXqOjz0gLX+BD22B7z9C2etfc+OLCt30YiRRSQFtjcWF3NLWxJOdzrKkCo5/+N+68bGR xrIJHC95DhwIPNYKhfHcX61biSYADiWPG0EEzNZJjuMdXqt5/HQPJ1M2cLw2BJIZE820 jOkKDNfmVt1ygKVGi6lzlbkILhpM9bazPrnuTxhR/9aX9Ceepxh68OQyrsVa78//3Rkx 3lnA== X-Gm-Message-State: AKaTC00ZiIojCvUMiJp3rVHyWD8FC6EMGOLI35t80lyIsRtriqY3ESYsFuaLz/1yuitPcg== X-Received: by 10.98.48.134 with SMTP id w128mr29096830pfw.133.1481511615008; Sun, 11 Dec 2016 19:00:15 -0800 (PST) Received: from localhost.localdomain ([103.16.70.191]) by smtp.gmail.com with ESMTPSA id l11sm72344586pfb.28.2016.12.11.19.00.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 11 Dec 2016 19:00:14 -0800 (PST) From: Arvind Yadav To: robert.jarzmik@free.fr, dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@atmel.com Subject: [V2] mtd: devices: docg3:- Handle return value of devm_ioremap. Date: Mon, 12 Dec 2016 08:30:04 +0530 Message-Id: <1481511604-6116-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161211_190036_440463_D693F92F X-CRM114-Status: GOOD ( 10.01 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c00:0:0:0:242 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (arvind.yadav.cs[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. Signed-off-by: Arvind Yadav Acked-by: Marek Vasut --- drivers/mtd/devices/docg3.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c index b833e6c..ffe3db0 100644 --- a/drivers/mtd/devices/docg3.c +++ b/drivers/mtd/devices/docg3.c @@ -2083,9 +2083,14 @@ static int __init docg3_probe(struct platform_device *pdev) dev_err(dev, "No I/O memory resource defined\n"); return ret; } - base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE); ret = -ENOMEM; + base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE); + if (!base) { + dev_err(dev, "failed to map I/O memory\n"); + return ret; + } + cascade = devm_kzalloc(dev, sizeof(*cascade) * DOC_MAX_NBFLOORS, GFP_KERNEL); if (!cascade)