From patchwork Sun Dec 11 18:01:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 704858 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tcDQS3Yq8z9t0J for ; Mon, 12 Dec 2016 05:05:03 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UKiIKqxr"; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cG8St-00013u-05; Sun, 11 Dec 2016 18:03:11 +0000 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cG8S9-00012N-IE for linux-mtd@lists.infradead.org; Sun, 11 Dec 2016 18:02:27 +0000 Received: by mail-pg0-x243.google.com with SMTP id p66so8358429pga.2 for ; Sun, 11 Dec 2016 10:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=RxxSVX2AUER8BQoL19hQ6FRh9T0pN5N5r+M2gYbXXw4=; b=UKiIKqxrRP0rfsG0nnXHkVIMHbw4hM1+zhq/+OKzW/fPqR9fc3+Tvxt0/PHy2hhwaA dQcZdX6aSc6KYOvNEdLAnXww2EU50Gstk/woMRcob6U2anWpvT9RSpm0Cq/FZf1BCMkO y7+LdMCRfgUL80ty0wESW7lIp9MjXvQJjDCUgibgxFC/487Xs6UNhW9cGCmg7PZC3kAE bjiSeJYnhbxl9H/Y4YK+t5OBZxHapcrLKr+FPCm11CGM7HkrKC/7cHyXm+PP1BGI5Yht C45buTtLe/F1ogy5BKhoIz5t49WQ9U5WTPYv0ALWZTPShORov46oFX4Xu2go3AJekxxC 1ptQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RxxSVX2AUER8BQoL19hQ6FRh9T0pN5N5r+M2gYbXXw4=; b=YhkzyH8nSTaerpH+KPyF++Jgke5koWxIzYQjAch56mhi9xLLLQKCFAdkP32nvXLiaY u08UAwu2sKOSOkix7iyfuqBz8cMmVwyakBJnQNTggFPifhg/la3ZiNGo0QdQqNt20lSS kCULG+R5eyuyNmF597kB5iq0TuzJi7Nyb3mbJKXqXa8tINDzLv3Fu2YbpZRZaDNDFspd 84hQVOwKXSfAryeAs/h5ZyvQmXv/bgtiedpOY2SregMySQzQrp2LEkZ0snxe5nqRWneG S7UZyYgly8tj/B7BItIr3Oyj95dK0P26YAxACkuTq8noQst2NtHuUuq/lN8xmzNx+TpA KLrQ== X-Gm-Message-State: AKaTC034bxdy7K2C5GE66LAixFWXk5nIkaraQOYJJq2cViwkqC3aK64KCoJh96PRW133jw== X-Received: by 10.84.194.195 with SMTP id h61mr177229655pld.95.1481479323061; Sun, 11 Dec 2016 10:02:03 -0800 (PST) Received: from localhost.localdomain ([103.16.70.191]) by smtp.gmail.com with ESMTPSA id o1sm71368175pgf.35.2016.12.11.10.01.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 11 Dec 2016 10:02:02 -0800 (PST) From: Arvind Yadav To: robert.jarzmik@free.fr, dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@atmel.com Subject: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap. Date: Sun, 11 Dec 2016 23:31:50 +0530 Message-Id: <1481479310-2698-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161211_100225_670769_F11AA249 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c05:0:0:0:243 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (arvind.yadav.cs[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. Signed-off-by: Arvind Yadav --- drivers/mtd/devices/docg3.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c index b833e6c..013b5b9 100644 --- a/drivers/mtd/devices/docg3.c +++ b/drivers/mtd/devices/docg3.c @@ -2083,9 +2083,12 @@ static int __init docg3_probe(struct platform_device *pdev) dev_err(dev, "No I/O memory resource defined\n"); return ret; } - base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE); ret = -ENOMEM; + base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE); + if (!base) + return ret; + cascade = devm_kzalloc(dev, sizeof(*cascade) * DOC_MAX_NBFLOORS, GFP_KERNEL); if (!cascade)