diff mbox

[1/2] mtd: nand: timings: Fix tADL_min for ONFI 4.0 chips

Message ID 1465914067-29736-1-git-send-email-boris.brezillon@free-electrons.com
State Accepted
Commit 74a332e78e8f0e2b8bef7ebb6b3470bb0df1a0bf
Headers show

Commit Message

Boris Brezillon June 14, 2016, 2:21 p.m. UTC
ONFI 4.0 spec defines different values for the tADL_min timing.
Since we don't want to have different timings depending on the ONFI
version, we just set tADL_min to the maximum value (the one specified
in the ONFI 4.0 spec).

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/mtd/nand/nand_timings.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Boris Brezillon Aug. 15, 2016, 3:17 p.m. UTC | #1
On Tue, 14 Jun 2016 16:21:06 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> ONFI 4.0 spec defines different values for the tADL_min timing.
> Since we don't want to have different timings depending on the ONFI
> version, we just set tADL_min to the maximum value (the one specified
> in the ONFI 4.0 spec).

Applied both.

> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>  drivers/mtd/nand/nand_timings.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
> index e81470a..c0941d5 100644
> --- a/drivers/mtd/nand/nand_timings.c
> +++ b/drivers/mtd/nand/nand_timings.c
> @@ -16,7 +16,7 @@
>  static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	/* Mode 0 */
>  	{
> -		.tADL_min = 200000,
> +		.tADL_min = 400000,
>  		.tALH_min = 20000,
>  		.tALS_min = 50000,
>  		.tAR_min = 25000,
> @@ -53,7 +53,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 1 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 10000,
>  		.tALS_min = 25000,
>  		.tAR_min = 10000,
> @@ -90,7 +90,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 2 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 10000,
>  		.tALS_min = 15000,
>  		.tAR_min = 10000,
> @@ -127,7 +127,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 3 */
>  	{
> -		.tADL_min = 100000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,
> @@ -164,7 +164,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 4 */
>  	{
> -		.tADL_min = 70000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,
> @@ -201,7 +201,7 @@ static const struct nand_sdr_timings onfi_sdr_timings[] = {
>  	},
>  	/* Mode 5 */
>  	{
> -		.tADL_min = 70000,
> +		.tADL_min = 400000,
>  		.tALH_min = 5000,
>  		.tALS_min = 10000,
>  		.tAR_min = 10000,
diff mbox

Patch

diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
index e81470a..c0941d5 100644
--- a/drivers/mtd/nand/nand_timings.c
+++ b/drivers/mtd/nand/nand_timings.c
@@ -16,7 +16,7 @@ 
 static const struct nand_sdr_timings onfi_sdr_timings[] = {
 	/* Mode 0 */
 	{
-		.tADL_min = 200000,
+		.tADL_min = 400000,
 		.tALH_min = 20000,
 		.tALS_min = 50000,
 		.tAR_min = 25000,
@@ -53,7 +53,7 @@  static const struct nand_sdr_timings onfi_sdr_timings[] = {
 	},
 	/* Mode 1 */
 	{
-		.tADL_min = 100000,
+		.tADL_min = 400000,
 		.tALH_min = 10000,
 		.tALS_min = 25000,
 		.tAR_min = 10000,
@@ -90,7 +90,7 @@  static const struct nand_sdr_timings onfi_sdr_timings[] = {
 	},
 	/* Mode 2 */
 	{
-		.tADL_min = 100000,
+		.tADL_min = 400000,
 		.tALH_min = 10000,
 		.tALS_min = 15000,
 		.tAR_min = 10000,
@@ -127,7 +127,7 @@  static const struct nand_sdr_timings onfi_sdr_timings[] = {
 	},
 	/* Mode 3 */
 	{
-		.tADL_min = 100000,
+		.tADL_min = 400000,
 		.tALH_min = 5000,
 		.tALS_min = 10000,
 		.tAR_min = 10000,
@@ -164,7 +164,7 @@  static const struct nand_sdr_timings onfi_sdr_timings[] = {
 	},
 	/* Mode 4 */
 	{
-		.tADL_min = 70000,
+		.tADL_min = 400000,
 		.tALH_min = 5000,
 		.tALS_min = 10000,
 		.tAR_min = 10000,
@@ -201,7 +201,7 @@  static const struct nand_sdr_timings onfi_sdr_timings[] = {
 	},
 	/* Mode 5 */
 	{
-		.tADL_min = 70000,
+		.tADL_min = 400000,
 		.tALH_min = 5000,
 		.tALS_min = 10000,
 		.tAR_min = 10000,