diff mbox

[v2,4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC

Message ID 1465903058-9211-5-git-send-email-mamlinav@gmail.com
State Not Applicable
Headers show

Commit Message

Aleksei Mamlin June 14, 2016, 11:17 a.m. UTC 
From: Boris Brezillon <boris.brezillon@free-electrons.com>

Add NAND Flash controller node definition to the A20 SoC.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Maxime Ripard June 14, 2016, 12:33 p.m. UTC | #1 
On Tue, Jun 14, 2016 at 02:17:38PM +0300, Aleksei Mamlin wrote:
> From: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> Add NAND Flash controller node definition to the A20 SoC.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>

Applied, thanks!
Maxime
kernel test robot June 14, 2016, 1:11 p.m. UTC | #2 
Hi,

[auto build test ERROR on mripard/sunxi/for-next]
[also build test ERROR on next-20160614]
[cannot apply to robh/for-next v4.7-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Aleksei-Mamlin/dts-sunxi-Add-sunxi-NAND-Flash-Controller-support/20160614-192539
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
config: arm-sunxi_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/sun7i-a20.dtsi:806.26-27 syntax error
   FATAL ERROR: Unable to parse input tree

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
Aleksei Mamlin June 14, 2016, 1:19 p.m. UTC | #3 
On Tue, 14 Jun 2016 21:11:12 +0800
kbuild test robot <lkp@intel.com> wrote:

> Hi,
> 
> [auto build test ERROR on mripard/sunxi/for-next]
> [also build test ERROR on next-20160614]
> [cannot apply to robh/for-next v4.7-rc3]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Aleksei-Mamlin/dts-sunxi-Add-sunxi-NAND-Flash-Controller-support/20160614-192539
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
> config: arm-sunxi_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> All errors (new ones prefixed by >>):
> 
> >> Error: arch/arm/boot/dts/sun7i-a20.dtsi:806.26-27 syntax error
>    FATAL ERROR: Unable to parse input tree
> 

My bad, dual semicolon at line 806. Maxime, can you fix it locally?

> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
Maxime Ripard June 14, 2016, 1:57 p.m. UTC | #4 
On Tue, Jun 14, 2016 at 04:19:08PM +0300, Aleksei Mamlin wrote:
> On Tue, 14 Jun 2016 21:11:12 +0800
> kbuild test robot <lkp@intel.com> wrote:
> 
> > Hi,
> > 
> > [auto build test ERROR on mripard/sunxi/for-next]
> > [also build test ERROR on next-20160614]
> > [cannot apply to robh/for-next v4.7-rc3]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Aleksei-Mamlin/dts-sunxi-Add-sunxi-NAND-Flash-Controller-support/20160614-192539
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
> > config: arm-sunxi_defconfig (attached as .config)
> > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=arm 
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> Error: arch/arm/boot/dts/sun7i-a20.dtsi:806.26-27 syntax error
> >    FATAL ERROR: Unable to parse input tree
> > 
> 
> My bad, dual semicolon at line 806. Maxime, can you fix it locally?

Already did :)

Thanks!
Maxime
Aleksei Mamlin June 14, 2016, 2:02 p.m. UTC | #5 
On Tue, 14 Jun 2016 15:57:16 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> On Tue, Jun 14, 2016 at 04:19:08PM +0300, Aleksei Mamlin wrote:
> > On Tue, 14 Jun 2016 21:11:12 +0800
> > kbuild test robot <lkp@intel.com> wrote:
> > 
> > > Hi,
> > > 
> > > [auto build test ERROR on mripard/sunxi/for-next]
> > > [also build test ERROR on next-20160614]
> > > [cannot apply to robh/for-next v4.7-rc3]
> > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > > 
> > > url:    https://github.com/0day-ci/linux/commits/Aleksei-Mamlin/dts-sunxi-Add-sunxi-NAND-Flash-Controller-support/20160614-192539
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
> > > config: arm-sunxi_defconfig (attached as .config)
> > > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> > > reproduce:
> > >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # save the attached .config to linux build tree
> > >         make.cross ARCH=arm 
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > >> Error: arch/arm/boot/dts/sun7i-a20.dtsi:806.26-27 syntax error
> > >    FATAL ERROR: Unable to parse input tree
> > > 
> > 
> > My bad, dual semicolon at line 806. Maxime, can you fix it locally?
> 
> Already did :)

Thanks a lot!

> 
> Thanks!
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index ad984f8..7d7560f 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -798,6 +798,19 @@ 
 			#dma-cells = <2>;
 		};
 
+		nfc: nand@01c03000 {
+			compatible = "allwinner,sun4i-a10-nand";
+			reg = <0x01c03000 0x1000>;
+			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;;
+			clocks = <&ahb_gates 13>, <&nand_clk>;
+			clock-names = "ahb", "mod";
+			dmas = <&dma SUN4I_DMA_DEDICATED 3>;
+			dma-names = "rxtx";
+			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
+		};
+
 		spi0: spi@01c05000 {
 			compatible = "allwinner,sun4i-a10-spi";
 			reg = <0x01c05000 0x1000>;