diff mbox

[5/6] memory: omap-gpmc: Enable omap-gpmc by default when dependency is met

Message ID 1465491777-20033-6-git-send-email-fcooper@ti.com
State Changes Requested
Headers show

Commit Message

Franklin S Cooper Jr June 9, 2016, 5:02 p.m. UTC
When dependencies are met enable OMAP GPMC by default. Later patches will
prevent OMAP GPMC from being automatically selected by mach-omap2 Kconfig.
Therefore, this will sure after that change the current behavior is still
maintained when dependencies are met.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 drivers/memory/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

kernel test robot June 9, 2016, 6:07 p.m. UTC | #1
Hi,

[auto build test ERROR on arm/for-next]
[also build test ERROR on v4.7-rc2 next-20160609]
[cannot apply to omap/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Franklin-S-Cooper-Jr/ARM-OMAP2-Don-t-force-select-OMAP_GPMC/20160610-010648
base:   http://repo.or.cz/linux-2.6/linux-2.6-arm.git for-next
config: x86_64-acpi-redef (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/memory/omap-gpmc.c:38:28: fatal error: asm/mach-types.h: No such file or directory
    #include <asm/mach-types.h>
                               ^
   compilation terminated.

vim +38 drivers/memory/omap-gpmc.c

fced80c73 arch/arm/mach-omap2/gpmc.c Russell King         2008-09-06  22  #include <linux/io.h>
fd1dc87de arch/arm/mach-omap2/gpmc.c Paul Walmsley        2008-10-06  23  #include <linux/module.h>
d2d00862d drivers/memory/omap-gpmc.c Roger Quadros        2016-03-07  24  #include <linux/gpio/driver.h>
db97eb7df arch/arm/mach-omap2/gpmc.c Sukumar Ghorai       2011-01-28  25  #include <linux/interrupt.h>
384258f25 drivers/memory/omap-gpmc.c Roger Quadros        2015-07-30  26  #include <linux/irqdomain.h>
da4968739 arch/arm/mach-omap2/gpmc.c Afzal Mohammed       2012-09-23  27  #include <linux/platform_device.h>
bc6b1e7b8 arch/arm/mach-omap2/gpmc.c Daniel Mack          2012-12-14  28  #include <linux/of.h>
cdd6928c5 arch/arm/mach-omap2/gpmc.c Jon Hunter           2013-02-08  29  #include <linux/of_address.h>
bc6b1e7b8 arch/arm/mach-omap2/gpmc.c Daniel Mack          2012-12-14  30  #include <linux/of_device.h>
b1dc1ca9d drivers/memory/omap-gpmc.c Robert ABEL          2015-02-27  31  #include <linux/of_platform.h>
e639cd5bf arch/arm/mach-omap2/gpmc.c Tony Lindgren        2014-11-20  32  #include <linux/omap-gpmc.h>
b3f5525c5 arch/arm/mach-omap2/gpmc.c avinash philip       2013-06-12  33  #include <linux/pm_runtime.h>
4bbbc1adc arch/arm/mach-omap2/gpmc.c Juha Yrjola          2006-06-26  34  
bc3668ea0 arch/arm/mach-omap2/gpmc.c Afzal Mohammed       2012-09-29  35  #include <linux/platform_data/mtd-nand-omap2.h>
e639cd5bf arch/arm/mach-omap2/gpmc.c Tony Lindgren        2014-11-20  36  #include <linux/platform_data/mtd-onenand-omap2.h>
4bbbc1adc arch/arm/mach-omap2/gpmc.c Juha Yrjola          2006-06-26  37  
7f2451624 arch/arm/mach-omap2/gpmc.c Kyungmin Park        2006-12-29 @38  #include <asm/mach-types.h>
72d0f1c3c arch/arm/mach-omap2/gpmc.c Syed Mohammed Khasim 2006-12-06  39  
4be48fd53 arch/arm/mach-omap2/gpmc.c Afzal Mohammed       2012-09-23  40  #define	DEVICE_NAME		"omap-gpmc"
4be48fd53 arch/arm/mach-omap2/gpmc.c Afzal Mohammed       2012-09-23  41  
fd1dc87de arch/arm/mach-omap2/gpmc.c Paul Walmsley        2008-10-06  42  /* GPMC register offsets */
4bbbc1adc arch/arm/mach-omap2/gpmc.c Juha Yrjola          2006-06-26  43  #define GPMC_REVISION		0x00
4bbbc1adc arch/arm/mach-omap2/gpmc.c Juha Yrjola          2006-06-26  44  #define GPMC_SYSCONFIG		0x10
4bbbc1adc arch/arm/mach-omap2/gpmc.c Juha Yrjola          2006-06-26  45  #define GPMC_SYSSTATUS		0x14
4bbbc1adc arch/arm/mach-omap2/gpmc.c Juha Yrjola          2006-06-26  46  #define GPMC_IRQSTATUS		0x18

:::::: The code at line 38 was first introduced by commit
:::::: 7f24516240c78760d0b19e6160dcab893ef81918 [PATCH] ARM: OMAP: fix GPMC compiler errors

:::::: TO: Kyungmin Park <kyungmin.park@samsung.com>
:::::: CC: Linus Torvalds <torvalds@woody.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
Boris Brezillon June 9, 2016, 6:45 p.m. UTC | #2
On Thu,  9 Jun 2016 12:02:56 -0500
Franklin S Cooper Jr <fcooper@ti.com> wrote:

> When dependencies are met enable OMAP GPMC by default. Later patches will
> prevent OMAP GPMC from being automatically selected by mach-omap2 Kconfig.
> Therefore, this will sure after that change the current behavior is still
> maintained when dependencies are met.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  drivers/memory/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 81ddb17..56a1c66 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -51,6 +51,7 @@ config TI_EMIF
>  
>  config OMAP_GPMC
>  	bool
> +	default y

	depends ARCH_OMAP2PLUS

>  	select GPIOLIB
>  	help
>  	  This driver is for the General Purpose Memory Controller (GPMC)
Boris Brezillon June 9, 2016, 6:46 p.m. UTC | #3
On Thu, 9 Jun 2016 20:45:03 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Thu,  9 Jun 2016 12:02:56 -0500
> Franklin S Cooper Jr <fcooper@ti.com> wrote:
> 
> > When dependencies are met enable OMAP GPMC by default. Later patches will
> > prevent OMAP GPMC from being automatically selected by mach-omap2 Kconfig.
> > Therefore, this will sure after that change the current behavior is still
> > maintained when dependencies are met.
> > 
> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > ---
> >  drivers/memory/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> > index 81ddb17..56a1c66 100644
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -51,6 +51,7 @@ config TI_EMIF
> >  
> >  config OMAP_GPMC
> >  	bool
> > +	default y  
> 
> 	depends ARCH_OMAP2PLUS

Actually, that was a question :).

> 
> >  	select GPIOLIB
> >  	help
> >  	  This driver is for the General Purpose Memory Controller (GPMC)  
> 
> 
>
diff mbox

Patch

diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 81ddb17..56a1c66 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -51,6 +51,7 @@  config TI_EMIF
 
 config OMAP_GPMC
 	bool
+	default y
 	select GPIOLIB
 	help
 	  This driver is for the General Purpose Memory Controller (GPMC)