Message ID | 1461699396-33000-12-git-send-email-seth.forshee@canonical.com |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qvYLD09s5z9t5g for <incoming@patchwork.ozlabs.org>; Wed, 27 Apr 2016 05:38:44 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical-com.20150623.gappssmtp.com header.i=@canonical-com.20150623.gappssmtp.com header.b=hq3y5nkE; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1av8nx-0002d1-6s; Tue, 26 Apr 2016 19:37:53 +0000 Received: from mail-ig0-x22b.google.com ([2607:f8b0:4001:c05::22b]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1av8nV-00020Q-4R for linux-mtd@lists.infradead.org; Tue, 26 Apr 2016 19:37:25 +0000 Received: by mail-ig0-x22b.google.com with SMTP id g8so25522951igr.0 for <linux-mtd@lists.infradead.org>; Tue, 26 Apr 2016 12:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Lo5iDM9zOZrtGAL6ADxgGtKcisaTOotUC/Wi0eo0ick=; b=hq3y5nkEE07FBHvEIenezdBWbg2OxjuJsKUBaZmravKXF5GOYm7v4XlO3qcZ0SrNx5 WTbPJzxF0NA5H42jKruazM3pizXc/fzdSBgZKgGPNLs5Y+ZgTgUPaZxAcru3A6OPymq3 ZwS0W5ypsKKsatDarhSyJvQvdnOmdE8FW5cTPVf+Ry/VUIWN3Br7yM1QGf/RgFXxYA++ n3VwUCZg839UYYfb8SxyuHILl3nj46c92fIkvLraY0ZlklrqyCqk1gOJxUZb4itxTZ8L ZyJTmJmrybtIrJASKRwi8XWXiPedBvMPkGw38de+TPxXMUM4BeT313Pcx+ZRVQEdJxez PKoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Lo5iDM9zOZrtGAL6ADxgGtKcisaTOotUC/Wi0eo0ick=; b=YF/pKTtVJNSr/7yLxkTWOkR1GMIbKI3UeuYOLBxu+QUnCxNnu+Xo8LhI3Mnor1i+Za +QqAM1HcN4jbtIzorCh7gXYRTFSJhYdwOLm40lH8YXXycGvzi/hNXiROSgKkvda9VxF5 dsvPfTV65uponFo1ZqVCAYB2aB4Gxkj9C/mnNFXxc+YqFNXwuRD/L1Ev3o59I8n6pdXB MoFpc61viTTlsuFwYUcp8IzXtShLKz03p5iHCvb4+rzKNqk9AB7Yt307iSdJYxC1rxW0 kkCMN9CKs9M88U04W5sFS6RZ61d8c5gZKuu4+j7GoRW61ifvOr4KGwElvEAcpU9Xo82W CQbQ== X-Gm-Message-State: AOPr4FVtQ97+kT+z/LHxUuJsJML8qZoZWvlCCeLGWtPDLWjayuZewKNQ8s2raDL081HexKND X-Received: by 10.50.50.143 with SMTP id c15mr20781827igo.44.1461699424078; Tue, 26 Apr 2016 12:37:04 -0700 (PDT) Received: from localhost ([2605:a601:aab:f920:39a1:5bcf:aa:5b00]) by smtp.gmail.com with ESMTPSA id k3sm9850064igz.2.2016.04.26.12.37.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Apr 2016 12:37:03 -0700 (PDT) From: Seth Forshee <seth.forshee@canonical.com> To: "Eric W. Biederman" <ebiederm@xmission.com> Subject: [PATCH v4 11/21] cred: Reject inodes with invalid ids in set_create_file_as() Date: Tue, 26 Apr 2016 14:36:24 -0500 Message-Id: <1461699396-33000-12-git-send-email-seth.forshee@canonical.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1461699396-33000-1-git-send-email-seth.forshee@canonical.com> References: <1461699396-33000-1-git-send-email-seth.forshee@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160426_123725_286579_F4574261 X-CRM114-Status: UNSURE ( 9.74 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:4001:c05:0:0:0:22b listed in] [list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/> List-Post: <mailto:linux-mtd@lists.infradead.org> List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>, <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe> Cc: linux-bcache@vger.kernel.org, Serge Hallyn <serge.hallyn@canonical.com>, Seth Forshee <seth.forshee@canonical.com>, dm-devel@redhat.com, Miklos Szeredi <mszeredi@redhat.com>, Richard Weinberger <richard.weinberger@gmail.com>, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, fuse-devel@lists.sourceforge.net, Austin S Hemmelgarn <ahferroin7@gmail.com>, linux-mtd@lists.infradead.org, Alexander Viro <viro@zeniv.linux.org.uk>, selinux@tycho.nsa.gov, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, Pavel Tikhomirov <ptikhomirov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
diff --git a/kernel/cred.c b/kernel/cred.c index 0c0cd8a62285..5f264fb5737d 100644 --- a/kernel/cred.c +++ b/kernel/cred.c @@ -689,6 +689,8 @@ EXPORT_SYMBOL(set_security_override_from_ctx); */ int set_create_files_as(struct cred *new, struct inode *inode) { + if (!uid_valid(inode->i_uid) || !gid_valid(inode->i_gid)) + return -EINVAL; new->fsuid = inode->i_uid; new->fsgid = inode->i_gid; return security_kernel_create_files_as(new, inode);