From patchwork Fri Apr 15 19:54:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 611226 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qmpHy417dz9t64 for ; Sat, 16 Apr 2016 05:58:22 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=B42huuuw; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ar9qf-0005Qz-Ls; Fri, 15 Apr 2016 19:56:13 +0000 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ar9qb-00055A-33 for linux-mtd@lists.infradead.org; Fri, 15 Apr 2016 19:56:09 +0000 Received: by mail-wm0-x22c.google.com with SMTP id n3so46880521wmn.0 for ; Fri, 15 Apr 2016 12:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w53S+zmLJ1qc1aUO1SJeXcclQ15wmENTuwyAoHEnEbc=; b=B42huuuwGalfDvTIekPQrgtg1/2jV+pY2ZaDzeGgMdjc4gjgo/Ydc0jgJmWLU/yFl0 Yt4J8uFzcPzQWALRy7zlijLx6f+qukmke1uCHQY9ahXZTo6enxVPzDoR7cwrgeG68Il+ Y/UI3FKxPx+7IitW8HA0RaiYiMlpqB29g1AlFJAyzVIuTT3/JzgMPbXC2XJrYW6R5swE ajt+GamStjjqffeME+3QOpI2eymh722jEUx4cnHUm0bKQEe+qCcneTTXKgT0RYSV67Vv HlBgYNm0jRMiuftEEK8GqxcvtO3b4gK8kQcfpl5cXKqQ1Hhh4aNbvZxDGmQbFE+YSpg3 ppCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w53S+zmLJ1qc1aUO1SJeXcclQ15wmENTuwyAoHEnEbc=; b=FGMW9XvlWNYP4Kj2dk3OK+pYgn2s8azYx680i2JqpDW5Q3B99+UZxGiCWoPTFKX+IV 6E4fc8sTa5LOPahVbxdYVGkRqO83NKh73FYFLmNlUQH3/tTjyNJmIwgIhLIAP0Poy0as JAcUsTfmzrl08V9xi8FpIh1hps2/8C9fa4EuNiDCxu45jVxIvPs+t16xCQF5BXCwLZo7 bMVXOFMsSvTlWkzbEIO3seZuP1I2qN5+mn4NQgbpoWKJvSFfeQhzBQaQMuWEr4UVFzcY cdr98+YQoUbW2tilRDvZz24Va1X6gmohWC6UlpbvzH76nykgrWQt2nyQXDajExIdZfRK 8Q2A== X-Gm-Message-State: AOPr4FXlpVhbmRaMpPmozFYnt5QX7vRnnc/0jrZvBnBquk6bshk/EAcQD+ZlyKJrpG3p1Q== X-Received: by 10.28.21.75 with SMTP id 72mr5974950wmv.64.1460750147669; Fri, 15 Apr 2016 12:55:47 -0700 (PDT) Received: from linux-tdhb.lan (adjj18.neoplus.adsl.tpnet.pl. [79.184.217.18]) by smtp.gmail.com with ESMTPSA id r204sm24248948wmg.20.2016.04.15.12.55.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Apr 2016 12:55:46 -0700 (PDT) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: Boris Brezillon Subject: [PATCH 09/12] mtd: nand: fsmc: validate ECC setup by checking algorithm directly Date: Fri, 15 Apr 2016 21:54:09 +0200 Message-Id: <1460750052-16285-10-git-send-email-zajec5@gmail.com> X-Mailer: git-send-email 1.8.4.5 In-Reply-To: <1460750052-16285-1-git-send-email-zajec5@gmail.com> References: <1460750052-16285-1-git-send-email-zajec5@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160415_125609_389161_1486B6EE X-CRM114-Status: GOOD ( 12.09 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:22c listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zajec5[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (zajec5[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , open list , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org NAND core sets ECC algorithm in algo field now and it should be preferred over the mode field. This also prepares driver for dropping NAND_ECC_SOFT_BCH. Signed-off-by: Rafał Miłecki --- drivers/mtd/nand/fsmc_nand.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c index 1372040..0f8c63f 100644 --- a/drivers/mtd/nand/fsmc_nand.c +++ b/drivers/mtd/nand/fsmc_nand.c @@ -958,9 +958,12 @@ static int __init fsmc_nand_probe(struct platform_device *pdev) nand->ecc.strength = 1; break; + case NAND_ECC_SOFT: case NAND_ECC_SOFT_BCH: - dev_info(&pdev->dev, "Using 4-bit SW BCH ECC scheme\n"); - break; + if (nand->ecc.algo == NAND_ECC_BCH) { + dev_info(&pdev->dev, "Using 4-bit SW BCH ECC scheme\n"); + break; + } default: dev_err(&pdev->dev, "Unsupported ECC mode!\n");