From patchwork Fri Jan 29 19:25:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 575815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 988C91402D2 for ; Sat, 30 Jan 2016 06:28:31 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=peqU0wes; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aPEhD-000693-LG; Fri, 29 Jan 2016 19:27:03 +0000 Received: from mail-pa0-x241.google.com ([2607:f8b0:400e:c03::241]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aPEgk-0005ba-6h for linux-mtd@lists.infradead.org; Fri, 29 Jan 2016 19:26:35 +0000 Received: by mail-pa0-x241.google.com with SMTP id gi1so4003255pac.2 for ; Fri, 29 Jan 2016 11:26:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XSAYJUDun9N+AgXwYX1mzyRRDSvdqjj/HolHewxDAk4=; b=peqU0wes8RmftPc242brmHGsDMyPI8MLPqI8Ctow3K3g2W/9bE1dZgcQ/j6XOtgEqJ pqq/KSk7KDt4PnHfGoGAjcPhocWBNLXPEfb8rpuCmSZRWFFjWD5TKDlc/URMtjkl7Phr kaMyA14pTKB3r02+ejncABnTbDIZydzvnSvbQaGyTR5vgbAUC41zZr32y6PlU25+QNAr 5fevOzi2K2ge3FO7xe6HZBjCY0xrMPd10aATbouF/HVRGkWkg0bEGHstKMG8tR2U4L4n vw0oL91g9xgjDNqPUXcT/Aakg298IrENrC2dOVlJME+ctjY3DTBp7YiwjCJhohYhl4ds A6KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XSAYJUDun9N+AgXwYX1mzyRRDSvdqjj/HolHewxDAk4=; b=HsGNsnMNVSUsAdtwP3cmFVhsL1iMSt3FdcA7joH6tIx6zAuhjhpzCnVX45hOHFb5EX MU80LwiI7WFuFIGbUG2RyoVqUSuk6KIQ3dLF6Q54R36JDv9vQhw3VGVf1G9QoJLiDIvS FfjTS6/xCd2tSYP7H1FpoUgvpuh0Hxbg2P6y6QjLmzOF5ylVQgGVPjfxEtICwulkDB1w YSK9/657Xinbi8mOSiUiLsBBtwgUQfE3ekxfprH0Y7VQmDIaKDC4amtgraKVYEDJ/ZP7 zLn4o0SZ7icgrtukkSKqbm44EYVJkt1FocMDYCtwPSIwS84IWa/BOIhSLTT945LDfx3y bkUA== X-Gm-Message-State: AG10YOSWoYJDlWmc2KdybArjjZDbep+9H7x4evuOq503pXLdtWu0f3lEKrI7yw95ZJwgkw== X-Received: by 10.66.55.39 with SMTP id o7mr15743258pap.13.1454095573612; Fri, 29 Jan 2016 11:26:13 -0800 (PST) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id dg12sm25264001pac.47.2016.01.29.11.26.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Jan 2016 11:26:13 -0800 (PST) From: Brian Norris To: Subject: [PATCH v2 5/8] mtd: spi-nor: use BIT() for flash_info flags Date: Fri, 29 Jan 2016 11:25:34 -0800 Message-Id: <1454095537-130536-6-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1454095537-130536-1-git-send-email-computersforpeace@gmail.com> References: <1454095537-130536-1-git-send-email-computersforpeace@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160129_112634_479586_571E637C X-CRM114-Status: UNSURE ( 9.13 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:400e:c03:0:0:0:241 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (computersforpeace[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Boris Brezillon , djkurtz@chromium.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , linux-kernel@vger.kernel.org, Bayi Cheng , Ezequiel Garcia , Brian Norris MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org It's a little easier to read and make sure there are no collisions (IMO). Signed-off-by: Brian Norris Reviewed-by: Ezequiel Garcia --- v2: no change drivers/mtd/spi-nor/spi-nor.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 54eaf4b5bf05..9cd92f135fa2 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -61,14 +61,14 @@ struct flash_info { u16 addr_width; u16 flags; -#define SECT_4K 0x01 /* SPINOR_OP_BE_4K works uniformly */ -#define SPI_NOR_NO_ERASE 0x02 /* No erase command needed */ -#define SST_WRITE 0x04 /* use SST byte programming */ -#define SPI_NOR_NO_FR 0x08 /* Can't do fastread */ -#define SECT_4K_PMC 0x10 /* SPINOR_OP_BE_4K_PMC works uniformly */ -#define SPI_NOR_DUAL_READ 0x20 /* Flash supports Dual Read */ -#define SPI_NOR_QUAD_READ 0x40 /* Flash supports Quad Read */ -#define USE_FSR 0x80 /* use flag status register */ +#define SECT_4K BIT(0) /* SPINOR_OP_BE_4K works uniformly */ +#define SPI_NOR_NO_ERASE BIT(1) /* No erase command needed */ +#define SST_WRITE BIT(2) /* use SST byte programming */ +#define SPI_NOR_NO_FR BIT(3) /* Can't do fastread */ +#define SECT_4K_PMC BIT(4) /* SPINOR_OP_BE_4K_PMC works uniformly */ +#define SPI_NOR_DUAL_READ BIT(5) /* Flash supports Dual Read */ +#define SPI_NOR_QUAD_READ BIT(6) /* Flash supports Quad Read */ +#define USE_FSR BIT(7) /* use flag status register */ }; #define JEDEC_MFR(info) ((info)->id[0])