| Message ID | 1453584710-27273-1-git-send-email-computersforpeace@gmail.com |
|---|---|
| State | Accepted |
| Commit | f4ba6b8ee73b3b6f726a02ad6ffe826cf8f31261 |
| Headers | show |
Am 23.01.2016 um 22:31 schrieb Brian Norris: > To be consistent with mkfs.jffs2, and to get this to build on my > machine, it looks like we should use <sys/xattr.h>, not <attr/xattr.h>. > > Fixes this error, seen on an Ubuntu 14.04 build system: > > ubifs-utils/mkfs.ubifs/mkfs.ubifs.c:30:24: fatal error: attr/xattr.h: No such file or directory > #include <attr/xattr.h> The build fails because you don't have libattr-devel (or however your distro names that package). Switching to sys/xattr.h from glibc-devel seems fine to me as mkfs.ubifs.c is using only basic xattr stuff. Reviewed-by: Richard Weinberger <richard@nod.at> Thanks, //richard
On Sat, Jan 23, 2016 at 10:44:23PM +0100, Richard Weinberger wrote: > Am 23.01.2016 um 22:31 schrieb Brian Norris: > > To be consistent with mkfs.jffs2, and to get this to build on my > > machine, it looks like we should use <sys/xattr.h>, not <attr/xattr.h>. > > > > Fixes this error, seen on an Ubuntu 14.04 build system: > > > > ubifs-utils/mkfs.ubifs/mkfs.ubifs.c:30:24: fatal error: attr/xattr.h: No such file or directory > > #include <attr/xattr.h> > > The build fails because you don't have libattr-devel (or however your distro names that package). > Switching to sys/xattr.h from glibc-devel seems fine to me as mkfs.ubifs.c is using only basic xattr stuff. Ah, thanks for the clarification. > Reviewed-by: Richard Weinberger <richard@nod.at> Pushed to mtd-utils.git. Brian
diff --git a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c index 27f8d0a160c3..a60052d12c46 100644 --- a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c +++ b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c @@ -27,7 +27,7 @@ #include "common.h" #include <sys/types.h> #ifndef WITHOUT_XATTR -#include <attr/xattr.h> +#include <sys/xattr.h> #endif /* Size (prime number) of hash table for link counting */
To be consistent with mkfs.jffs2, and to get this to build on my machine, it looks like we should use <sys/xattr.h>, not <attr/xattr.h>. Fixes this error, seen on an Ubuntu 14.04 build system: ubifs-utils/mkfs.ubifs/mkfs.ubifs.c:30:24: fatal error: attr/xattr.h: No such file or directory #include <attr/xattr.h> ^ Signed-off-by: Brian Norris <computersforpeace@gmail.com> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Marc Kleine-Budde <mkl@pengutronix.de> Cc: Richard Weinberger <richard@nod.at> --- ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)