Message ID | 1452189779-20001-1-git-send-email-computersforpeace@gmail.com |
---|---|
State | Accepted |
Commit | f118902490aa1c3a361e485dd38a7b28cd130d71 |
Headers | show |
On Thu, 7 Jan 2016 10:02:59 -0800 Brian Norris <computersforpeace@gmail.com> wrote: > As of commit 2d3b77bac34b ("mtd: nand: update mtd_to_nand()"), this > assignment isn't necessary, since struct mtd_info is embedded in struct > nand_chip. > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > Cc: Harvey Hunt <harvey.hunt@imgtec.com> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com> > Cc: Alex Smith <alex@alex-smith.me.uk> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/mtd/nand/jz4780_nand.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c > index 17eb9f264187..6156c554e1c2 100644 > --- a/drivers/mtd/nand/jz4780_nand.c > +++ b/drivers/mtd/nand/jz4780_nand.c > @@ -270,7 +270,6 @@ static int jz4780_nand_init_chip(struct platform_device *pdev, > > chip = &nand->chip; > mtd = nand_to_mtd(chip); > - mtd->priv = chip; > mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%s.%d", dev_name(dev), > cs->bank); > if (!mtd->name)
On Thu, Jan 07, 2016 at 08:32:47PM +0100, Boris Brezillon wrote: > On Thu, 7 Jan 2016 10:02:59 -0800 > Brian Norris <computersforpeace@gmail.com> wrote: > > > As of commit 2d3b77bac34b ("mtd: nand: update mtd_to_nand()"), this > > assignment isn't necessary, since struct mtd_info is embedded in struct > > nand_chip. > > > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > > Cc: Harvey Hunt <harvey.hunt@imgtec.com> > > Cc: Boris Brezillon <boris.brezillon@free-electrons.com> > > Cc: Alex Smith <alex@alex-smith.me.uk> > > Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> Thanks! Applied to l2-mtd.git
diff --git a/drivers/mtd/nand/jz4780_nand.c b/drivers/mtd/nand/jz4780_nand.c index 17eb9f264187..6156c554e1c2 100644 --- a/drivers/mtd/nand/jz4780_nand.c +++ b/drivers/mtd/nand/jz4780_nand.c @@ -270,7 +270,6 @@ static int jz4780_nand_init_chip(struct platform_device *pdev, chip = &nand->chip; mtd = nand_to_mtd(chip); - mtd->priv = chip; mtd->name = devm_kasprintf(dev, GFP_KERNEL, "%s.%d", dev_name(dev), cs->bank); if (!mtd->name)
As of commit 2d3b77bac34b ("mtd: nand: update mtd_to_nand()"), this assignment isn't necessary, since struct mtd_info is embedded in struct nand_chip. Signed-off-by: Brian Norris <computersforpeace@gmail.com> Cc: Harvey Hunt <harvey.hunt@imgtec.com> Cc: Boris Brezillon <boris.brezillon@free-electrons.com> Cc: Alex Smith <alex@alex-smith.me.uk> --- drivers/mtd/nand/jz4780_nand.c | 1 - 1 file changed, 1 deletion(-)