diff mbox

[mtd-utils] nandtest: support hex/dec/oct for --offset and --length

Message ID 1446163921-115867-1-git-send-email-computersforpeace@gmail.com
State Accepted
Commit 892f17ce795b64ba024989785ca62ef72299df52
Headers show

Commit Message

Brian Norris Oct. 30, 2015, 12:12 a.m. UTC 
These two options are handled inconsistently, which caused an
unnecessary amount of head scratching. Let's just use the simple helpers
too, so we get the error handling right.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
 nandtest.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Brian Norris Nov. 11, 2015, 10:06 p.m. UTC | #1 
On Thu, Oct 29, 2015 at 05:12:01PM -0700, Brian Norris wrote:
> These two options are handled inconsistently, which caused an
> unnecessary amount of head scratching. Let's just use the simple helpers
> too, so we get the error handling right.
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>

Pushed to mtd-utils.git
diff mbox

Patch

diff --git a/nandtest.c b/nandtest.c
index 08053876506a..2ef7cc824d59 100644
--- a/nandtest.c
+++ b/nandtest.c
@@ -15,6 +15,7 @@ 
 
 #include <asm/types.h>
 #include "mtd/mtd-user.h"
+#include "common.h"
 
 void usage(int status)
 {
@@ -154,6 +155,7 @@  int main(int argc, char **argv)
 	int keep_contents = 0;
 	uint32_t offset = 0;
 	uint32_t length = -1;
+	int error = 0;
 
 	seed = time(NULL);
 
@@ -205,17 +207,19 @@  int main(int argc, char **argv)
 			break;
 
 		case 'o':
-			offset = atol(optarg);
+			offset = simple_strtoul(optarg, &error);
 			break;
 
 		case 'l':
-			length = strtol(optarg, NULL, 0);
+			length = simple_strtoul(optarg, &error);
 			break;
 
 		}
 	}
 	if (argc - optind != 1)
 		usage(1);
+	if (error)
+		errmsg_die("Try --help for more information");
 
 	fd = open(argv[optind], O_RDWR);
 	if (fd < 0) {