From patchwork Tue Aug 4 15:26:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Han Xu X-Patchwork-Id: 503662 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 35453140E62 for ; Wed, 5 Aug 2015 01:36:59 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZMeFk-0003Zk-4g; Tue, 04 Aug 2015 15:35:44 +0000 Received: from mail-bn1on0116.outbound.protection.outlook.com ([157.56.110.116] helo=na01-bn1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZMeEb-0000la-6W for linux-mtd@lists.infradead.org; Tue, 04 Aug 2015 15:34:42 +0000 Received: from BLUPR03MB549.namprd03.prod.outlook.com (10.141.76.17) by BLUPR03MB004.namprd03.prod.outlook.com (10.255.208.38) with Microsoft SMTP Server (TLS) id 15.1.231.11; Tue, 4 Aug 2015 15:34:15 +0000 Received: from CH1PR03CA003.namprd03.prod.outlook.com (10.255.156.148) by BLUPR03MB549.namprd03.prod.outlook.com (10.141.76.17) with Microsoft SMTP Server (TLS) id 15.1.225.19; Tue, 4 Aug 2015 15:34:15 +0000 Received: from BL2FFO11FD006.protection.gbl (10.255.156.132) by CH1PR03CA003.outlook.office365.com (10.255.156.148) with Microsoft SMTP Server (TLS) id 15.1.225.19 via Frontend Transport; Tue, 4 Aug 2015 15:34:14 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD006.mail.protection.outlook.com (10.173.161.2) with Microsoft SMTP Server (TLS) id 15.1.243.9 via Frontend Transport; Tue, 4 Aug 2015 15:34:14 +0000 Received: from chopperman.am.freescale.net (chopperman.am.freescale.net [10.81.16.64]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id t74FYDSw026583; Tue, 4 Aug 2015 08:34:13 -0700 From: Han Xu To: Subject: [PATCH v4 10/10] mtd: spi-nor: fsl-quadspi: fix unsupported cmd when run flash_erase Date: Tue, 4 Aug 2015 10:26:16 -0500 Message-ID: <1438701976-27286-1-git-send-email-b45815@freescale.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD006; 1:pXas6on0xdMA5IrsoZkGYs2U9DTHPNPFpH+jHWH5i4gMZ4qRwAzm2NcorFJadkXa/+GjPunXbcAQpHV31PJfyQtVegyiH5bEPmVK4riXczDIbVZlBGYxvzHGrze4+zIcVOSGjG8h8rXzoyI7bIvWGnzyslIMxUKE+d8vvGA6RVKwGjtoXu11N+7O33jcs2wcEX7PTiO+a8wEt5/DrdUokALF0LpSQKx8ZllSTRMDgWoSSK3ts3ltD2LCMWXjWR6fWafo9T0cH84FGKpQfargH8Ivu0CgWh7qdW7yI9d9+K2JX7eTB3cPhYcKibRK2HCyyPFd4MKpb5KkDdnGJPP49A== X-Forefront-Antispam-Report: CIP:192.88.168.50; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(339900001)(189002)(199003)(50466002)(36756003)(107886002)(77156002)(229853001)(5001830100001)(106466001)(97736004)(5001960100002)(2351001)(5001860100001)(33646002)(110136002)(189998001)(4001540100001)(5003940100001)(105606002)(50986999)(62966003)(81156007)(50226001)(6806004)(47776003)(46102003)(19580395003)(87936001)(64706001)(104016003)(85426001)(48376002)(68736005)(92566002)(77096005)(19580405001)(4001430100001); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR03MB549; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB549; 2:YbvmPqUTE0xeElcK6+nK1yitN1cPAcEcB7cgeP4uFBAg799uLAfOURF6Rt3QJyqyv+1Wa642bms7L3gorBfz6iopdQYkH+LTO4V0MJSTg4W/4VxL+WbQqzuMObqp4kQfgmSPuVfN2dnIFWHeED3GpVUPULG3YcM48LqyjviyZoc=; 3:k3S59z6pL2fJCXWXEsGETnC9byEuG5nQVx8GoeLsM9Nw1N+gsZ59jBiu9pfa7VwTwTJVJH9xrX3GMOKFyJ/9h6ujdUBsFVrktgSgA6KmJVsF9pjgNW56M/9CRc+HVPDXfCescC4pTuPvXeMTlvO7uTBZcA6PRsSUrnrH81edlJKn/fJW1xWSZxuNRxamyFO+Ko0arkJh9PEexSNlkMVyucL7kb8wzfWZLfveSjelywg=; 25:lCXUbaw2LobbuHBjFFmVaN8epVj9jnzidIz5eDE41gncJGOTuC9ZvRr+gZQ0CGFMQ1pdko1aMtEhLU1GWy13vSlkIXXk/VmWeQnFt+HWdG9DPnM2XBfjQNxsTWsP0ruq2IdpybFSsXvn9gvxbcKiXZ/LYzRdq7PlSF/2yitvNon4ZxruQux259LC2vbMYwu33Sj5AnkRMp1soncNn7BtrrOzGHTydxXpcx3QNvPhwZ3As2m4fYjF/tLIM21qJ3lFTMWp5qIoHd4QHBwIlaayhg== X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB549; UriScan:; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB004; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB549; 20:ScNkAgzk0YutBEMZlu+DqyHzdXwC1Rlj14qgP2ukzw7YDr+ZeA/fqcWAA/gBetGgIFk4diGdEuyvOQHsGdS/i4t9xlnjrdXRtY07O+KSifGB3V8R8ok7opFjUegYxFvjP+wfut16xznMqZKFgExs6xS3RFR2YDIPW31gnxDXO0QohApqypfz/jKLEnfYUevZ+Jai+kZYDjAmZja+rZ1X/yqzBAcXZFc8JcQ40ycE0sURnrwW4QIiBufMYvpUajL2BHNMGDyE8JldaO2vQvJsm6neRhA1lqb/wpJBzjh/xyedRMPSyOXWl4+UoR9S2Ed7cfWXaUnu/UFWp4wfa8iRdLXhOWl6XmkOXnwoUWEj16w=; 4:KUjCS+weWYtVLceMixbFVW3vkhKDimnCySwEbxn+9CDOZjNqxuAV0vtixi9bju0lLZ3R+JAx78I86cluiDeUV19F0ux+txSuIIB67gTdrMtgZZOZUQXu00giMKPX0jFGLrbsWupvkvL/dBJfHETpyOEcFzOXU8kdqWhVjqi5oFT9lA7uaXpGNG8j2QV+ay9bYnwZvjK5tbFO/h1L5ROHyWzrDmN7x4HadzUZEhvmmPt48opOBVVvSiiHIX2Dpbn8rQcFCmSSk4LjN1RKdfT3OCh8aoEqiyZrBVz9fyjgIg4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BLUPR03MB549; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB549; X-Forefront-PRVS: 0658BAF71F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR03MB549; 23:5ImY0wZq9GUMbDXAlbU9LzU71VAQqgRXim/ls+sByn?= =?us-ascii?Q?XGa/OYHHRu3Np4p1RJ9upfmbYiSB/qTQall+4itAN/1GQyZ9KFkP64xk8mmT?= =?us-ascii?Q?9QqbIrDWYb+o/J34jnDiGrDbjaxXkCHW1jMMumNJaER9HMdORD+XnteZol1Q?= =?us-ascii?Q?Elk6UtH+Ru/CW5n/+tygsyH3w4iy6JATINWWUpIWocNKLvhHLypjxONLPPAT?= =?us-ascii?Q?Tbf+3/tuvibipcn5kZD4JzOQ7woMMnI7j0HXc4h/WhHGH9NdWARcqocb0A6r?= =?us-ascii?Q?lttn4B6WJUT8oYXxag7EqmjsxzOqg3J7O1AbCwUNu5pKGoAHi7rr0yt2LJu6?= =?us-ascii?Q?XX/B1Pw+icM1orBGCSFCq42S7se5+3TbG5Ui3ThhTMAmQQv2EZFgdA461lla?= =?us-ascii?Q?8mDPk3wMbzZKcy7+SrlPj84UkQVRfJlz8A8AGygd3ilrbDVa1kXTWwO/qbmn?= =?us-ascii?Q?QwNgqZQvBY3kjWyPLleaB+vXuYjxK0rPeaevePm6vGt8aYYhCIIyWn51pXBh?= =?us-ascii?Q?9P8YeTH9GoXKyNHnvvi1k4EC8rtjkHmKerBWFK7HJAyGGJsmRt8iR6JXJcmO?= =?us-ascii?Q?a3teGiKA7lAz65+Af8iDzKacaw84e2A3pI5Bprr6j1ZvVCi9qgq2euWi4U3b?= =?us-ascii?Q?g4+LBM7pmAGGWUKkOENWhAVF8mUzo9ic0/Qfb3iUYvi9LdP0MDheV/Lzr6Oi?= =?us-ascii?Q?G/rc19Sw+mBDtTRBOCSERZVHpIAruiTRNY+EmmFxeHs+5Bh3Y76ZUBtqt0qF?= =?us-ascii?Q?5D2ZeeTM3yTRGQM+3xZIEsoF5bxkVnL/EX/5UTWtMdn0hansQDz/Axz5k1ZI?= =?us-ascii?Q?eAmTidXy2Pbj0RkGD+KmKOAZZ39ynEL429Sq2RdxA2ekliA7GAFExvhsT6DB?= =?us-ascii?Q?TX49B9FSYEBW/7Z6MlkRHJYBc/Yxfwx4KjVapmHe+RbHjaOaSb0aheRn71VD?= =?us-ascii?Q?OCn0eoHvvrIA4de9SdWr7cuodMrirOYVJsLospzeKJudA0x6C7Bc1mJVZelL?= =?us-ascii?Q?RqIcuwbgt4YpGiX9WuT2Fs7aXABWYCpr5CMGMMJLFFEB/VMafi+AxcfV7D6C?= =?us-ascii?Q?jrdbdFLXSmeYYQ/ZjL7izV1BGC?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB549; 5:Ji1NgUMUYJKNggmNIrCJW7BmiQwGdW0Q1GEt1nBGJ7B2PCX41KcBiw+zcQw8k22W95uZRxQqR3ukqsHMSWFlzjY1UJtoH4SJnl99Izs6kGh4LJKI6XPxa23ScTGHv8C7UhgACe/Cwa0/3+ZBkmd4Hg==; 24:8K5gIDcjxAfRrrF3CyGj9kLSGARDRxGxuT+vKEfIE9noQPU1FrHlnHdKvE8irAf1WwfdIoAgHQhlPTN8fKmOCV1sBlk/X2AfE8TbjPsDDNU=; 20:VGeqlJHC839s0IwjqKBZwkW6m84OTd3Qi7Eer+ldWvdfIeKgnw1vjpJG1WuQRJS6Rs7q26W2id4TI5vWXkPQ1g== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2015 15:34:14.5210 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB549 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB004; 2:/p8+r9lN+574oocKdDsPhhVEsfalMkwwQpDTRQeBzjUsEf3FOOGtVRRsxp8THmK49vB57elgPPsxLVZJkogaHjnW0VhuofXl8xqdfzn4xCG+kP/U33yMaomG7mVTNl8dg2356rYcJRfn5c6q5dg/2c02DujGnn4jlEdnjMmO8UY=; 3:UCaMNS0CvUUxJyJBSXYclqJzvZoFKa8Y0cZeRwaKviE/JCr2+bhI8nA9D6l15FarCfphDhxFAQ9uXjbWFivulYL9KwZx4qkQzZ4h1TbZpaRaCdWqTrC70r8oEOKfIxcoxLM76ODUqnqMNavG+JWO0+MSMd8RJsx9UUe4eZ5k7spnDMdcJVKYGNeYVjfjgWXrcizpE4rv88abCv3S8qgTTc14/jz2BrwX94HGgEVaFcE=; 25:LNcQG/llogWkd5q0myjtouuF3oow6m/EbN0Tus7iuQCVBfgk0CyX7yDfvqNR+46qRvV6RsbQh0LqTx9LVU8Wj9efB7LgV0f7hS6d4yY7bpBeNkz7XUiQ+XCvtygzPF3VLdumQrdnD4QDd3Jj+PETgup1GPA/R/UzXWyoSEm935d3Ch2E6Wmtjfv+v+6uXrVKvvgY+aISgFPr+ulKkYRc3FeOBKErYuVPlLcwW6RcSB4bmKvRoeUjmayhdirgs9WrUUqHk6q105o0BPXQc3PaVg==; 23:5NHmuGRin/+UfVZ5A2B2eFtb8+iOhPr16wVWtZThIeqSvZnfZ2WaJge6KltXYaxEahUPBtomLuxlq+W2WRslWEQU/m9zmMEaPv56fkco8ASX4qLx2CZY07J9Ql0L0M6K8kMLVT1ZCPc49dTlvsj+qZf1Npojm/y+tU8IxKPsawNMgAVDO6xFr3yjtsmcir1i X-OriginatorOrg: freescale.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150804_083434_258645_FC1804A7 X-CRM114-Status: GOOD ( 17.86 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [157.56.110.116 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [157.56.110.116 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: frank.li@freescale.com, linux-mtd@lists.infradead.org, han.xu@freescale.com Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Frank Li Erase function will use cmd 0x20 (SPINOR_OP_BE_4K) if kenrel enable option CONFIG_MTD_SPI_NOR_USE_4K_SECTORS. This command is not in fsl-quadspi driver LUT. So driver continue report fsl-quadspi 21e0000.qspi: Unsupported cmd 0x20. This patch fix this issue. Signed-off-by: Frank Li Acked-by: Han Xu --- drivers/mtd/spi-nor/fsl-quadspi.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index d09fb28..66d1eb8 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -397,14 +397,8 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q) /* Erase a sector */ lut_base = SEQID_SE * 4; - if (q->nor_size <= SZ_16M) { - cmd = SPINOR_OP_SE; - addrlen = ADDR24BIT; - } else { - /* use the 4-byte address */ - cmd = SPINOR_OP_SE; - addrlen = ADDR32BIT; - } + cmd = q->nor[0].erase_opcode; + addrlen = q->nor_size <= SZ_16M ? ADDR24BIT : ADDR32BIT; writel(LUT0(CMD, PAD1, cmd) | LUT1(ADDR, PAD1, addrlen), base + QUADSPI_LUT(lut_base)); @@ -473,6 +467,8 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) case SPINOR_OP_BRWR: return SEQID_BRWR; default: + if (cmd == q->nor[0].erase_opcode) + return SEQID_SE; dev_err(q->dev, "Unsupported cmd 0x%.2x\n", cmd); break; }