diff mbox

mtd: denali: Use module_pci_driver()

Message ID 1436334843-27480-1-git-send-email-rajatja@google.com
State Accepted
Commit 2445d33d852320d4ce700b2428d60991f8cf478f
Headers show

Commit Message

Rajat Jain July 8, 2015, 5:54 a.m. UTC 
Use module_pci_driver, since init and exit functions only register
and unregister the pci driver, respectively.

Signed-off-by: Rajat Jain <rajatja@google.com>
Signed-off-by: Rajat Jain <rajatxjain@gmail.com>
---
 drivers/mtd/nand/denali_pci.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Comments

Brian Norris Aug. 19, 2015, 12:29 a.m. UTC | #1 
On Tue, Jul 07, 2015 at 10:54:03PM -0700, Rajat Jain wrote:
> Use module_pci_driver, since init and exit functions only register
> and unregister the pci driver, respectively.
> 
> Signed-off-by: Rajat Jain <rajatja@google.com>
> Signed-off-by: Rajat Jain <rajatxjain@gmail.com>

I pushed an identical patch to l2-mtd.git from another author. Didn't
notice yours until now. Thanks anyway!

Brian
diff mbox

Patch

diff --git a/drivers/mtd/nand/denali_pci.c b/drivers/mtd/nand/denali_pci.c
index 6e2f387..29e5d0c 100644
--- a/drivers/mtd/nand/denali_pci.c
+++ b/drivers/mtd/nand/denali_pci.c
@@ -129,14 +129,4 @@  static struct pci_driver denali_pci_driver = {
 	.remove = denali_pci_remove,
 };
 
-static int denali_init_pci(void)
-{
-	return pci_register_driver(&denali_pci_driver);
-}
-module_init(denali_init_pci);
-
-static void denali_exit_pci(void)
-{
-	pci_unregister_driver(&denali_pci_driver);
-}
-module_exit(denali_exit_pci);
+module_pci_driver(denali_pci_driver);