diff mbox

[RESEND] jffs2: remove unneeded kfree

Message ID 1436237666-27398-1-git-send-email-fangwei1@huawei.com
State Accepted
Commit 16c863bbf4dabc1ff67d5c67d2d6e614211528d4
Headers show

Commit Message

fangwei July 7, 2015, 2:54 a.m. UTC
c->oobbuf hasn't been kmalloced in jffs2_dataflash_setup, so
there is no need to free it.

Signed-off-by: Wei Fang <fangwei1@huawei.com>
---
 fs/jffs2/wbuf.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Brian Norris Sept. 29, 2015, 1:42 a.m. UTC | #1
On Tue, Jul 07, 2015 at 10:54:26AM +0800, Wei Fang wrote:
> c->oobbuf hasn't been kmalloced in jffs2_dataflash_setup, so
> there is no need to free it.
> 
> Signed-off-by: Wei Fang <fangwei1@huawei.com>

Applied to l2-mtd.git
diff mbox

Patch

diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c
index 09ed551..63f31c0 100644
--- a/fs/jffs2/wbuf.c
+++ b/fs/jffs2/wbuf.c
@@ -1274,7 +1274,6 @@  int jffs2_dataflash_setup(struct jffs2_sb_info *c) {
 #ifdef CONFIG_JFFS2_FS_WBUF_VERIFY
 	c->wbuf_verify = kmalloc(c->wbuf_pagesize, GFP_KERNEL);
 	if (!c->wbuf_verify) {
-		kfree(c->oobbuf);
 		kfree(c->wbuf);
 		return -ENOMEM;
 	}